You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/08/04 19:02:20 UTC
[jira] [Commented] (BEAM-401) StandardCoder uses inefficient string
concatenation
[ https://issues.apache.org/jira/browse/BEAM-401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15408336#comment-15408336 ]
ASF GitHub Bot commented on BEAM-401:
-------------------------------------
GitHub user chandnisingh opened a pull request:
https://github.com/apache/incubator-beam/pull/789
BEAM-401 used StringBuilder in toString of StandardCoder
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chandnisingh/incubator-beam BEAM-401
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/789.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #789
----
commit 5734fdfd571e8d6063678439da628918b680e21f
Author: Chandni Singh <ch...@capitalone.com>
Date: 2016-08-04T19:00:41Z
BEAM-401 used StringBuilder in toString of StandardCoder
----
> StandardCoder uses inefficient string concatenation
> ---------------------------------------------------
>
> Key: BEAM-401
> URL: https://issues.apache.org/jira/browse/BEAM-401
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Scott Wegner
> Assignee: Chandni Singh
> Priority: Minor
> Labels: findbugs, newbie, starter
>
> [FindBugs SBSC_USE_STRINGBUFFER_CONCATENATION|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml#L107]: Method invokes inefficient new String(String) constructor
> Applies to: [StandardCoder.toString|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/core/src/main/java/org/apache/beam/sdk/coders/StandardCoder.java#L104].
> This is a good starter bug. When fixing, please remove the corresponding entries from [findbugs-filter.xml|https://github.com/apache/incubator-beam/blob/master/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml] and verify the build passes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)