[GitHub] [incubator-superset] john-bodley commented on a change in pull request #8782: Adding updates to CONTRIBUTING and UPDATING for app factory changes

[GitBox <gi...@apache.org>]

john-bodley commented on a change in pull request #8782: Adding updates to CONTRIBUTING and UPDATING for app factory changes
URL: https://github.com/apache/incubator-superset/pull/8782#discussion_r354983208
 
 

 ##########
 File path: UPDATING.md
 ##########
 @@ -38,6 +38,10 @@ defaults to False. To enable Druid-API-based functionality, override the
 * [8450](https://github.com/apache/incubator-superset/pull/8450): The time range picker
 now uses UTC for the tooltips and default placeholder timestamps (sans timezone).
 
+* [8418](https://github.com/apache/incubator-superset/pull/8418): FLASK_APP / Worker App
+have changed. FLASK_APP should be updated to `superset.app:create_app()` and Celery Workers
+should be started with `--app=superset.tasks.celery_app.app`
 
 Review comment:
   @craig-rueda I think `celery_app.app` should be `celery_app:app` for consistency with `CONTRIBUTING.md` (event though both work).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org