Re: [PR] HDDS-14903. Fix Trace Hierarchy for Freon s3bg Command [ozone]

["sumitagrawl (via GitHub)" <gi...@apache.org>]

sumitagrawl commented on code in PR #10020:
URL: https://github.com/apache/ozone/pull/10020#discussion_r3180731162


##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/tracing/TracingUtil.java:
##########
@@ -352,4 +355,50 @@ private static Span buildSpan(String spanName) {
       return tracer.spanBuilder(spanName).setNoParent().startSpan();
     }
   }
+
+  public static TraceCloseable createActivatedSpanFromW3cHttpHeaders(
+      String spanName, Function<String, String> getHeader, ConfigurationSource conf) {
+    if (conf == null || !isTracingEnabled(conf)) {
+      return () -> {
+      };
+    }
+
+    final class HeaderCarrier {

Review Comment:
   we can remove this extra classes, both HeaderCarrier and getter



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org