[GitHub] [incubator-superset] villebro commented on pull request #9692: [sqllab] fix, strip comments before parsing statements

[GitBox <gi...@apache.org>]

villebro commented on pull request #9692:
URL: https://github.com/apache/incubator-superset/pull/9692#issuecomment-622119047


   If I understand this correctly, `sqlparse` is flagging a false positive on DML. I'm fine with a workaround for this, but in that case I'd prefer to make sure we've made sure this isn't fixed in an upcoming version of `sqlparse`, and also adding a unit test with a `# TODO:` to make sure we can remove the workaround later.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org