You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by skonto <gi...@git.apache.org> on 2018/08/01 17:43:21 UTC

[GitHub] spark pull request #21669: [SPARK-23257][K8S][WIP] Kerberos Support for Spar...

Github user skonto commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21669#discussion_r206970881
  
    --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala ---
    @@ -107,7 +109,14 @@ private[spark] class Client(
       def run(): Unit = {
         val resolvedDriverSpec = builder.buildFromFeatures(kubernetesConf)
         val configMapName = s"$kubernetesResourceNamePrefix-driver-conf-map"
    -    val configMap = buildConfigMap(configMapName, resolvedDriverSpec.systemProperties)
    +    val isKerberosEnabled = kubernetesConf.getTokenManager.isSecurityEnabled
    +    // HADOOP_SECURITY_AUTHENTICATION is defined as simple for the driver and executors as
    +    // they need only the delegation token to access secure HDFS, no need to sign in to Kerberos
    +    val maybeSimpleAuthentication =
    +      if (isKerberosEnabled) Some((s"-D$HADOOP_SECURITY_AUTHENTICATION", "simple")) else None
    --- End diff --
    
    I agree users may want also to have non spark code that fetches a file from hdfs at the driver level.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org