You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/25 20:54:22 UTC

[GitHub] [superset] codecov[bot] commented on pull request #13346: Elizabeth/db connection analytics

codecov[bot] commented on pull request #13346:
URL: https://github.com/apache/superset/pull/13346#issuecomment-786196427


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13346?src=pr&el=h1) Report
   > Merging [#13346](https://codecov.io/gh/apache/superset/pull/13346?src=pr&el=desc) (345cd02) into [db-connection-logs](https://codecov.io/gh/apache/superset/commit/23d94116cdfd13e6ea4474ae95fe6695d80436dc?el=desc) (23d9411) will **increase** coverage by `7.24%`.
   > The diff coverage is `95.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13346/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13346?src=pr&el=tree)
   
   ```diff
   @@                  Coverage Diff                   @@
   ##           db-connection-logs   #13346      +/-   ##
   ======================================================
   + Coverage               72.83%   80.07%   +7.24%     
   ======================================================
     Files                     567      298     -269     
     Lines                   20677    24265    +3588     
     Branches                 5351        0    -5351     
   ======================================================
   + Hits                    15060    19431    +4371     
   + Misses                   5494     4834     -660     
   + Partials                  123        0     -123     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `80.07% <95.00%> (?)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13346?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/13346/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `98.07% <91.66%> (ø)` | |
   | [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/13346/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `84.61% <100.00%> (ø)` | |
   | [superset-frontend/src/components/Popover/index.tsx](https://codecov.io/gh/apache/superset/pull/13346/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUG9wb3Zlci9pbmRleC50c3g=) | | |
   | [...rset-frontend/src/dashboard/actions/datasources.js](https://codecov.io/gh/apache/superset/pull/13346/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2RhdGFzb3VyY2VzLmpz) | | |
   | [...set-frontend/src/components/URLShortLinkButton.jsx](https://codecov.io/gh/apache/superset/pull/13346/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVVJMU2hvcnRMaW5rQnV0dG9uLmpzeA==) | | |
   | [superset-frontend/src/utils/reducerUtils.js](https://codecov.io/gh/apache/superset/pull/13346/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL3JlZHVjZXJVdGlscy5qcw==) | | |
   | [...erset-frontend/src/messageToasts/reducers/index.js](https://codecov.io/gh/apache/superset/pull/13346/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvcmVkdWNlcnMvaW5kZXguanM=) | | |
   | [...uperset-frontend/src/components/Checkbox/index.tsx](https://codecov.io/gh/apache/superset/pull/13346/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hlY2tib3gvaW5kZXgudHN4) | | |
   | [...rontend/src/components/Loading/Loading.stories.tsx](https://codecov.io/gh/apache/superset/pull/13346/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTG9hZGluZy9Mb2FkaW5nLnN0b3JpZXMudHN4) | | |
   | [...rontend/src/views/CRUD/dashboard/DashboardCard.tsx](https://codecov.io/gh/apache/superset/pull/13346/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZENhcmQudHN4) | | |
   | ... and [857 more](https://codecov.io/gh/apache/superset/pull/13346/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13346?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13346?src=pr&el=footer). Last update [23d9411...eabd614](https://codecov.io/gh/apache/superset/pull/13346?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org