You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "eladkal (via GitHub)" <gi...@apache.org> on 2023/03/11 01:56:14 UTC

[GitHub] [airflow] eladkal commented on a diff in pull request #30033: Remove upper bound limit of astroid

eladkal commented on code in PR #30033:
URL: https://github.com/apache/airflow/pull/30033#discussion_r1133008756


##########
setup.py:
##########
@@ -248,9 +248,7 @@ def write_version(filename: str = str(AIRFLOW_SOURCES_ROOT / "airflow" / "git_ve
     "requests>=2.26.0",
 ]
 doc = [
-    # Astroid 2.12.* breaks documentation building
-    # We can remove the limit here after https://github.com/PyCQA/astroid/issues/1708 is solved
-    "astroid<2.12.0",
+    "astroid",

Review Comment:
   ```suggestion
       "astroid>=2.12.3",
   ```
   Don't we need to bump to the version that contains the fix?
   or at least skip the ones known to have the issue: `!=2.12.0, !=2.12.1, !=2.12.2` ?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org