You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "Henry Saputra (JIRA)" <ji...@apache.org> on 2011/08/10 16:46:27 UTC
[jira] [Created] (KAFKA-93) Change code header to follow standard
ASF source header
Change code header to follow standard ASF source header
--------------------------------------------------------
Key: KAFKA-93
URL: https://issues.apache.org/jira/browse/KAFKA-93
Project: Kafka
Issue Type: Task
Reporter: Henry Saputra
Priority: Minor
Need to update Kafka code to include ASF standard source header: http://www.apache.org/legal/src-headers.html
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KAFKA-93) Change code header to follow standard
ASF source header
Posted by "Henry Saputra (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-93?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henry Saputra updated KAFKA-93:
-------------------------------
Description:
Need to update Kafka code to include ASF standard source header: http://www.apache.org/legal/src-headers.html
I think most Kafka code already have the ASF header. Just need to remove the copyrights section of the comment per guideline.
was:Need to update Kafka code to include ASF standard source header: http://www.apache.org/legal/src-headers.html
> Change code header to follow standard ASF source header
> --------------------------------------------------------
>
> Key: KAFKA-93
> URL: https://issues.apache.org/jira/browse/KAFKA-93
> Project: Kafka
> Issue Type: Task
> Reporter: Henry Saputra
> Priority: Minor
>
> Need to update Kafka code to include ASF standard source header: http://www.apache.org/legal/src-headers.html
> I think most Kafka code already have the ASF header. Just need to remove the copyrights section of the comment per guideline.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-93) Change code header to follow standard
ASF source header
Posted by "Henry Saputra (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13082590#comment-13082590 ]
Henry Saputra commented on KAFKA-93:
------------------------------------
Hi Jakob, I think for this case not much review needed. I just change the header comment.
You can take a look at list of file changed in the Subversion Commits tab for this Jira.
> Change code header to follow standard ASF source header
> --------------------------------------------------------
>
> Key: KAFKA-93
> URL: https://issues.apache.org/jira/browse/KAFKA-93
> Project: Kafka
> Issue Type: Task
> Reporter: Henry Saputra
> Assignee: Henry Saputra
> Priority: Minor
> Fix For: 0.8
>
>
> Need to update Kafka code to include ASF standard source header: http://www.apache.org/legal/src-headers.html
> I think most Kafka code already have the ASF header. Just need to remove the copyrights section of the comment per guideline.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-93) Change code header to follow standard
ASF source header
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13082576#comment-13082576 ]
Jakob Homan commented on KAFKA-93:
----------------------------------
@Henry - I believe, per the user mailing list, we're using RTC for patches in Kafka, so you need to upload the patch you'd like to commit and get a +1 before actually applying it. Can you upload the patch you've committed?
> Change code header to follow standard ASF source header
> --------------------------------------------------------
>
> Key: KAFKA-93
> URL: https://issues.apache.org/jira/browse/KAFKA-93
> Project: Kafka
> Issue Type: Task
> Reporter: Henry Saputra
> Assignee: Henry Saputra
> Priority: Minor
> Fix For: 0.8
>
>
> Need to update Kafka code to include ASF standard source header: http://www.apache.org/legal/src-headers.html
> I think most Kafka code already have the ASF header. Just need to remove the copyrights section of the comment per guideline.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (KAFKA-93) Change code header to follow standard
ASF source header
Posted by "Henry Saputra (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-93?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henry Saputra resolved KAFKA-93.
--------------------------------
Resolution: Fixed
Fix Version/s: 0.8
Assignee: Henry Saputra
Committed as revision 1156232.
> Change code header to follow standard ASF source header
> --------------------------------------------------------
>
> Key: KAFKA-93
> URL: https://issues.apache.org/jira/browse/KAFKA-93
> Project: Kafka
> Issue Type: Task
> Reporter: Henry Saputra
> Assignee: Henry Saputra
> Priority: Minor
> Fix For: 0.8
>
>
> Need to update Kafka code to include ASF standard source header: http://www.apache.org/legal/src-headers.html
> I think most Kafka code already have the ASF header. Just need to remove the copyrights section of the comment per guideline.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-93) Change code header to follow standard
ASF source header
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13083859#comment-13083859 ]
Jakob Homan commented on KAFKA-93:
----------------------------------
It's done now and we've clarified the correct procedure going forward, so it's fine.
> Change code header to follow standard ASF source header
> --------------------------------------------------------
>
> Key: KAFKA-93
> URL: https://issues.apache.org/jira/browse/KAFKA-93
> Project: Kafka
> Issue Type: Task
> Reporter: Henry Saputra
> Assignee: Henry Saputra
> Priority: Minor
> Fix For: 0.8
>
>
> Need to update Kafka code to include ASF standard source header: http://www.apache.org/legal/src-headers.html
> I think most Kafka code already have the ASF header. Just need to remove the copyrights section of the comment per guideline.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-93) Change code header to follow standard
ASF source header
Posted by "Henry Saputra (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13082637#comment-13082637 ]
Henry Saputra commented on KAFKA-93:
------------------------------------
@Jakob From the ASF license file itself:
APPENDIX: How to apply the Apache License to your work.
To apply the Apache License to your work, attach the following
boilerplate notice, with the fields enclosed by brackets "[]"
replaced with your own identifying information. (Don't include
the brackets!) The text should be enclosed in the appropriate
comment syntax for the file format. We also recommend that a
file or class name and description of purpose be included on the
same "printed page" as the copyright notice for easier
identification within third-party archives.
Copyright [yyyy] [name of copyright owner]
....
The boiler plate is used to add Apache license to you own source which LinkedIn has done before moving Kafka to ASF incubator. Since Kafka is moving under ASF umbrella I modified the header comment to follow ASF guideline.
Please let me know if I have interpreted this incorrectly.
> Change code header to follow standard ASF source header
> --------------------------------------------------------
>
> Key: KAFKA-93
> URL: https://issues.apache.org/jira/browse/KAFKA-93
> Project: Kafka
> Issue Type: Task
> Reporter: Henry Saputra
> Assignee: Henry Saputra
> Priority: Minor
> Fix For: 0.8
>
>
> Need to update Kafka code to include ASF standard source header: http://www.apache.org/legal/src-headers.html
> I think most Kafka code already have the ASF header. Just need to remove the copyrights section of the comment per guideline.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-93) Change code header to follow standard
ASF source header
Posted by "Henry Saputra (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13082663#comment-13082663 ]
Henry Saputra commented on KAFKA-93:
------------------------------------
Looks like all of them has LinkedIn as Copyright holder in the LICENSE.
> Change code header to follow standard ASF source header
> --------------------------------------------------------
>
> Key: KAFKA-93
> URL: https://issues.apache.org/jira/browse/KAFKA-93
> Project: Kafka
> Issue Type: Task
> Reporter: Henry Saputra
> Assignee: Henry Saputra
> Priority: Minor
> Fix For: 0.8
>
>
> Need to update Kafka code to include ASF standard source header: http://www.apache.org/legal/src-headers.html
> I think most Kafka code already have the ASF header. Just need to remove the copyrights section of the comment per guideline.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-93) Change code header to follow standard
ASF source header
Posted by "Henry Saputra (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13082786#comment-13082786 ]
Henry Saputra commented on KAFKA-93:
------------------------------------
Hi @Jakob, so are you ok with the checkins, especially the copyright issue you brought up before?
> Change code header to follow standard ASF source header
> --------------------------------------------------------
>
> Key: KAFKA-93
> URL: https://issues.apache.org/jira/browse/KAFKA-93
> Project: Kafka
> Issue Type: Task
> Reporter: Henry Saputra
> Assignee: Henry Saputra
> Priority: Minor
> Fix For: 0.8
>
>
> Need to update Kafka code to include ASF standard source header: http://www.apache.org/legal/src-headers.html
> I think most Kafka code already have the ASF header. Just need to remove the copyrights section of the comment per guideline.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-93) Change code header to follow standard
ASF source header
Posted by "Joel Koshy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13082510#comment-13082510 ]
Joel Koshy commented on KAFKA-93:
---------------------------------
Hi Henry, there are a few more files:
grep -irH linkedin * | grep -v \.svn
LICENSE: Copyright 2010 LinkedIn
clients/clojure/LICENSE:Copyright 2011 LinkedIn
clients/cpp/LICENSE:Copyright 2011 LinkedIn
clients/csharp/LICENSE:Copyright 2011 LinkedIn
clients/php/LICENSE:Copyright 2011 LinkedIn
clients/python/kafka.py:# Copyright 2010 LinkedIn
clients/python/setup.py: author='LinkedIn.com',
clients/ruby/LICENSE:Copyright 2011 LinkedIn
core/src/main/scala/kafka/tools/GetOffsetShell.scala:* Copyright 2010 LinkedIn
core/src/test/scala/unit/kafka/producer/ProducerMethodsTest.scala: * Copyright 2011 LinkedIn
perf/.classpath: <classpathentry kind="lib" path="/Users/femekci/linkedInSrc/kafka-multifetch/lib/scala-library-2.8.0.jar"/>
perf/.classpath: <classpathentry kind="lib" path="/Users/femekci/linkedInSrc/kafka-multifetch/dist/kafka-0.04.6.0.jar"/>
> Change code header to follow standard ASF source header
> --------------------------------------------------------
>
> Key: KAFKA-93
> URL: https://issues.apache.org/jira/browse/KAFKA-93
> Project: Kafka
> Issue Type: Task
> Reporter: Henry Saputra
> Assignee: Henry Saputra
> Priority: Minor
> Fix For: 0.8
>
>
> Need to update Kafka code to include ASF standard source header: http://www.apache.org/legal/src-headers.html
> I think most Kafka code already have the ASF header. Just need to remove the copyrights section of the comment per guideline.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-93) Change code header to follow standard
ASF source header
Posted by "Henry Saputra (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13082665#comment-13082665 ]
Henry Saputra commented on KAFKA-93:
------------------------------------
But previously LinkedIn has applied LICENSE file incorrectly in Kafka source tree. AFAIK, the Copyright [yyyy] [name of copyright owner] template is only replaced if you want to add ASF 2.0 license to your source code.
You dont actually change the LICENSE file. Again please correct me if I am wrong.
> Change code header to follow standard ASF source header
> --------------------------------------------------------
>
> Key: KAFKA-93
> URL: https://issues.apache.org/jira/browse/KAFKA-93
> Project: Kafka
> Issue Type: Task
> Reporter: Henry Saputra
> Assignee: Henry Saputra
> Priority: Minor
> Fix For: 0.8
>
>
> Need to update Kafka code to include ASF standard source header: http://www.apache.org/legal/src-headers.html
> I think most Kafka code already have the ASF header. Just need to remove the copyrights section of the comment per guideline.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-93) Change code header to follow standard
ASF source header
Posted by "Joel Koshy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13082514#comment-13082514 ]
Joel Koshy commented on KAFKA-93:
---------------------------------
Also, do test bash scripts (e.g., the system tests) need the license. How about config files? Do these fall under "source"? I don't see any comment on this in http://www.apache.org/legal/src-headers.html
> Change code header to follow standard ASF source header
> --------------------------------------------------------
>
> Key: KAFKA-93
> URL: https://issues.apache.org/jira/browse/KAFKA-93
> Project: Kafka
> Issue Type: Task
> Reporter: Henry Saputra
> Assignee: Henry Saputra
> Priority: Minor
> Fix For: 0.8
>
>
> Need to update Kafka code to include ASF standard source header: http://www.apache.org/legal/src-headers.html
> I think most Kafka code already have the ASF header. Just need to remove the copyrights section of the comment per guideline.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (KAFKA-93) Change code header to follow standard
ASF source header
Posted by "Henry Saputra (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-93?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henry Saputra reopened KAFKA-93:
--------------------------------
Re-open for missing source and script files.
> Change code header to follow standard ASF source header
> --------------------------------------------------------
>
> Key: KAFKA-93
> URL: https://issues.apache.org/jira/browse/KAFKA-93
> Project: Kafka
> Issue Type: Task
> Reporter: Henry Saputra
> Assignee: Henry Saputra
> Priority: Minor
> Fix For: 0.8
>
>
> Need to update Kafka code to include ASF standard source header: http://www.apache.org/legal/src-headers.html
> I think most Kafka code already have the ASF header. Just need to remove the copyrights section of the comment per guideline.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-93) Change code header to follow standard
ASF source header
Posted by "Henry Saputra (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13082607#comment-13082607 ]
Henry Saputra commented on KAFKA-93:
------------------------------------
You are talking about Copyright [yyyy] [name of copyright owner]?
I thought this is just template that need to fill in by someone including Kafka in their project?
I will follow RTC process next time.
> Change code header to follow standard ASF source header
> --------------------------------------------------------
>
> Key: KAFKA-93
> URL: https://issues.apache.org/jira/browse/KAFKA-93
> Project: Kafka
> Issue Type: Task
> Reporter: Henry Saputra
> Assignee: Henry Saputra
> Priority: Minor
> Fix For: 0.8
>
>
> Need to update Kafka code to include ASF standard source header: http://www.apache.org/legal/src-headers.html
> I think most Kafka code already have the ASF header. Just need to remove the copyrights section of the comment per guideline.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (KAFKA-93) Change code header to follow standard
ASF source header
Posted by "Henry Saputra (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-93?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henry Saputra resolved KAFKA-93.
--------------------------------
Resolution: Fixed
Remove LinkedIn copyrights line and add ASF to some files.
We will just add changes directly for missing ASF license header. Closing this as resolved.
> Change code header to follow standard ASF source header
> --------------------------------------------------------
>
> Key: KAFKA-93
> URL: https://issues.apache.org/jira/browse/KAFKA-93
> Project: Kafka
> Issue Type: Task
> Reporter: Henry Saputra
> Assignee: Henry Saputra
> Priority: Minor
> Fix For: 0.8
>
>
> Need to update Kafka code to include ASF standard source header: http://www.apache.org/legal/src-headers.html
> I think most Kafka code already have the ASF header. Just need to remove the copyrights section of the comment per guideline.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-93) Change code header to follow standard
ASF source header
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13082598#comment-13082598 ]
Jakob Homan commented on KAFKA-93:
----------------------------------
@Henry - the LICENSE files you've committed are incorrect in that you didn't replace the copyright year or name of copyright holder from the boiler text. Perhaps, had the patch been uploaded for review as part of the RTC process that's been agreed upon, this would have been caught before the commit.
> Change code header to follow standard ASF source header
> --------------------------------------------------------
>
> Key: KAFKA-93
> URL: https://issues.apache.org/jira/browse/KAFKA-93
> Project: Kafka
> Issue Type: Task
> Reporter: Henry Saputra
> Assignee: Henry Saputra
> Priority: Minor
> Fix For: 0.8
>
>
> Need to update Kafka code to include ASF standard source header: http://www.apache.org/legal/src-headers.html
> I think most Kafka code already have the ASF header. Just need to remove the copyrights section of the comment per guideline.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-93) Change code header to follow standard
ASF source header
Posted by "Chris Burroughs (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13082659#comment-13082659 ]
Chris Burroughs commented on KAFKA-93:
--------------------------------------
Are all of the clients from LinkedIn? I thought some were from external pull requests.
> Change code header to follow standard ASF source header
> --------------------------------------------------------
>
> Key: KAFKA-93
> URL: https://issues.apache.org/jira/browse/KAFKA-93
> Project: Kafka
> Issue Type: Task
> Reporter: Henry Saputra
> Assignee: Henry Saputra
> Priority: Minor
> Fix For: 0.8
>
>
> Need to update Kafka code to include ASF standard source header: http://www.apache.org/legal/src-headers.html
> I think most Kafka code already have the ASF header. Just need to remove the copyrights section of the comment per guideline.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-93) Change code header to follow standard
ASF source header
Posted by "Henry Saputra (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13082517#comment-13082517 ]
Henry Saputra commented on KAFKA-93:
------------------------------------
Thanks Joel, apparently my update script somehow miss some scala files. I need to make sure it covers clients file too.
> Change code header to follow standard ASF source header
> --------------------------------------------------------
>
> Key: KAFKA-93
> URL: https://issues.apache.org/jira/browse/KAFKA-93
> Project: Kafka
> Issue Type: Task
> Reporter: Henry Saputra
> Assignee: Henry Saputra
> Priority: Minor
> Fix For: 0.8
>
>
> Need to update Kafka code to include ASF standard source header: http://www.apache.org/legal/src-headers.html
> I think most Kafka code already have the ASF header. Just need to remove the copyrights section of the comment per guideline.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira