You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/09/21 12:55:42 UTC

[GitHub] [calcite] vlsi commented on a change in pull request #2160: [CALCITE-4269] Improvement on enumerable implementation for HOP and SESSION

vlsi commented on a change in pull request #2160:
URL: https://github.com/apache/calcite/pull/2160#discussion_r492021503



##########
File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumUtils.java
##########
@@ -856,7 +856,7 @@ static Expression tumblingWindowSelector(
     private final int indexOfWatermarkedColumn;
     private final int indexOfKeyColumn;
     private final long gap;
-    private LinkedList<Object[]> list;
+    private final ArrayDeque<Object[]> list;

Review comment:
       `Deque` might be slightly better here




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org