[GitHub] [beam] y1chi commented on a change in pull request #17032: [BEAM-12447] Upgrade cloud build client and add/cleanup SdkContainerBuilder options

[GitBox <gi...@apache.org>]

y1chi commented on a change in pull request #17032:
URL: https://github.com/apache/beam/pull/17032#discussion_r822085170



##########
File path: sdks/python/apache_beam/runners/portability/sdk_container_builder.py
##########
@@ -338,3 +345,24 @@ def _get_gcs_bucket_and_name(gcs_location):
   def _make_tarfile(output_filename, source_dir):
     with tarfile.open(output_filename, "w:gz") as tar:
       tar.add(source_dir, arcname=SOURCE_FOLDER)
+
+  @staticmethod
+  def _get_cloud_build_machine_type_enum(machine_type: str):
+    if not machine_type:
+      return None
+    mappings = {
+        'n1-highcpu-8': cloudbuild.BuildOptions.MachineTypeValueValuesEnum.

Review comment:
       I believe the default is e1-medium https://cloud.google.com/build/pricing




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org