[GitHub] [daffodil-vscode] rthomas320 commented on a diff in pull request #580: Provides the ability to re-select values of attributes items

["rthomas320 (via GitHub)" <gi...@apache.org>]

rthomas320 commented on code in PR #580:
URL: https://github.com/apache/daffodil-vscode/pull/580#discussion_r1163942302


##########
src/language/providers/intellisense/attributeValueItems.ts:
##########
@@ -0,0 +1,294 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+// prettier-ignore

Review Comment:
   Initially the file started out as a copy of attributeItems.ts.  But the suggestions first offered a popup of the attribute name, once the attribute name was selected, then the choice values were given. I found that by using a 'switch" statement I was able to supply the attribute choices directly without the user having to select the attribute name first. When I made the change I forgot the prettier-ignore directive was in the file.  I removed it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org