You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/08/07 16:07:17 UTC
[GitHub] [dubbo-go] gaoxinge opened a new pull request #702: stack level
gaoxinge opened a new pull request #702:
URL: https://github.com/apache/dubbo-go/pull/702
<!-- Thanks for sending a pull request!
-->
**What this PR does**:
- change log stack level from warn to error
**Special notes for your reviewer**:
- None
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
NONE
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] fangyincheng commented on a change in pull request #702: stack level
Posted by GitBox <gi...@apache.org>.
fangyincheng commented on a change in pull request #702:
URL: https://github.com/apache/dubbo-go/pull/702#discussion_r467470041
##########
File path: go.mod
##########
@@ -67,3 +67,5 @@ require (
)
go 1.13
+
+replace launchpad.net/gocheck => github.com/go-check/check v0.0.0-20140225173054-eb6ee6f84d0a
Review comment:
replace？why？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks merged pull request #702: stack level
Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #702:
URL: https://github.com/apache/dubbo-go/pull/702
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] gaoxinge commented on a change in pull request #702: stack level
Posted by GitBox <gi...@apache.org>.
gaoxinge commented on a change in pull request #702:
URL: https://github.com/apache/dubbo-go/pull/702#discussion_r467543530
##########
File path: go.mod
##########
@@ -67,3 +67,5 @@ require (
)
go 1.13
+
+replace launchpad.net/gocheck => github.com/go-check/check v0.0.0-20140225173054-eb6ee6f84d0a
Review comment:
`replace` is used to fix https://github.com/apache/dubbo-go/issues/682#issuecomment-670842945.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org