You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@bookkeeper.apache.org by merlimat <gi...@git.apache.org> on 2017/06/01 21:07:28 UTC

[GitHub] bookkeeper pull request #179: BOOKKEEPER-1090: Use LOG.isDebugEnabled() to a...

GitHub user merlimat opened a pull request:

    https://github.com/apache/bookkeeper/pull/179

    BOOKKEEPER-1090: Use LOG.isDebugEnabled() to avoid unexpected allocations

    Using `LOG.debug(...)` can lead to multiple unexpected memory allocation, even when the logger it's turned off.
    For example, int and long parameter are boxed into Integer and Long objects and the var-arg parameters are using an `Object[]` to hold
    them.
    We should guard all usages of `LOG.debug()` with the `if (LOG.isDebugEnabled()` guard.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/merlimat/bookkeeper if-debug

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/bookkeeper/pull/179.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #179
    
----
commit 4e74b4c9693245c71e1ac58747b9f6e71005b430
Author: Matteo Merli <mm...@yahoo-inc.com>
Date:   2015-05-11T06:41:56Z

    BOOKKEEPER-1090: Use LOG.isDebugEnabled() to avoid unexpected allocations

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] bookkeeper issue #179: BOOKKEEPER-1090: Use LOG.isDebugEnabled() to avoid un...

Posted by jvrao <gi...@git.apache.org>.

Github user jvrao commented on the issue:

    https://github.com/apache/bookkeeper/pull/179
  
    can't we come up with a macro to wrap this? Chane looks fine to me though. +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] bookkeeper pull request #179: BOOKKEEPER-1090: Use LOG.isDebugEnabled() to a...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/bookkeeper/pull/179


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---