You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by ma...@apache.org on 2020/05/04 00:17:54 UTC

[trafficserver] branch master updated: Fix a bug that current_active_client_connections doesn't decrease

This is an automated email from the ASF dual-hosted git repository.

maskit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git


The following commit(s) were added to refs/heads/master by this push:
     new 81f750e  Fix a bug that current_active_client_connections doesn't decrease
81f750e is described below

commit 81f750ec3988f7a862ac5b66846530aa9f02d363
Author: Masakazu Kitajo <ma...@apache.org>
AuthorDate: Fri May 1 16:43:47 2020 +0900

    Fix a bug that current_active_client_connections doesn't decrease
    
    The metric was not decremented when a connection is closed by graceful
    shutdown (GOAWAY frame with stream ID 2^31-1).
---
 proxy/http2/Http2ConnectionState.cc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/proxy/http2/Http2ConnectionState.cc b/proxy/http2/Http2ConnectionState.cc
index 7ace5cb..3711e5c 100644
--- a/proxy/http2/Http2ConnectionState.cc
+++ b/proxy/http2/Http2ConnectionState.cc
@@ -1409,6 +1409,7 @@ Http2ConnectionState::release_stream()
         // or we can use a local variable to do it.
         // ua_session = nullptr;
       } else if (shutdown_state == HTTP2_SHUTDOWN_IN_PROGRESS && fini_event == nullptr) {
+        ua_session->clear_session_active();
         fini_event = this_ethread()->schedule_imm_local((Continuation *)this, HTTP2_SESSION_EVENT_FINI);
       } else if (ua_session->is_active()) {
         // If the number of clients is 0, HTTP2_SESSION_EVENT_FINI is not received or sent, and ua_session is active,