You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by se...@apache.org on 2012/09/20 18:02:24 UTC

svn commit: r1388090 - /commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/concurrent/TimedSemaphoreTest.java

Author: sebb
Date: Thu Sep 20 16:02:23 2012
New Revision: 1388090

URL: http://svn.apache.org/viewvc?rev=1388090&view=rev
Log:
Override of sync. method needs to be sync.

Modified:
    commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/concurrent/TimedSemaphoreTest.java

Modified: commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/concurrent/TimedSemaphoreTest.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/concurrent/TimedSemaphoreTest.java?rev=1388090&r1=1388089&r2=1388090&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/concurrent/TimedSemaphoreTest.java (original)
+++ commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/concurrent/TimedSemaphoreTest.java Thu Sep 20 16:02:23 2012
@@ -405,7 +405,7 @@ public class TimedSemaphoreTest {
          * Invokes the latch if one is set.
          */
         @Override
-        public void acquire() throws InterruptedException {
+        public synchronized void acquire() throws InterruptedException {
             super.acquire();
             if (latch != null) {
                 latch.countDown();
@@ -416,11 +416,9 @@ public class TimedSemaphoreTest {
          * Counts the number of invocations.
          */
         @Override
-        protected void endOfPeriod() {
+        protected synchronized void endOfPeriod() {
             super.endOfPeriod();
-            synchronized (this) {
-                periodEnds++;
-            }
+            periodEnds++;
         }
 
         /**