You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "lhotari (via GitHub)" <gi...@apache.org> on 2023/10/30 05:22:46 UTC
[PR] [fix][test] Fix resource leak when PulsarTestClient is closed or shutdown [pulsar]
lhotari opened a new pull request, #21468:
URL: https://github.com/apache/pulsar/pull/21468
### Motivation
PulsarTestClient used in tests leaks resources.
### Modifications
- close the resources when the client is closed or shutdown
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][test] Fix resource leak when PulsarTestClient is closed or shutdown [pulsar]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari merged PR #21468:
URL: https://github.com/apache/pulsar/pull/21468
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][test] Fix resource leak when PulsarTestClient is closed or shutdown [pulsar]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #21468:
URL: https://github.com/apache/pulsar/pull/21468#issuecomment-1784707483
## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/21468?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#21468](https://app.codecov.io/gh/apache/pulsar/pull/21468?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (ca67405) into [master](https://app.codecov.io/gh/apache/pulsar/commit/bd86e4e9d8dc2fe75ac8e29d628ffc5f7f9aab8c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (bd86e4e) will **decrease** coverage by `0.06%`.
> The diff coverage is `n/a`.
[](https://app.codecov.io/gh/apache/pulsar/pull/21468?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #21468 +/- ##
============================================
- Coverage 73.29% 73.24% -0.06%
- Complexity 32505 32594 +89
============================================
Files 1890 1890
Lines 140381 140381
Branches 15425 15425
============================================
- Hits 102898 102823 -75
- Misses 29405 29468 +63
- Partials 8078 8090 +12
```
| [Flag](https://app.codecov.io/gh/apache/pulsar/pull/21468/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [inttests](https://app.codecov.io/gh/apache/pulsar/pull/21468/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `24.23% <ø> (+0.13%)` | :arrow_up: |
| [systests](https://app.codecov.io/gh/apache/pulsar/pull/21468/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `24.74% <ø> (-0.20%)` | :arrow_down: |
| [unittests](https://app.codecov.io/gh/apache/pulsar/pull/21468/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `72.52% <ø> (-0.05%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 83 files with indirect coverage changes](https://app.codecov.io/gh/apache/pulsar/pull/21468/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org