You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/10/13 17:46:23 UTC

[GitHub] [maven] kwin commented on pull request #827: Allow a Maven plugin to require a Java version

kwin commented on PR #827:
URL: https://github.com/apache/maven/pull/827#issuecomment-1277966331

   @slawekjaranowski Thanks for the proposal, sounds good, but I am not sure when to call the validator. From both places where `MavenPluginManager#checkRequiredMavenVersion` is currently called? That may IMHO be too often and it seems that the `DefaultPluginVersionResolver#isCompatible(...)` is just silently ignoring incompatible versions. Also version incompatibility for me is semantically different from an invalid plugin descriptor. Therefore I am not sure about the naming `PluginDescriptorValidator`. The other validators primarily check for valid XML, which is different from compatibility.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org