You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Stepan Mishura (JIRA)" <ji...@apache.org> on 2006/08/04 12:30:15 UTC

[jira] Resolved: (HARMONY-975) [classlib][beans] fixes for DefaultPersistenceDelegateTest failures (1)

     [ http://issues.apache.org/jira/browse/HARMONY-975?page=all ]

Stepan Mishura resolved HARMONY-975.
------------------------------------

    Resolution: Fixed

Thanks Alexei - the patch was applied to BEANS module at r428686.

Please check that the patch was applied as you expected.

> [classlib][beans] fixes for DefaultPersistenceDelegateTest failures (1)
> -----------------------------------------------------------------------
>
>                 Key: HARMONY-975
>                 URL: http://issues.apache.org/jira/browse/HARMONY-975
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>         Environment: winXP
>            Reporter: Alexei Zakharov
>         Assigned To: Stepan Mishura
>         Attachments: DefailtPersistenceDelegateTest.patch, DefailtPersistenceDelegateTest2.patch
>
>
> Currently 19 tests from org.apache.harmony.beans.tests.java.beans.DefaultPersistenceDelegateTest class fail due various reasons. The attached patch corrects some of these failures. Please see the list of affected tests below.
> testInstantiate_NullProperty
> testInstantiate_EmptyProperty
> testInstantiate_NonExistingGetterNullEncoder
> Invalid tests indeed. Fail if NullPointerException isn't thrown. Neither RI nor our implementation throws such exception here. Corrected. 
> testInstantiate_NonExistingGetter
> testInstantiate_NoGetter
> Are also invalid tests. They test the behavior that is specific to some third-party implementation of beans (not RI). I corrected the sophisticated but invalid exception handling I've found in these tests. Now it reflects the RI behavior. Please note that using of singleton class CallVerificationStack is thread unsafe here. I have replaced CallVerificationStack with locally defined variable.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira