You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2023/02/03 07:39:37 UTC
[GitHub] [arrow] kou opened a new pull request, #34019: GH-33882: [C++] Don't find .pc files with ARROW_BUILD_STATIC=OFF
kou opened a new pull request, #34019:
URL: https://github.com/apache/arrow/pull/34019
### Rationale for this change
Because they are needless and `pkg-config grpc++` is slow.
### What changes are included in this PR?
Don't find .pc files with `ARROW_BUILD_STATIC=OFF`.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou merged pull request #34019: GH-33882: [C++] Don't find .pc files with ARROW_BUILD_STATIC=OFF
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #34019:
URL: https://github.com/apache/arrow/pull/34019
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34019: GH-33882: [C++] Don't find .pc files with ARROW_BUILD_STATIC=OFF
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34019:
URL: https://github.com/apache/arrow/pull/34019#issuecomment-1415241636
:warning: GitHub issue #33882 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #34019: GH-33882: [C++] Don't find .pc files with ARROW_BUILD_STATIC=OFF
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #34019:
URL: https://github.com/apache/arrow/pull/34019#issuecomment-1415242532
@h-vetinari Could you try this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #34019: GH-33882: [C++] Don't find .pc files with ARROW_BUILD_STATIC=OFF
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #34019:
URL: https://github.com/apache/arrow/pull/34019#issuecomment-1416834526
Benchmark runs are scheduled for baseline = e39749d17340bf1f2becf3a483ee1c755c11a13a and contender = ecb1f2e31d73b0ccc7b324d5e25eb015f6524bc6. ecb1f2e31d73b0ccc7b324d5e25eb015f6524bc6 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/e5f41bb19bde4fae97d30d7ea7e0663f...5df1d3d29e4c475496b10d5ab78537f5/)
[Failed :arrow_down:0.34% :arrow_up:0.06%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/67078d90fe3b462ba146eea0c5ce3c93...5568cda0011546baa698871638287a55/)
[Finished :arrow_down:0.77% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/82471a5e563a4a6faf821ee0ae2cfb3f...560dd0e7f2f241af92d1fa83c7ce9e1f/)
[Finished :arrow_down:0.19% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/63339044a9754d7b8a320f74246d0a86...0966424ff0fd4c1bada84ee8c5bc5c21/)
Buildkite builds:
[Finished] [`ecb1f2e3` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2326)
[Failed] [`ecb1f2e3` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2354)
[Finished] [`ecb1f2e3` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2324)
[Finished] [`ecb1f2e3` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2345)
[Finished] [`e39749d1` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2325)
[Failed] [`e39749d1` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2353)
[Finished] [`e39749d1` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2323)
[Finished] [`e39749d1` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2344)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #34019: GH-33882: [C++] Don't find .pc files with ARROW_BUILD_STATIC=OFF
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #34019:
URL: https://github.com/apache/arrow/pull/34019#issuecomment-1416834576
['Python', 'R'] benchmarks have high level of regressions.
[ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/82471a5e563a4a6faf821ee0ae2cfb3f...560dd0e7f2f241af92d1fa83c7ce9e1f/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34019: GH-33882: [C++] Don't find .pc files with ARROW_BUILD_STATIC=OFF
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34019:
URL: https://github.com/apache/arrow/pull/34019#issuecomment-1415241570
* Closes: #33882
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #34019: GH-33882: [C++] Don't find .pc files with ARROW_BUILD_STATIC=OFF
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #34019:
URL: https://github.com/apache/arrow/pull/34019#issuecomment-1416747388
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org