You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2020/12/02 20:18:45 UTC
[kudu-CR] mini-cluster: add a tserver admin proxy
Hello Alexey Serbin, Hao Hao,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/16813
to review the following change.
Change subject: mini-cluster: add a tserver admin proxy
......................................................................
mini-cluster: add a tserver admin proxy
It can be more convenient to use cluster APIs rather than creating the
proxy via constructor.
Change-Id: Ie230ec40165ad5eea6b0ca19141707389b6175d0
---
M src/kudu/integration-tests/ts_tablet_manager-itest.cc
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/mini-cluster/external_mini_cluster.h
M src/kudu/mini-cluster/internal_mini_cluster.cc
M src/kudu/mini-cluster/internal_mini_cluster.h
M src/kudu/mini-cluster/mini_cluster.h
6 files changed, 30 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/13/16813/1
--
To view, visit http://gerrit.cloudera.org:8080/16813
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie230ec40165ad5eea6b0ca19141707389b6175d0
Gerrit-Change-Number: 16813
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
[kudu-CR] mini-cluster: add a tserver admin proxy
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16813 )
Change subject: mini-cluster: add a tserver admin proxy
......................................................................
mini-cluster: add a tserver admin proxy
It can be more convenient to use cluster APIs rather than creating the
proxy via constructor.
Change-Id: Ie230ec40165ad5eea6b0ca19141707389b6175d0
Reviewed-on: http://gerrit.cloudera.org:8080/16813
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/integration-tests/ts_tablet_manager-itest.cc
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/mini-cluster/external_mini_cluster.h
M src/kudu/mini-cluster/internal_mini_cluster.cc
M src/kudu/mini-cluster/internal_mini_cluster.h
M src/kudu/mini-cluster/mini_cluster.h
6 files changed, 33 insertions(+), 7 deletions(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/16813
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie230ec40165ad5eea6b0ca19141707389b6175d0
Gerrit-Change-Number: 16813
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] mini-cluster: add a tserver admin proxy
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Hao Hao,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16813
to look at the new patch set (#2).
Change subject: mini-cluster: add a tserver admin proxy
......................................................................
mini-cluster: add a tserver admin proxy
It can be more convenient to use cluster APIs rather than creating the
proxy via constructor.
Change-Id: Ie230ec40165ad5eea6b0ca19141707389b6175d0
---
M src/kudu/integration-tests/ts_tablet_manager-itest.cc
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/mini-cluster/external_mini_cluster.h
M src/kudu/mini-cluster/internal_mini_cluster.cc
M src/kudu/mini-cluster/internal_mini_cluster.h
M src/kudu/mini-cluster/mini_cluster.h
6 files changed, 33 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/13/16813/2
--
To view, visit http://gerrit.cloudera.org:8080/16813
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie230ec40165ad5eea6b0ca19141707389b6175d0
Gerrit-Change-Number: 16813
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] mini-cluster: add a tserver admin proxy
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16813 )
Change subject: mini-cluster: add a tserver admin proxy
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16813
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie230ec40165ad5eea6b0ca19141707389b6175d0
Gerrit-Change-Number: 16813
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 03 Dec 2020 06:02:40 +0000
Gerrit-HasComments: No