You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/03/11 17:05:14 UTC

[GitHub] [camel-website] aashnajena opened a new pull request #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu

aashnajena opened a new pull request #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu
URL: https://github.com/apache/camel-website/pull/195
 
 
   1. To improve website usability, I removed the sub-menus under the Project tab and made a landing page for Projects which gives a 3-4 sentence description of each project (Camel-K, Camel Quarkus etc), and gives links to respective documentation or manuals.
   
   2. Re-organised the content to do away with pages having very little information on them like :
    - [Camel K page](https://camel.apache.org/projects/camel-k/)
    - [Camel Quarkus Page](https://camel.apache.org/projects/camel-quarkus/)
    - [Camel Kafka Connector page](https://camel.apache.org/projects/camel-kafka-connector/)
   
   3. I merged these into one page, and added a short description for the Spring Boot Project with links to its manual (earlier the sub-menu lead directly to the manual)
   
   ![camel-projects](https://user-images.githubusercontent.com/32356795/76443497-7a154c00-63e8-11ea-9615-18094663c15a.png)
   ![camel-projects-2](https://user-images.githubusercontent.com/32356795/76443503-7bdf0f80-63e8-11ea-8181-42446e4d7e61.png)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] aashnajena commented on a change in pull request #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu

Posted by GitBox <gi...@apache.org>.
aashnajena commented on a change in pull request #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu
URL: https://github.com/apache/camel-website/pull/195#discussion_r398489102
 
 

 ##########
 File path: layouts/projects/projects.html
 ##########
 @@ -0,0 +1,14 @@
+{{ partial "header.html" . }}
 
 Review comment:
   By default, this page uses `layouts/_default/section.html` and this is how it's rendered : 
   ![section](https://user-images.githubusercontent.com/32356795/77640608-b3b98b80-6f80-11ea-95cb-b44984cc6656.png)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] aashnajena commented on issue #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu

Posted by GitBox <gi...@apache.org>.
aashnajena commented on issue #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu
URL: https://github.com/apache/camel-website/pull/195#issuecomment-598712178
 
 
   Hey, when I build the website locally, I'm able to redirect from /projects/index.html to other pages. I added _index.html to the same folder where other project files (camel-k.md etc) were placed before, so relative paths to other files shouldn't change... 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] aashnajena commented on issue #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu

Posted by GitBox <gi...@apache.org>.
aashnajena commented on issue #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu
URL: https://github.com/apache/camel-website/pull/195#issuecomment-603691697
 
 
   Hey, I've been looking at [this](http://httpd.apache.org/docs/2.2/rewrite/flags.html#flag_ne) to understand how to redirect anchors, but this doesn't seem to work in our case.
   ![camel-htaccess](https://user-images.githubusercontent.com/32356795/77513593-4c75db80-6e9b-11ea-9169-c0ce21949072.png)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] zregvart commented on a change in pull request #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu

Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu
URL: https://github.com/apache/camel-website/pull/195#discussion_r397097451
 
 

 ##########
 File path: antora-ui-camel/src/css/frontpage.css
 ##########
 @@ -59,19 +59,15 @@ header.frontpage a:active {
   outline: none;
 
 Review comment:
   Are changes to this file intentional?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] aashnajena commented on a change in pull request #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu

Posted by GitBox <gi...@apache.org>.
aashnajena commented on a change in pull request #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu
URL: https://github.com/apache/camel-website/pull/195#discussion_r398494916
 
 

 ##########
 File path: layouts/projects/projects.html
 ##########
 @@ -0,0 +1,14 @@
+{{ partial "header.html" . }}
 
 Review comment:
   This way, I'll be able to use section.html for the other PR about documentations menu as well.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] zregvart commented on a change in pull request #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu

Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu
URL: https://github.com/apache/camel-website/pull/195#discussion_r397100660
 
 

 ##########
 File path: package.json
 ##########
 @@ -2,21 +2,21 @@
   "version": "1.0.0-SNAPSHOT",
 
 Review comment:
   I don't think changes to this file were intentional

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] zregvart commented on a change in pull request #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu

Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu
URL: https://github.com/apache/camel-website/pull/195#discussion_r397100096
 
 

 ##########
 File path: layouts/partials/header.html
 ##########
 @@ -33,7 +33,7 @@
     <header class="header">
         <nav class="navbar">
             <div class="navbar-brand">
-                <a class="nav-logo" href="{{ .Site.BaseURL | relURL }}" title="{{ .Site.Title }}"></a>
+                <a class="nav-logo" href="{{ .Site.BaseURL | relURL }}" title="{{ .Site.Title }}"><span>{{ .Site.Title }}</span></a>
 
 Review comment:
   I don't think this change was intentional

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] zregvart commented on a change in pull request #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu

Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu
URL: https://github.com/apache/camel-website/pull/195#discussion_r397098519
 
 

 ##########
 File path: antora-ui-camel/src/partials/header-content.hbs
 ##########
 @@ -1,22 +1,30 @@
 <header class="header">
   <nav class="navbar">
     <div class="navbar-brand">
-      <a class="nav-logo" href="{{siteRootPath}}"></a>
+      <a class="nav-logo" href="{{siteRootPath}}"><span>{{site.title}}</span></a>
 
 Review comment:
   This reverts the change from #199, I don't think that was intentional

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] aashnajena commented on issue #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu

Posted by GitBox <gi...@apache.org>.
aashnajena commented on issue #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu
URL: https://github.com/apache/camel-website/pull/195#issuecomment-604381475
 
 
   Pushed the changes :) Thanks!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] zregvart commented on a change in pull request #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu

Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu
URL: https://github.com/apache/camel-website/pull/195#discussion_r398504528
 
 

 ##########
 File path: layouts/projects/projects.html
 ##########
 @@ -0,0 +1,14 @@
+{{ partial "header.html" . }}
 
 Review comment:
   Good call!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] zregvart commented on issue #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu

Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu
URL: https://github.com/apache/camel-website/pull/195#issuecomment-598716899
 
 
   @aashnajena I've added a suggestion that I hope helps clear things up. Remember that you can run checks locally via `yarn checks`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] aashnajena commented on issue #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu

Posted by GitBox <gi...@apache.org>.
aashnajena commented on issue #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu
URL: https://github.com/apache/camel-website/pull/195#issuecomment-603224990
 
 
   Right now, I pulled changes from upstream on my master, and I tried to rebase my project_menu branch with master. It says that "Current branch project_menu is up to date", but I still can't see the missing files. How can I merge these changes?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] zregvart commented on a change in pull request #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu

Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu
URL: https://github.com/apache/camel-website/pull/195#discussion_r397099700
 
 

 ##########
 File path: content/community/articles.md
 ##########
 @@ -238,7 +238,7 @@ These examples show Camel combined with several tools (e.g. IDE), ESBs, Applicat
 *   [Apache Camel and Scala](http://www.kai-waehner.de/blog/2011/06/23/apache-camel-and-scala-a-powerful-combination/): A powerful Combination _by Kai Wähner_
 *   [A little Scala DSL example](http://davsclaus.blogspot.com/2011/12/apache-camel-little-scala-dsl-example.html) - A little blog post showing how to use the Camel Scala DSL levering Scala functions directly in the DSL.
 *   [Apache Camel’s Scala DSL explored](https://www.avisi.nl/blog/2013/01/07/apache-camels-scala-dsl-explored) - A blog post using Camel and Scala to build a powerful solution to decouple systems. Using HTTP, JSon and Scala case classes in a nice way.
-*   [Using Apache Camel with Scala and the Camel Scala DSL](http://www.hascode.com/2013/02/using-apache-camel-with-scala-and-the-camel-scala-dsl/) - A tutorial from Feb 2013 on using Camel and Scala DSL with a number of examples using the [EIP](../../components/latest/eips/enterprise-integration-patterns.html)s and Camel [Components](../../manual/latest/component.html), and with source code.
+*   [Using Apache Camel with Scala and the Camel Scala DSL](http://www.hascode.com/2013/02/using-apache-camel-with-scala-and-the-camel-scala-dsl/) - A tutorial from Feb 2013 on using Camel and Scala DSL with a number of examples using the [EIP](../../manual/latest/enterprise-integration-patterns.html)s and Camel [Components](../../manual/latest/component.html), and with source code.
 
 Review comment:
   I don't think this change was intentional

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] zregvart commented on a change in pull request #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu

Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu
URL: https://github.com/apache/camel-website/pull/195#discussion_r397097590
 
 

 ##########
 File path: antora-ui-camel/src/css/header.css
 ##########
 @@ -126,12 +126,18 @@ body {
   color: var(--navbar-menu-font-color);
 
 Review comment:
   Are changes to this file intentional?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] zregvart commented on issue #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu

Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu
URL: https://github.com/apache/camel-website/pull/195#issuecomment-602570726
 
 
   I need to test those `Redirect` rules, not sure if `#` will be interpreted as a comment. @aashnajena can you please squash these commits into single one?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] aashnajena commented on a change in pull request #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu

Posted by GitBox <gi...@apache.org>.
aashnajena commented on a change in pull request #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu
URL: https://github.com/apache/camel-website/pull/195#discussion_r398494222
 
 

 ##########
 File path: layouts/projects/projects.html
 ##########
 @@ -0,0 +1,14 @@
+{{ partial "header.html" . }}
 
 Review comment:
   I don't think _default/section.html template is being used anywhere. Can I change the section.html file to look like my projects.html file? That works, I tried, and the template is very basic - so I don't think it should hurt. The current section.html template is pretty redundant.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] aashnajena commented on issue #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu

Posted by GitBox <gi...@apache.org>.
aashnajena commented on issue #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu
URL: https://github.com/apache/camel-website/pull/195#issuecomment-599227130
 
 
   I looked through the failed checks, I don't think they are due to my commits! Please check once 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] zregvart merged pull request #195: CAMEL 14581: Re-organizing sub-menus under "Projects" tab on th…

Posted by GitBox <gi...@apache.org>.
zregvart merged pull request #195: CAMEL 14581: Re-organizing sub-menus under "Projects" tab on th…
URL: https://github.com/apache/camel-website/pull/195
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] zregvart commented on a change in pull request #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu

Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu
URL: https://github.com/apache/camel-website/pull/195#discussion_r397098115
 
 

 ##########
 File path: antora-ui-camel/src/css/nav.css
 ##########
 @@ -294,3 +294,14 @@ html.is-clipped--nav {
   background-position-y: 10px;
 
 Review comment:
   This reverts the change in #199, I don't think it's intentional

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] aashnajena commented on issue #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu

Posted by GitBox <gi...@apache.org>.
aashnajena commented on issue #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu
URL: https://github.com/apache/camel-website/pull/195#issuecomment-602604064
 
 
   Pulled latest changes and squashed commits

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] zregvart commented on a change in pull request #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu

Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu
URL: https://github.com/apache/camel-website/pull/195#discussion_r397098299
 
 

 ##########
 File path: antora-ui-camel/src/helpers/withMenuData.js
 ##########
 @@ -1,39 +0,0 @@
-'use strict'
 
 Review comment:
   I'm pretty sure we need this file

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] aashnajena commented on a change in pull request #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu

Posted by GitBox <gi...@apache.org>.
aashnajena commented on a change in pull request #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu
URL: https://github.com/apache/camel-website/pull/195#discussion_r398489102
 
 

 ##########
 File path: layouts/projects/projects.html
 ##########
 @@ -0,0 +1,14 @@
+{{ partial "header.html" . }}
 
 Review comment:
   I don't understand how to specify that a particular file should use _default/single.html as its template. I want to use single.html, not section.html, this is how it's rendered : 
   ![section](https://user-images.githubusercontent.com/32356795/77640608-b3b98b80-6f80-11ea-95cb-b44984cc6656.png)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] zregvart commented on a change in pull request #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu

Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu
URL: https://github.com/apache/camel-website/pull/195#discussion_r397100395
 
 

 ##########
 File path: menu.js
 ##########
 @@ -0,0 +1,36 @@
+const fs = require('fs');
 
 Review comment:
   I think this file was removed and refactored under antora-camel-ui, I don't think this change was intentional

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] aashnajena commented on issue #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu

Posted by GitBox <gi...@apache.org>.
aashnajena commented on issue #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu
URL: https://github.com/apache/camel-website/pull/195#issuecomment-598657103
 
 
   Noted! I'm travelling right now, I'll make sure I make necessary changes by tonight. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] zregvart commented on a change in pull request #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu

Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu
URL: https://github.com/apache/camel-website/pull/195#discussion_r398479867
 
 

 ##########
 File path: layouts/projects/projects.html
 ##########
 @@ -0,0 +1,14 @@
+{{ partial "header.html" . }}
 
 Review comment:
   If you have time to work on this, I'd like for us to try to use default layout here instead of adding a new one. I think it should be possible. Otherwise we can do it in a followup pull request.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] zregvart commented on issue #195: CAMEL 14581: Re-organizing sub-menus under "Projects" tab on th…

Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #195: CAMEL 14581: Re-organizing sub-menus under "Projects" tab on th…
URL: https://github.com/apache/camel-website/pull/195#issuecomment-604491057
 
 
   Thanks!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] zregvart commented on a change in pull request #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu

Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu
URL: https://github.com/apache/camel-website/pull/195#discussion_r397099215
 
 

 ##########
 File path: content/_index.md
 ##########
 @@ -48,7 +48,7 @@ Camel supports around 50 data formats, allowing to <mark>translate messages</mar
 **Apache Camel** is the *Swiss knife* of integration. 
 
 <a class="significant" href="./manual/latest/">Read the docs</a>
-<a class="significant" href="./components/latest/eips/enterprise-integration-patterns.html">EIP reference</a>
+<a class="significant" href="./manual/latest/enterprise-integration-patterns.html">EIP reference</a>
 
 Review comment:
   I don't think this change was intentional

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] aashnajena commented on issue #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu

Posted by GitBox <gi...@apache.org>.
aashnajena commented on issue #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu
URL: https://github.com/apache/camel-website/pull/195#issuecomment-602594469
 
 
   I don't think the redirects work. In GSoC-2020-announced blog, I changed the entries of /projects/camel-k/ to /projects/#apache-camel-k. This works, but if I keep the original one, it isn't getting redirected. I'll squash the commits for you to check anyway

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] aashnajena edited a comment on issue #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu

Posted by GitBox <gi...@apache.org>.
aashnajena edited a comment on issue #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu
URL: https://github.com/apache/camel-website/pull/195#issuecomment-602594469
 
 
   I don't think the redirects work. In GSoC-2020-announced blog, I changed the entries of /projects/camel-k/ to /projects/#apache-camel-k. This works, but if I keep the original one, it isn't getting redirected. I'll squash the commits for you to check anyway
   
   Although, I did fix all the links that would have been broken due to the changes made.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] zregvart commented on issue #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu

Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu
URL: https://github.com/apache/camel-website/pull/195#issuecomment-604360393
 
 
   @aashnajena the redirects are only used when the website is deployed to the Apache HTTP server, that file is not consulted when running via `yarn preview` as Hugo is acting as a web server in that case.
   This is the case also when we access the preview on our build server.
   I think the ones you have added in `.htaccess` should work. I don't think we need to escape the `#` character. But I'll test locally just to make sure. The way I test is a bit involved, I run the Apache HTTP server in a Linux container.
   
   One thing I'd like you to try is to see if we can use the default layout in this case. I think `layouts/_default/section.html` should apply here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] zregvart commented on a change in pull request #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu

Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu
URL: https://github.com/apache/camel-website/pull/195#discussion_r397099082
 
 

 ##########
 File path: config.toml
 ##########
 @@ -111,7 +84,7 @@ timeout = 300000
     parent = "docs"
     weight = 8
     identifier = "eip"
-    url = "/components/latest/eips/enterprise-integration-patterns.html"
+    url = "/manual/latest/enterprise-integration-patterns.html"
 
 Review comment:
   I think, this should be:
   ```suggestion
       url = "/documentation.html"
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] zregvart commented on a change in pull request #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu

Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu
URL: https://github.com/apache/camel-website/pull/195#discussion_r397100006
 
 

 ##########
 File path: content/community/user-stories.md
 ##########
 @@ -7,7 +7,7 @@ This page is intended as a place to collect user stories and feedback on Apache
 {{< table >}}
 | Company, Product, or Project  | Description |
 |-------------------------------|-------------|
-|[Apache ActiveMQ](http://activemq.apache.org)|Uses Camel to add [Enterprise Integration Patterns](../../components/latest/eips/enterprise-integration-patterns.html) support into the [ActiveMQ broker](http://activemq.apache.org/enterprise-integration-patterns.html). If you run an out of the box ActiveMQ broker, look in *conf/camel.xml* and you'll see *camelContext* with some example routing rules. Can be used to bridge ActiveMQ with any of the camel [Components](../../manual/latest/component.html).|
+|[Apache ActiveMQ](http://activemq.apache.org)|Uses Camel to add [Enterprise Integration Patterns](../../manual/latest/enterprise-integration-patterns.html) support into the [ActiveMQ broker](http://activemq.apache.org/enterprise-integration-patterns.html). If you run an out of the box ActiveMQ broker, look in *conf/camel.xml* and you'll see *camelContext* with some example routing rules. Can be used to bridge ActiveMQ with any of the camel [Components](../../manual/latest/component.html).|
 
 Review comment:
   I don't think this change was intentional

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] aashnajena commented on issue #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu

Posted by GitBox <gi...@apache.org>.
aashnajena commented on issue #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu
URL: https://github.com/apache/camel-website/pull/195#issuecomment-599220478
 
 
   Done! 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] aashnajena commented on issue #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu

Posted by GitBox <gi...@apache.org>.
aashnajena commented on issue #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu
URL: https://github.com/apache/camel-website/pull/195#issuecomment-603242088
 
 
   I understood my mistake, I have reverted all the unnecessary changes. Sorry for the confusion!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] zregvart commented on a change in pull request #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu

Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu
URL: https://github.com/apache/camel-website/pull/195#discussion_r397098769
 
 

 ##########
 File path: antora-ui-camel/src/partials/header-content.hbs
 ##########
 @@ -1,22 +1,30 @@
 <header class="header">
   <nav class="navbar">
     <div class="navbar-brand">
-      <a class="nav-logo" href="{{siteRootPath}}"></a>
+      <a class="nav-logo" href="{{siteRootPath}}"><span>{{site.title}}</span></a>
       <div id="topbar-nav" class="navbar-menu">
         <div class="navbar-end">
           {{#withMenuData}}
             {{#each @items}}
                 {{#if children}}
                 <div class="navbar-item has-dropdown is-hoverable">
                 <a class="navbar-link navbar-topics" href="#">{{name}}</a>
+                {{else}}
+                <a class="navbar-item navbar-topics" href="{{../../siteRootPath}}{{url}}">{{name}}</a>
+                {{/if}}
+                {{#if children}}
                 <div class="navbar-dropdown">
                 {{#each children}}
+                  {{#hasPrefix url }}
                   <a class="navbar-item" href="{{url}}">{{name}}</a>
+                  {{else}}
+                  <a class="navbar-item" href="{{../../../siteRootPath}}{{url}}">{{name}}</a>
+                  {{/hasPrefix}}
                 {{/each}}
                 </div>
+                {{/if}}
+                {{#if children}}
                 </div>
-                {{else}}
-                <a class="navbar-item navbar-topics" href="{{url}}">{{name}}</a>
 
 Review comment:
   I don't think this was intentional

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] transcendence09 commented on issue #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu

Posted by GitBox <gi...@apache.org>.
transcendence09 commented on issue #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu
URL: https://github.com/apache/camel-website/pull/195#issuecomment-598066519
 
 
   @zregvart Please where can i find a task to do that isn't being worked on by somone, do i collaborate with someone on a common task??..I would like to get started ASAP. Thank you

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] aashnajena commented on a change in pull request #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu

Posted by GitBox <gi...@apache.org>.
aashnajena commented on a change in pull request #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu
URL: https://github.com/apache/camel-website/pull/195#discussion_r398494222
 
 

 ##########
 File path: layouts/projects/projects.html
 ##########
 @@ -0,0 +1,14 @@
+{{ partial "header.html" . }}
 
 Review comment:
   I don't think `_default/section.html` template is being used anywhere. Can I change the section.html file as shown below? That works, I tried, and the template is very basic - so I don't think it should hurt. The current section.html template is pretty redundant.
   
   I want to change section.html from
   ```
   {{ partial "header.html" . }}
           {{ .Content }}
   {{ partial "footer.html" . }}
   
   ```
   TO : 
   ```
   {{ partial "header.html" . }}
       <article class="static doc">
           <h1>{{ .Title }} </h1>
           {{ .Content }}
       </article>
   {{ partial "footer.html" . }}
   ```
   
   This will also help in the other PR about documentations menu

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] aashnajena commented on a change in pull request #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu

Posted by GitBox <gi...@apache.org>.
aashnajena commented on a change in pull request #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu
URL: https://github.com/apache/camel-website/pull/195#discussion_r398494222
 
 

 ##########
 File path: layouts/projects/projects.html
 ##########
 @@ -0,0 +1,14 @@
+{{ partial "header.html" . }}
 
 Review comment:
   I don't think `_default/section.html` template is being used anywhere. Can I change the section.html file as shown below? That works, I tried, and the template is very basic - so I don't think it should hurt. The current section.html template is pretty redundant.
   
   I want to change section.html from
   ```
   {{ partial "header.html" . }}
           {{ .Content }}
   {{ partial "footer.html" . }}
   
   ```
   TO : 
   ```
   {{ partial "header.html" . }}
       <article class="static doc">
           <h1>{{ .Title }} </h1>
           {{ .Content }}
       </article>
   {{ partial "footer.html" . }}
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] zregvart commented on issue #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu

Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu
URL: https://github.com/apache/camel-website/pull/195#issuecomment-597786957
 
 
   Thanks! I like this, it's simpler and frees the "Projects" menu from sub-menus, an approach we could take for other navigation links on top.
   
   We run a link checker, and these issues were reported:
   
   ```
   [2020-03-11T17:19:33.532Z] page not found from blog/GSoC-2020-announced/index.html to projects/camel-k/index.html
   [2020-03-11T17:19:33.532Z] page not found from blog/GSoC-2020-announced/index.html to projects/camel-quarkus/index.html
   [2020-03-11T17:19:33.532Z] page not found from blog/GSoC-2020-announced/index.html to projects/camel-kafka-connector/index.html
   [2020-03-11T17:19:33.532Z] page not found from projects/index.html to ../camel-k/latest/index.html
   [2020-03-11T17:19:33.532Z] page not found from projects/index.html to ../community/mailing-list/index.html
   [2020-03-11T17:19:33.532Z] page not found from projects/index.html to ../components/latest/index.html
   [2020-03-11T17:19:33.532Z] page not found from projects/index.html to ../camel-kafka-connector/latest/index.html
   [2020-03-11T17:19:33.532Z] page not found from projects/index.html to ../camel-quarkus/latest/index.html
   ```
   
   If I recall correctly, we have Hugo configured so that in the generated content you can use absolute links, i.e. starting from `/` and they will be converted to relative links.
   
   Since this changes some of the URLs we usually also configure redirection, for example:
   
   https://github.com/apache/camel-website/blob/666bd34ea046eb5cd4b7b51001b5142382bb9239/static/.htaccess#L1051
   
   I think it would be good to redirect from `/projects/camel-k/` to this unified `/projects/#Apache Camel K` (not sure about the anchor there).
   
   Also can you incorporate the changes from #188. You might need to rebase and move the changes manually.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] aashnajena commented on a change in pull request #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu

Posted by GitBox <gi...@apache.org>.
aashnajena commented on a change in pull request #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu
URL: https://github.com/apache/camel-website/pull/195#discussion_r398494916
 
 

 ##########
 File path: layouts/projects/projects.html
 ##########
 @@ -0,0 +1,14 @@
+{{ partial "header.html" . }}
 
 Review comment:
   This way, I'll be able to use section.html for the other PR about documentations menu as well.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] aashnajena commented on a change in pull request #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu

Posted by GitBox <gi...@apache.org>.
aashnajena commented on a change in pull request #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu
URL: https://github.com/apache/camel-website/pull/195#discussion_r398489102
 
 

 ##########
 File path: layouts/projects/projects.html
 ##########
 @@ -0,0 +1,14 @@
+{{ partial "header.html" . }}
 
 Review comment:
   I don't understand how to specify that a particular file should use _default/single.html as its template

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] zregvart commented on a change in pull request #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu

Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu
URL: https://github.com/apache/camel-website/pull/195#discussion_r392222724
 
 

 ##########
 File path: content/projects/_index.md
 ##########
 @@ -0,0 +1,33 @@
+---
+title: Apache Camel Projects
+---
+
+## Apache Camel K
+
+Apache Camel K is a lightweight integration framework built from Apache Camel that runs natively on Kubernetes and is specifically designed for serverless and microservice architectures. Users of Camel K can instantly run integration code written in Camel DSL on their preferred cloud (Kubernetes or OpenShift).
+
+For more information checkout the [Camel K manual](../../camel-k/latest/) and join the community on on the [Camel Users mailing list](../../community/mailing-list/) and have a look at the [Camel K GitHub repository](https://github.com/apache/camel-k/).
 
 Review comment:
   We have turned on relative URLs in Hugo configuration here:
   
   https://github.com/apache/camel-website/blob/21dbd4d74b5f0270a697e8de300eeff30dca14dd/config.toml#L4
   
   That means that we can use absolute URLs in markdown, and they should be converted to relative URLs when rendered to HTML.
   
   These links point to `../../` which for `/projects` where this `_index.md` is rendered to, would end up resolving to `/projects/../../`, which would be outside of the root.
   
   ```suggestion
   For more information checkout the [Camel K manual](/camel-k/latest/) and join the community on on the [Camel Users mailing list](/community/mailing-list/) and have a look at the [Camel K GitHub repository](https://github.com/apache/camel-k/).
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] aashnajena commented on issue #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu

Posted by GitBox <gi...@apache.org>.
aashnajena commented on issue #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu
URL: https://github.com/apache/camel-website/pull/195#issuecomment-598779599
 
 
   Hey, please review the changes now. Changes in #188 reflect on /camel-k/latest page, and the page I have created has a link to it. Ran yarn checks, everything seems good now!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services