[GitHub] [spark] cloud-fan commented on a change in pull request #31679: [SPARK-34567][SQL] CreateTableAsSelect should update metrics too

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #31679:
URL: https://github.com/apache/spark/pull/31679#discussion_r587240944



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/DataWritingCommand.scala
##########
@@ -73,4 +74,14 @@ object DataWritingCommand {
       attr.withName(outputName)
     }
   }
+
+  def updateMetrics(

Review comment:
       `propogateMetrics` is probably more accurate.

##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/DataWritingCommand.scala
##########
@@ -73,4 +74,14 @@ object DataWritingCommand {
       attr.withName(outputName)
     }
   }
+
+  def updateMetrics(

Review comment:
       and let's add a comment to explain when this should be called.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org