You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by br...@apache.org on 2013/07/11 18:06:53 UTC
svn commit: r1502262 - in /subversion/trunk/subversion/bindings/cxxhl/src:
aprwrap.hpp aprwrap/array.hpp aprwrap/hash.hpp aprwrap/impl.cpp
aprwrap/pool.hpp
Author: brane
Date: Thu Jul 11 16:06:53 2013
New Revision: 1502262
URL: http://svn.apache.org/r1502262
Log:
Minor fixes in the C++HL APR wrappers.
* subversion/bindings/cxxhl/src/aprwrap/array.hpp
(Array::Array): Do not make copy constructors explicit.
(Array::at): Fix off-by-one in upper-bound check.
(ConstArray::ConstArray): Do not make copy constructors explicit.
(ConstArray::Iteration): Renamed from ConstIteration.
(ConstArray::iterate): Adjust argument type.
* subversion/bindings/cxxhl/src/aprwrap.hpp,
subversion/bindings/cxxhl/src/aprwrap/array.hpp,
subversion/bindings/cxxhl/src/aprwrap/hash.hpp,
subversion/bindings/cxxhl/src/aprwrap/pool.hpp,
subversion/bindings/cxxhl/src/aprwrap/impl.cpp:
Set svn:eol-style to 'native'.
Modified:
subversion/trunk/subversion/bindings/cxxhl/src/aprwrap.hpp (props changed)
subversion/trunk/subversion/bindings/cxxhl/src/aprwrap/array.hpp (contents, props changed)
subversion/trunk/subversion/bindings/cxxhl/src/aprwrap/hash.hpp (props changed)
subversion/trunk/subversion/bindings/cxxhl/src/aprwrap/impl.cpp (props changed)
subversion/trunk/subversion/bindings/cxxhl/src/aprwrap/pool.hpp (props changed)
Propchange: subversion/trunk/subversion/bindings/cxxhl/src/aprwrap.hpp
------------------------------------------------------------------------------
svn:eol-style = native
Modified: subversion/trunk/subversion/bindings/cxxhl/src/aprwrap/array.hpp
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/bindings/cxxhl/src/aprwrap/array.hpp?rev=1502262&r1=1502261&r2=1502262&view=diff
==============================================================================
--- subversion/trunk/subversion/bindings/cxxhl/src/aprwrap/array.hpp (original)
+++ subversion/trunk/subversion/bindings/cxxhl/src/aprwrap/array.hpp Thu Jul 11 16:06:53 2013
@@ -60,7 +60,7 @@ public:
/**
* Create a new proxy for the APR array wrapped by @a that.
*/
- explicit Array(const Array& that) throw()
+ Array(const Array& that) throw()
: m_array(that.m_array)
{}
@@ -105,7 +105,7 @@ public:
*/
const value_type& at(size_type index) const throw(std::out_of_range)
{
- if (index < 0 || index > size())
+ if (index < 0 || index >= size())
throw std::out_of_range(_("APR array index is out of range"));
return (*this)[index];
}
@@ -124,7 +124,7 @@ public:
*/
value_type& at(size_type index) throw(std::out_of_range)
{
- if (index < 0 || index > size())
+ if (index < 0 || index >= size())
throw std::out_of_range(_("APR array index is out of range"));
return (*this)[index];
}
@@ -213,7 +213,7 @@ public:
/**
* Create a new proxy for the APR array wrapped by @a that.
*/
- explicit ConstArray(const ConstArray& that) throw()
+ ConstArray(const ConstArray& that) throw()
: inherited(that)
{}
@@ -268,13 +268,13 @@ public:
/**
* Abstract base class for immutable iteration callback functors.
*/
- typedef typename inherited::ConstIteration ConstIteration;
+ typedef typename inherited::ConstIteration Iteration;
/**
* Iterate over all the values pairs in the array, invoking
* @a callback for each one.
*/
- void iterate(ConstIteration& callback) const
+ void iterate(Iteration& callback) const
{
inherited::iterate(callback);
}
Propchange: subversion/trunk/subversion/bindings/cxxhl/src/aprwrap/array.hpp
------------------------------------------------------------------------------
svn:eol-style = native
Propchange: subversion/trunk/subversion/bindings/cxxhl/src/aprwrap/hash.hpp
------------------------------------------------------------------------------
svn:eol-style = native
Propchange: subversion/trunk/subversion/bindings/cxxhl/src/aprwrap/impl.cpp
------------------------------------------------------------------------------
svn:eol-style = native
Propchange: subversion/trunk/subversion/bindings/cxxhl/src/aprwrap/pool.hpp
------------------------------------------------------------------------------
svn:eol-style = native