[GitHub] [ozone] symious commented on a change in pull request #2392: HDDS-5418. Let Recon send reregisterCommand to Datanodes if DatanodeDetails changed

[GitBox <gi...@apache.org>]

symious commented on a change in pull request #2392:
URL: https://github.com/apache/ozone/pull/2392#discussion_r667273774



##########
File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/protocol/DatanodeDetails.java
##########
@@ -509,6 +510,14 @@ public int hashCode() {
     return uuid.hashCode();
   }
 
+  // Skip The OpStates which may change in Runtime.
+  public int getSignature() {
+    return Objects
+        .hash(uuid, uuidString, ipAddress, hostName, ports,
+            certSerialId, version, setupTime, revision, buildDate,

Review comment:
       I think it will be good to include this information here, we can show the updated detail information like version, build date on the UI to the users?
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org