You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "FMX (via GitHub)" <gi...@apache.org> on 2023/02/24 09:19:28 UTC
[GitHub] [incubator-celeborn] FMX opened a new pull request, #1275: [CELEBORN-339][Flink] Should ignore readdata's backlog.
FMX opened a new pull request, #1275:
URL: https://github.com/apache/incubator-celeborn/pull/1275
### What changes were proposed in this pull request?
1. Ignore backlog in ReadData structure.
### Why are the changes needed?
It will reserve backlog repeatedly if not ignore the backlog.
### Does this PR introduce _any_ user-facing change?
NO.
### How was this patch tested?
UT and Cluster Test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1275: [CELEBORN-339][Flink] Should ignore readdata's backlog.
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1275:
URL: https://github.com/apache/incubator-celeborn/pull/1275#issuecomment-1443334375
# [Codecov](https://codecov.io/gh/apache/incubator-celeborn/pull/1275?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1275](https://codecov.io/gh/apache/incubator-celeborn/pull/1275?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f5c850b) into [main](https://codecov.io/gh/apache/incubator-celeborn/commit/af9e8366c917c9093b47b2fd8230e366f777af1f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (af9e836) will **decrease** coverage by `0.05%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #1275 +/- ##
============================================
- Coverage 27.08% 27.03% -0.05%
- Complexity 810 814 +4
============================================
Files 215 215
Lines 18368 18418 +50
Branches 1999 1982 -17
============================================
+ Hits 4973 4977 +4
- Misses 13067 13117 +50
+ Partials 328 324 -4
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-celeborn/pull/1275?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../org/apache/celeborn/client/ShuffleClientImpl.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1275?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9jbGllbnQvU2h1ZmZsZUNsaWVudEltcGwuamF2YQ==) | `16.24% <0.00%> (-1.92%)` | :arrow_down: |
| [...e/celeborn/common/protocol/message/StatusCode.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1275?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9jb21tb24vcHJvdG9jb2wvbWVzc2FnZS9TdGF0dXNDb2RlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...eleborn/common/exception/CelebornIOException.scala](https://codecov.io/gh/apache/incubator-celeborn/pull/1275?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL2V4Y2VwdGlvbi9DZWxlYm9ybklPRXhjZXB0aW9uLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...ommon/network/client/TransportResponseHandler.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1275?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9jb21tb24vbmV0d29yay9jbGllbnQvVHJhbnNwb3J0UmVzcG9uc2VIYW5kbGVyLmphdmE=) | `64.75% <0.00%> (+0.92%)` | :arrow_up: |
| [...celeborn/service/deploy/master/SlotsAllocator.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1275?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWFzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9zZXJ2aWNlL2RlcGxveS9tYXN0ZXIvU2xvdHNBbGxvY2F0b3IuamF2YQ==) | `71.73% <0.00%> (+2.46%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] FMX merged pull request #1275: [CELEBORN-339][Flink] Should ignore readdata's backlog.
Posted by "FMX (via GitHub)" <gi...@apache.org>.
FMX merged PR #1275:
URL: https://github.com/apache/incubator-celeborn/pull/1275
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org