You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@nemo.apache.org by GitBox <gi...@apache.org> on 2021/08/15 06:30:52 UTC
[GitHub] [incubator-nemo] Kangji opened a new pull request #318: [NEMO-472] Implement Intermediate Combine
Kangji opened a new pull request #318:
URL: https://github.com/apache/incubator-nemo/pull/318
JIRA: [NEMO-472: Fix and Implement Hierarchical Aggregation](https://issues.apache.org/jira/projects/NEMO/issues/NEMO-472)
**Major changes:**
- Implemented intermediate combine: will be used in hierarchical aggregation, which will be added soon.
* Split Beam Combine PerKey transform into 3 step (previously 2 step)
1. partial combine
2. intermediate combine (added, optional)
3. final combine
- Implemented unit tests
**Minor changes to note:**
- None
**Tests for the changes:**
- Tested on my Mac and ubuntu machine
**Other comments:**
- None
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@nemo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nemo] Kangji commented on a change in pull request #318: [NEMO-472] Implement Intermediate Combine
Posted by GitBox <gi...@apache.org>.
Kangji commented on a change in pull request #318:
URL: https://github.com/apache/incubator-nemo/pull/318#discussion_r698234444
##########
File path: common/src/main/java/org/apache/nemo/common/ir/IRDAGChecker.java
##########
@@ -486,6 +489,28 @@ void addEncodingCompressionCheckers() {
singleEdgeCheckerList.add(compressAndDecompress);
}
+ void addIntermediateAccumulatorVertexCheckers() {
+ final NeighborChecker shuffleExecutorSet = ((v, inEdges, outEdges) -> {
+ if (v.getPropertyValue(ShuffleExecutorSetProperty.class).isPresent()) {
Review comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@nemo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nemo] sonarcloud[bot] commented on pull request #318: [NEMO-472] Implement Intermediate Combine
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #318:
URL: https://github.com/apache/incubator-nemo/pull/318#issuecomment-956025871
Kudos, SonarCloud Quality Gate passed! 
[](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=org.apache.nemo%3Anemo-project&pullRequest=318) No Coverage information
[](https://sonarcloud.io/component_measures?id=org.apache.nemo%3Anemo-project&pullRequest=318&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=org.apache.nemo%3Anemo-project&pullRequest=318&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@nemo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nemo] sonarcloud[bot] removed a comment on pull request #318: [NEMO-472] Implement Intermediate Combine
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] removed a comment on pull request #318:
URL: https://github.com/apache/incubator-nemo/pull/318#issuecomment-899016523
Kudos, SonarCloud Quality Gate passed! 
[](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=org.apache.nemo%3Anemo-project&pullRequest=318) No Coverage information
[](https://sonarcloud.io/component_measures?id=org.apache.nemo%3Anemo-project&pullRequest=318&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=org.apache.nemo%3Anemo-project&pullRequest=318&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@nemo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nemo] wonook commented on pull request #318: [NEMO-472] Implement Intermediate Combine
Posted by GitBox <gi...@apache.org>.
wonook commented on pull request #318:
URL: https://github.com/apache/incubator-nemo/pull/318#issuecomment-956048053
@taegeonum Can you take a final look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@nemo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nemo] sonarcloud[bot] commented on pull request #318: [NEMO-472] Implement Intermediate Combine
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #318:
URL: https://github.com/apache/incubator-nemo/pull/318#issuecomment-899411303
Kudos, SonarCloud Quality Gate passed! 
[](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=org.apache.nemo%3Anemo-project&pullRequest=318) No Coverage information
[](https://sonarcloud.io/component_measures?id=org.apache.nemo%3Anemo-project&pullRequest=318&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=org.apache.nemo%3Anemo-project&pullRequest=318&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@nemo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nemo] wonook commented on a change in pull request #318: [NEMO-472] Implement Intermediate Combine
Posted by GitBox <gi...@apache.org>.
wonook commented on a change in pull request #318:
URL: https://github.com/apache/incubator-nemo/pull/318#discussion_r740001052
##########
File path: common/src/main/java/org/apache/nemo/common/ir/vertex/executionproperty/ShuffleExecutorSetProperty.java
##########
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.nemo.common.ir.vertex.executionproperty;
+
+import org.apache.nemo.common.ir.executionproperty.VertexExecutionProperty;
+
+import java.util.ArrayList;
+import java.util.HashSet;
+
+/**
+ * List of set of node names to limit the scheduling of the tasks of the vertex to while shuffling.
+ * ShuffleExecutorSetProperty is only for IntermediateAccumulatorVertex.
+ * Other vertices must not have this property.
+ */
+public final class ShuffleExecutorSetProperty extends VertexExecutionProperty<ArrayList<HashSet<String>>> {
+
+ /**
+ * Default constructor.
+ * @param value value of the execution property.
+ */
+ private ShuffleExecutorSetProperty(final ArrayList<HashSet<String>> value) {
Review comment:
Ditto
##########
File path: common/src/main/java/org/apache/nemo/common/ir/vertex/executionproperty/ShuffleExecutorSetProperty.java
##########
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.nemo.common.ir.vertex.executionproperty;
+
+import org.apache.nemo.common.ir.executionproperty.VertexExecutionProperty;
+
+import java.util.ArrayList;
+import java.util.HashSet;
+
+/**
+ * List of set of node names to limit the scheduling of the tasks of the vertex to while shuffling.
+ * ShuffleExecutorSetProperty is only for IntermediateAccumulatorVertex.
+ * Other vertices must not have this property.
+ */
+public final class ShuffleExecutorSetProperty extends VertexExecutionProperty<ArrayList<HashSet<String>>> {
+
+ /**
+ * Default constructor.
+ * @param value value of the execution property.
+ */
+ private ShuffleExecutorSetProperty(final ArrayList<HashSet<String>> value) {
+ super(value);
+ }
+
+ /**
+ * Static method for constructing {@link ShuffleExecutorSetProperty}.
+ *
+ * @param setsOfExecutors the list of executors to schedule the tasks of the vertex on.
+ * Leave empty to make it effectless.
+ * @return the new execution property
+ */
+ public static ShuffleExecutorSetProperty of(final HashSet<HashSet<String>> setsOfExecutors) {
Review comment:
Ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@nemo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nemo] Kangji commented on pull request #318: [NEMO-472] Implement Intermediate Combine
Posted by GitBox <gi...@apache.org>.
Kangji commented on pull request #318:
URL: https://github.com/apache/incubator-nemo/pull/318#issuecomment-925567033
> @Kangji Any update?
not yet... :( It has been delayed due to the fall semester, even though i'm trying to do asap. I'll let you know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@nemo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nemo] taegeonum commented on a change in pull request #318: [NEMO-472] Implement Intermediate Combine
Posted by GitBox <gi...@apache.org>.
taegeonum commented on a change in pull request #318:
URL: https://github.com/apache/incubator-nemo/pull/318#discussion_r698451787
##########
File path: common/src/main/java/org/apache/nemo/common/ir/vertex/executionproperty/ShuffleExecutorSetProperty.java
##########
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.nemo.common.ir.vertex.executionproperty;
+
+import org.apache.nemo.common.ir.executionproperty.VertexExecutionProperty;
+
+import java.util.ArrayList;
+import java.util.HashSet;
+
+/**
+ * List of set of node names to limit the scheduling of the tasks of the vertex to while shuffling.
+ * ShuffleExecutorSetProperty is only for IntermediateAccumulatorVertex.
+ * Other vertices must not have this property.
+ */
+public final class ShuffleExecutorSetProperty extends VertexExecutionProperty<ArrayList<HashSet<String>>> {
Review comment:
ArrayList<HashSet> -> List<Set>
##########
File path: common/src/main/java/org/apache/nemo/common/ir/vertex/executionproperty/ShuffleExecutorSetProperty.java
##########
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.nemo.common.ir.vertex.executionproperty;
+
+import org.apache.nemo.common.ir.executionproperty.VertexExecutionProperty;
+
+import java.util.ArrayList;
+import java.util.HashSet;
+
+/**
+ * List of set of node names to limit the scheduling of the tasks of the vertex to while shuffling.
+ * ShuffleExecutorSetProperty is only for IntermediateAccumulatorVertex.
+ * Other vertices must not have this property.
+ */
+public final class ShuffleExecutorSetProperty extends VertexExecutionProperty<ArrayList<HashSet<String>>> {
+
+ /**
+ * Default constructor.
+ * @param value value of the execution property.
+ */
+ private ShuffleExecutorSetProperty(final ArrayList<HashSet<String>> value) {
+ super(value);
+ }
+
+ /**
+ * Static method for constructing {@link ShuffleExecutorSetProperty}.
+ *
+ * @param setsOfExecutors the list of executors to schedule the tasks of the vertex on.
+ * Leave empty to make it effectless.
+ * @return the new execution property
+ */
+ public static ShuffleExecutorSetProperty of(final HashSet<HashSet<String>> setsOfExecutors) {
Review comment:
Set<Set<>>
##########
File path: common/src/main/java/org/apache/nemo/common/ir/vertex/executionproperty/ShuffleExecutorSetProperty.java
##########
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.nemo.common.ir.vertex.executionproperty;
+
+import org.apache.nemo.common.ir.executionproperty.VertexExecutionProperty;
+
+import java.util.ArrayList;
+import java.util.HashSet;
+
+/**
+ * List of set of node names to limit the scheduling of the tasks of the vertex to while shuffling.
Review comment:
This explanation is not clear to me. Does this property set the destination executor for the output of intermediate vertex?
##########
File path: compiler/optimizer/src/main/java/org/apache/nemo/compiler/optimizer/pass/compiletime/reshaping/IntermediateAccumulatorInsertionPass.java
##########
@@ -0,0 +1,179 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.nemo.compiler.optimizer.pass.compiletime.reshaping;
+
+import com.fasterxml.jackson.databind.ObjectMapper;
+import org.apache.nemo.common.Util;
+import org.apache.nemo.common.exception.SchedulingException;
+import org.apache.nemo.common.ir.IRDAG;
+import org.apache.nemo.common.ir.edge.IREdge;
+import org.apache.nemo.common.ir.edge.executionproperty.CommunicationPatternProperty;
+import org.apache.nemo.common.ir.vertex.OperatorVertex;
+import org.apache.nemo.common.ir.vertex.executionproperty.ParallelismProperty;
+import org.apache.nemo.common.ir.vertex.executionproperty.ShuffleExecutorSetProperty;
+import org.apache.nemo.common.ir.vertex.utility.IntermediateAccumulatorVertex;
+import org.apache.nemo.compiler.frontend.beam.transform.CombineTransform;
+import org.apache.nemo.compiler.optimizer.pass.compiletime.Requires;
+
+import java.io.File;
+import java.util.*;
+import java.util.stream.Collectors;
+import java.util.stream.IntStream;
+
+/**
+ * Pass for inserting intermediate aggregator for partial shuffle.
+ */
+@Requires(ParallelismProperty.class)
+public class IntermediateAccumulatorInsertionPass extends ReshapingPass {
Review comment:
public final
##########
File path: common/src/main/java/org/apache/nemo/common/ir/vertex/executionproperty/ShuffleExecutorSetProperty.java
##########
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.nemo.common.ir.vertex.executionproperty;
+
+import org.apache.nemo.common.ir.executionproperty.VertexExecutionProperty;
+
+import java.util.ArrayList;
+import java.util.HashSet;
+
+/**
+ * List of set of node names to limit the scheduling of the tasks of the vertex to while shuffling.
+ * ShuffleExecutorSetProperty is only for IntermediateAccumulatorVertex.
+ * Other vertices must not have this property.
+ */
+public final class ShuffleExecutorSetProperty extends VertexExecutionProperty<ArrayList<HashSet<String>>> {
+
+ /**
+ * Default constructor.
+ * @param value value of the execution property.
+ */
+ private ShuffleExecutorSetProperty(final ArrayList<HashSet<String>> value) {
Review comment:
List<Set<>>
##########
File path: compiler/optimizer/src/main/java/org/apache/nemo/compiler/optimizer/pass/compiletime/reshaping/IntermediateAccumulatorInsertionPass.java
##########
@@ -0,0 +1,179 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.nemo.compiler.optimizer.pass.compiletime.reshaping;
+
+import com.fasterxml.jackson.databind.ObjectMapper;
+import org.apache.nemo.common.Util;
+import org.apache.nemo.common.exception.SchedulingException;
+import org.apache.nemo.common.ir.IRDAG;
+import org.apache.nemo.common.ir.edge.IREdge;
+import org.apache.nemo.common.ir.edge.executionproperty.CommunicationPatternProperty;
+import org.apache.nemo.common.ir.vertex.OperatorVertex;
+import org.apache.nemo.common.ir.vertex.executionproperty.ParallelismProperty;
+import org.apache.nemo.common.ir.vertex.executionproperty.ShuffleExecutorSetProperty;
+import org.apache.nemo.common.ir.vertex.utility.IntermediateAccumulatorVertex;
+import org.apache.nemo.compiler.frontend.beam.transform.CombineTransform;
+import org.apache.nemo.compiler.optimizer.pass.compiletime.Requires;
+
+import java.io.File;
+import java.util.*;
+import java.util.stream.Collectors;
+import java.util.stream.IntStream;
+
+/**
+ * Pass for inserting intermediate aggregator for partial shuffle.
+ */
+@Requires(ParallelismProperty.class)
+public class IntermediateAccumulatorInsertionPass extends ReshapingPass {
+ private final String networkFilePath;
+ private boolean isUnitTest = false;
+ private static final Map<String, ArrayList<String>> UNIT_TEST_NETWORK_FILE = getUnitTestNetworkFile();
+
+ /**
+ * Default constructor.
+ */
+ public IntermediateAccumulatorInsertionPass() {
+ super(IntermediateAccumulatorInsertionPass.class);
+ this.networkFilePath = Util.fetchProjectRootPath() + "/tools/network_profiling/labeldict.json";
+ }
+
+ /**
+ * Constructor for unit test.
+ * @param isUnitTest indicates unit test.
+ */
+ public IntermediateAccumulatorInsertionPass(final boolean isUnitTest) {
+ this();
+ this.isUnitTest = isUnitTest;
+ }
+
+ private static Map<String, ArrayList<String>> getUnitTestNetworkFile() {
Review comment:
Adding unit test codes here doesn't look good to me.
##########
File path: common/src/main/java/org/apache/nemo/common/ir/vertex/utility/IntermediateAccumulatorVertex.java
##########
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.nemo.common.ir.vertex.utility;
+
+import org.apache.nemo.common.ir.vertex.OperatorVertex;
+import org.apache.nemo.common.ir.vertex.transform.Transform;
+
+/**
+ * During combine transform, accumulates data among physically nearby containers prior to shuffling across WAN.
+ */
+public class IntermediateAccumulatorVertex extends OperatorVertex {
Review comment:
public final class
##########
File path: compiler/frontend/beam/src/main/java/org/apache/nemo/compiler/frontend/beam/transform/CombineTransform.java
##########
@@ -45,9 +45,9 @@
* @param <InputT> input type
* @param <OutputT> output type
*/
-public final class GBKTransform<K, InputT, OutputT>
+public final class CombineTransform<K, InputT, OutputT>
Review comment:
As far as I know, GroupByKey Transform is not always be represented as Combine PerKey Transform, so changing the name is confusing to me. For instance, CoGroupByKey is not combining, but it is also represented as GroupByKey as far as I know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@nemo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nemo] Kangji commented on a change in pull request #318: [NEMO-472] Implement Intermediate Combine
Posted by GitBox <gi...@apache.org>.
Kangji commented on a change in pull request #318:
URL: https://github.com/apache/incubator-nemo/pull/318#discussion_r698234623
##########
File path: common/src/main/java/org/apache/nemo/common/ir/vertex/executionproperty/ShuffleExecutorSetProperty.java
##########
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.nemo.common.ir.vertex.executionproperty;
+
+import org.apache.nemo.common.ir.executionproperty.VertexExecutionProperty;
+
+import java.util.ArrayList;
+import java.util.HashSet;
+
+/**
+ * List of set of node names to limit the scheduling of the tasks of the vertex to while shuffling.
+ */
+public final class ShuffleExecutorSetProperty extends VertexExecutionProperty<ArrayList<HashSet<String>>> {
Review comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@nemo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nemo] Kangji commented on a change in pull request #318: [NEMO-472] Implement Intermediate Combine
Posted by GitBox <gi...@apache.org>.
Kangji commented on a change in pull request #318:
URL: https://github.com/apache/incubator-nemo/pull/318#discussion_r698233345
##########
File path: common/src/main/java/org/apache/nemo/common/ir/IRDAG.java
##########
@@ -799,6 +800,39 @@ public void insert(final TaskSizeSplitterVertex toInsert) {
modifiedDAG = builder.build();
}
+ public void insert(final OperatorVertex accumulatorVertex, final IREdge targetEdge) {
Review comment:
Done. I created new class `IntermediateAccumulatorVertex`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@nemo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nemo] sonarcloud[bot] commented on pull request #318: [NEMO-472] Implement Intermediate Combine
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #318:
URL: https://github.com/apache/incubator-nemo/pull/318#issuecomment-899016523
Kudos, SonarCloud Quality Gate passed! 
[](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=org.apache.nemo%3Anemo-project&pullRequest=318) No Coverage information
[](https://sonarcloud.io/component_measures?id=org.apache.nemo%3Anemo-project&pullRequest=318&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=org.apache.nemo%3Anemo-project&pullRequest=318&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@nemo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nemo] taegeonum commented on a change in pull request #318: [NEMO-472] Implement Intermediate Combine
Posted by GitBox <gi...@apache.org>.
taegeonum commented on a change in pull request #318:
URL: https://github.com/apache/incubator-nemo/pull/318#discussion_r698451787
##########
File path: common/src/main/java/org/apache/nemo/common/ir/vertex/executionproperty/ShuffleExecutorSetProperty.java
##########
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.nemo.common.ir.vertex.executionproperty;
+
+import org.apache.nemo.common.ir.executionproperty.VertexExecutionProperty;
+
+import java.util.ArrayList;
+import java.util.HashSet;
+
+/**
+ * List of set of node names to limit the scheduling of the tasks of the vertex to while shuffling.
+ * ShuffleExecutorSetProperty is only for IntermediateAccumulatorVertex.
+ * Other vertices must not have this property.
+ */
+public final class ShuffleExecutorSetProperty extends VertexExecutionProperty<ArrayList<HashSet<String>>> {
Review comment:
ArrayList<HashSet> -> List<Set>
##########
File path: common/src/main/java/org/apache/nemo/common/ir/vertex/executionproperty/ShuffleExecutorSetProperty.java
##########
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.nemo.common.ir.vertex.executionproperty;
+
+import org.apache.nemo.common.ir.executionproperty.VertexExecutionProperty;
+
+import java.util.ArrayList;
+import java.util.HashSet;
+
+/**
+ * List of set of node names to limit the scheduling of the tasks of the vertex to while shuffling.
+ * ShuffleExecutorSetProperty is only for IntermediateAccumulatorVertex.
+ * Other vertices must not have this property.
+ */
+public final class ShuffleExecutorSetProperty extends VertexExecutionProperty<ArrayList<HashSet<String>>> {
+
+ /**
+ * Default constructor.
+ * @param value value of the execution property.
+ */
+ private ShuffleExecutorSetProperty(final ArrayList<HashSet<String>> value) {
+ super(value);
+ }
+
+ /**
+ * Static method for constructing {@link ShuffleExecutorSetProperty}.
+ *
+ * @param setsOfExecutors the list of executors to schedule the tasks of the vertex on.
+ * Leave empty to make it effectless.
+ * @return the new execution property
+ */
+ public static ShuffleExecutorSetProperty of(final HashSet<HashSet<String>> setsOfExecutors) {
Review comment:
Set<Set<>>
##########
File path: common/src/main/java/org/apache/nemo/common/ir/vertex/executionproperty/ShuffleExecutorSetProperty.java
##########
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.nemo.common.ir.vertex.executionproperty;
+
+import org.apache.nemo.common.ir.executionproperty.VertexExecutionProperty;
+
+import java.util.ArrayList;
+import java.util.HashSet;
+
+/**
+ * List of set of node names to limit the scheduling of the tasks of the vertex to while shuffling.
Review comment:
This explanation is not clear to me. Does this property set the destination executor for the output of intermediate vertex?
##########
File path: compiler/optimizer/src/main/java/org/apache/nemo/compiler/optimizer/pass/compiletime/reshaping/IntermediateAccumulatorInsertionPass.java
##########
@@ -0,0 +1,179 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.nemo.compiler.optimizer.pass.compiletime.reshaping;
+
+import com.fasterxml.jackson.databind.ObjectMapper;
+import org.apache.nemo.common.Util;
+import org.apache.nemo.common.exception.SchedulingException;
+import org.apache.nemo.common.ir.IRDAG;
+import org.apache.nemo.common.ir.edge.IREdge;
+import org.apache.nemo.common.ir.edge.executionproperty.CommunicationPatternProperty;
+import org.apache.nemo.common.ir.vertex.OperatorVertex;
+import org.apache.nemo.common.ir.vertex.executionproperty.ParallelismProperty;
+import org.apache.nemo.common.ir.vertex.executionproperty.ShuffleExecutorSetProperty;
+import org.apache.nemo.common.ir.vertex.utility.IntermediateAccumulatorVertex;
+import org.apache.nemo.compiler.frontend.beam.transform.CombineTransform;
+import org.apache.nemo.compiler.optimizer.pass.compiletime.Requires;
+
+import java.io.File;
+import java.util.*;
+import java.util.stream.Collectors;
+import java.util.stream.IntStream;
+
+/**
+ * Pass for inserting intermediate aggregator for partial shuffle.
+ */
+@Requires(ParallelismProperty.class)
+public class IntermediateAccumulatorInsertionPass extends ReshapingPass {
Review comment:
public final
##########
File path: common/src/main/java/org/apache/nemo/common/ir/vertex/executionproperty/ShuffleExecutorSetProperty.java
##########
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.nemo.common.ir.vertex.executionproperty;
+
+import org.apache.nemo.common.ir.executionproperty.VertexExecutionProperty;
+
+import java.util.ArrayList;
+import java.util.HashSet;
+
+/**
+ * List of set of node names to limit the scheduling of the tasks of the vertex to while shuffling.
+ * ShuffleExecutorSetProperty is only for IntermediateAccumulatorVertex.
+ * Other vertices must not have this property.
+ */
+public final class ShuffleExecutorSetProperty extends VertexExecutionProperty<ArrayList<HashSet<String>>> {
+
+ /**
+ * Default constructor.
+ * @param value value of the execution property.
+ */
+ private ShuffleExecutorSetProperty(final ArrayList<HashSet<String>> value) {
Review comment:
List<Set<>>
##########
File path: compiler/optimizer/src/main/java/org/apache/nemo/compiler/optimizer/pass/compiletime/reshaping/IntermediateAccumulatorInsertionPass.java
##########
@@ -0,0 +1,179 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.nemo.compiler.optimizer.pass.compiletime.reshaping;
+
+import com.fasterxml.jackson.databind.ObjectMapper;
+import org.apache.nemo.common.Util;
+import org.apache.nemo.common.exception.SchedulingException;
+import org.apache.nemo.common.ir.IRDAG;
+import org.apache.nemo.common.ir.edge.IREdge;
+import org.apache.nemo.common.ir.edge.executionproperty.CommunicationPatternProperty;
+import org.apache.nemo.common.ir.vertex.OperatorVertex;
+import org.apache.nemo.common.ir.vertex.executionproperty.ParallelismProperty;
+import org.apache.nemo.common.ir.vertex.executionproperty.ShuffleExecutorSetProperty;
+import org.apache.nemo.common.ir.vertex.utility.IntermediateAccumulatorVertex;
+import org.apache.nemo.compiler.frontend.beam.transform.CombineTransform;
+import org.apache.nemo.compiler.optimizer.pass.compiletime.Requires;
+
+import java.io.File;
+import java.util.*;
+import java.util.stream.Collectors;
+import java.util.stream.IntStream;
+
+/**
+ * Pass for inserting intermediate aggregator for partial shuffle.
+ */
+@Requires(ParallelismProperty.class)
+public class IntermediateAccumulatorInsertionPass extends ReshapingPass {
+ private final String networkFilePath;
+ private boolean isUnitTest = false;
+ private static final Map<String, ArrayList<String>> UNIT_TEST_NETWORK_FILE = getUnitTestNetworkFile();
+
+ /**
+ * Default constructor.
+ */
+ public IntermediateAccumulatorInsertionPass() {
+ super(IntermediateAccumulatorInsertionPass.class);
+ this.networkFilePath = Util.fetchProjectRootPath() + "/tools/network_profiling/labeldict.json";
+ }
+
+ /**
+ * Constructor for unit test.
+ * @param isUnitTest indicates unit test.
+ */
+ public IntermediateAccumulatorInsertionPass(final boolean isUnitTest) {
+ this();
+ this.isUnitTest = isUnitTest;
+ }
+
+ private static Map<String, ArrayList<String>> getUnitTestNetworkFile() {
Review comment:
Adding unit test codes here doesn't look good to me.
##########
File path: common/src/main/java/org/apache/nemo/common/ir/vertex/utility/IntermediateAccumulatorVertex.java
##########
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.nemo.common.ir.vertex.utility;
+
+import org.apache.nemo.common.ir.vertex.OperatorVertex;
+import org.apache.nemo.common.ir.vertex.transform.Transform;
+
+/**
+ * During combine transform, accumulates data among physically nearby containers prior to shuffling across WAN.
+ */
+public class IntermediateAccumulatorVertex extends OperatorVertex {
Review comment:
public final class
##########
File path: compiler/frontend/beam/src/main/java/org/apache/nemo/compiler/frontend/beam/transform/CombineTransform.java
##########
@@ -45,9 +45,9 @@
* @param <InputT> input type
* @param <OutputT> output type
*/
-public final class GBKTransform<K, InputT, OutputT>
+public final class CombineTransform<K, InputT, OutputT>
Review comment:
As far as I know, GroupByKey Transform is not always be represented as Combine PerKey Transform, so changing the name is confusing to me. For instance, CoGroupByKey is not combining, but it is also represented as GroupByKey as far as I know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@nemo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nemo] wonook commented on a change in pull request #318: [NEMO-472] Implement Intermediate Combine
Posted by GitBox <gi...@apache.org>.
wonook commented on a change in pull request #318:
URL: https://github.com/apache/incubator-nemo/pull/318#discussion_r740000996
##########
File path: common/src/main/java/org/apache/nemo/common/ir/vertex/executionproperty/ShuffleExecutorSetProperty.java
##########
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.nemo.common.ir.vertex.executionproperty;
+
+import org.apache.nemo.common.ir.executionproperty.VertexExecutionProperty;
+
+import java.util.ArrayList;
+import java.util.HashSet;
+
+/**
+ * List of set of node names to limit the scheduling of the tasks of the vertex to while shuffling.
+ * ShuffleExecutorSetProperty is only for IntermediateAccumulatorVertex.
+ * Other vertices must not have this property.
+ */
+public final class ShuffleExecutorSetProperty extends VertexExecutionProperty<ArrayList<HashSet<String>>> {
Review comment:
This makes it unserializable, let's keep it as an array list. The HashSet is changed to a Set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@nemo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nemo] wonook commented on a change in pull request #318: [NEMO-472] Implement Intermediate Combine
Posted by GitBox <gi...@apache.org>.
wonook commented on a change in pull request #318:
URL: https://github.com/apache/incubator-nemo/pull/318#discussion_r740021634
##########
File path: compiler/optimizer/src/main/java/org/apache/nemo/compiler/optimizer/pass/compiletime/reshaping/IntermediateAccumulatorInsertionPass.java
##########
@@ -0,0 +1,179 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.nemo.compiler.optimizer.pass.compiletime.reshaping;
+
+import com.fasterxml.jackson.databind.ObjectMapper;
+import org.apache.nemo.common.Util;
+import org.apache.nemo.common.exception.SchedulingException;
+import org.apache.nemo.common.ir.IRDAG;
+import org.apache.nemo.common.ir.edge.IREdge;
+import org.apache.nemo.common.ir.edge.executionproperty.CommunicationPatternProperty;
+import org.apache.nemo.common.ir.vertex.OperatorVertex;
+import org.apache.nemo.common.ir.vertex.executionproperty.ParallelismProperty;
+import org.apache.nemo.common.ir.vertex.executionproperty.ShuffleExecutorSetProperty;
+import org.apache.nemo.common.ir.vertex.utility.IntermediateAccumulatorVertex;
+import org.apache.nemo.compiler.frontend.beam.transform.CombineTransform;
+import org.apache.nemo.compiler.optimizer.pass.compiletime.Requires;
+
+import java.io.File;
+import java.util.*;
+import java.util.stream.Collectors;
+import java.util.stream.IntStream;
+
+/**
+ * Pass for inserting intermediate aggregator for partial shuffle.
+ */
+@Requires(ParallelismProperty.class)
+public class IntermediateAccumulatorInsertionPass extends ReshapingPass {
+ private final String networkFilePath;
+ private boolean isUnitTest = false;
+ private static final Map<String, ArrayList<String>> UNIT_TEST_NETWORK_FILE = getUnitTestNetworkFile();
+
+ /**
+ * Default constructor.
+ */
+ public IntermediateAccumulatorInsertionPass() {
+ super(IntermediateAccumulatorInsertionPass.class);
+ this.networkFilePath = Util.fetchProjectRootPath() + "/tools/network_profiling/labeldict.json";
+ }
+
+ /**
+ * Constructor for unit test.
+ * @param isUnitTest indicates unit test.
+ */
+ public IntermediateAccumulatorInsertionPass(final boolean isUnitTest) {
+ this();
+ this.isUnitTest = isUnitTest;
+ }
+
+ private static Map<String, ArrayList<String>> getUnitTestNetworkFile() {
Review comment:
It's been moved to a resources file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@nemo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nemo] taegeonum commented on pull request #318: [NEMO-472] Implement Intermediate Combine
Posted by GitBox <gi...@apache.org>.
taegeonum commented on pull request #318:
URL: https://github.com/apache/incubator-nemo/pull/318#issuecomment-920365581
@Kangji Any update?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@nemo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nemo] Kangji commented on a change in pull request #318: [NEMO-472] Implement Intermediate Combine
Posted by GitBox <gi...@apache.org>.
Kangji commented on a change in pull request #318:
URL: https://github.com/apache/incubator-nemo/pull/318#discussion_r698234330
##########
File path: common/src/main/java/org/apache/nemo/common/ir/IRDAGChecker.java
##########
@@ -486,6 +489,28 @@ void addEncodingCompressionCheckers() {
singleEdgeCheckerList.add(compressAndDecompress);
}
+ void addIntermediateAccumulatorVertexCheckers() {
+ final NeighborChecker shuffleExecutorSet = ((v, inEdges, outEdges) -> {
+ if (v.getPropertyValue(ShuffleExecutorSetProperty.class).isPresent()) {
+ if (inEdges.size() != 1 || outEdges.size() != 1 || inEdges.stream().anyMatch(e ->
+ !e.getPropertyValue(CommunicationPatternProperty.class).get()
+ .equals(CommunicationPatternProperty.Value.PARTIAL_SHUFFLE))) {
+ return failure("Only intermediate accumulator vertex can have shuffle executor set property", v);
Review comment:
Done. I changed the condition more clearly using `IntermediateAccumulatorVertex` class, and fixed the comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@nemo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nemo] Kangji commented on a change in pull request #318: [NEMO-472] Implement Intermediate Combine
Posted by GitBox <gi...@apache.org>.
Kangji commented on a change in pull request #318:
URL: https://github.com/apache/incubator-nemo/pull/318#discussion_r698242157
##########
File path: compiler/frontend/beam/src/main/java/org/apache/nemo/compiler/frontend/beam/transform/CombineTransform.java
##########
@@ -45,9 +45,9 @@
* @param <InputT> input type
* @param <OutputT> output type
*/
-public final class GBKTransform<K, InputT, OutputT>
+public final class CombineTransform<K, InputT, OutputT>
Review comment:
It's because GroupByKey Transform in Beam semantics can be represented as Combine PerKey Transform, and I thought that this class represents Combine PerKey rather than GroupByKey.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@nemo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nemo] Kangji commented on pull request #318: [NEMO-472] Implement Intermediate Combine
Posted by GitBox <gi...@apache.org>.
Kangji commented on pull request #318:
URL: https://github.com/apache/incubator-nemo/pull/318#issuecomment-908086596
@taegeonum Thanks for the review! I've addressed your comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@nemo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nemo] sonarcloud[bot] commented on pull request #318: [NEMO-472] Implement Intermediate Combine
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #318:
URL: https://github.com/apache/incubator-nemo/pull/318#issuecomment-956025202
Kudos, SonarCloud Quality Gate passed! 
[](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=org.apache.nemo%3Anemo-project&pullRequest=318) No Coverage information
[](https://sonarcloud.io/component_measures?id=org.apache.nemo%3Anemo-project&pullRequest=318&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=org.apache.nemo%3Anemo-project&pullRequest=318&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@nemo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nemo] wonook commented on a change in pull request #318: [NEMO-472] Implement Intermediate Combine
Posted by GitBox <gi...@apache.org>.
wonook commented on a change in pull request #318:
URL: https://github.com/apache/incubator-nemo/pull/318#discussion_r740003061
##########
File path: common/src/main/java/org/apache/nemo/common/ir/vertex/executionproperty/ShuffleExecutorSetProperty.java
##########
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.nemo.common.ir.vertex.executionproperty;
+
+import org.apache.nemo.common.ir.executionproperty.VertexExecutionProperty;
+
+import java.util.ArrayList;
+import java.util.HashSet;
+
+/**
+ * List of set of node names to limit the scheduling of the tasks of the vertex to while shuffling.
Review comment:
It limits the sources of the data that each task reads from, depending on where the task is located at. I'll add the explanation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@nemo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nemo] wonook commented on a change in pull request #318: [NEMO-472] Implement Intermediate Combine
Posted by GitBox <gi...@apache.org>.
wonook commented on a change in pull request #318:
URL: https://github.com/apache/incubator-nemo/pull/318#discussion_r740003933
##########
File path: compiler/optimizer/src/main/java/org/apache/nemo/compiler/optimizer/pass/compiletime/reshaping/IntermediateAccumulatorInsertionPass.java
##########
@@ -0,0 +1,179 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.nemo.compiler.optimizer.pass.compiletime.reshaping;
+
+import com.fasterxml.jackson.databind.ObjectMapper;
+import org.apache.nemo.common.Util;
+import org.apache.nemo.common.exception.SchedulingException;
+import org.apache.nemo.common.ir.IRDAG;
+import org.apache.nemo.common.ir.edge.IREdge;
+import org.apache.nemo.common.ir.edge.executionproperty.CommunicationPatternProperty;
+import org.apache.nemo.common.ir.vertex.OperatorVertex;
+import org.apache.nemo.common.ir.vertex.executionproperty.ParallelismProperty;
+import org.apache.nemo.common.ir.vertex.executionproperty.ShuffleExecutorSetProperty;
+import org.apache.nemo.common.ir.vertex.utility.IntermediateAccumulatorVertex;
+import org.apache.nemo.compiler.frontend.beam.transform.CombineTransform;
+import org.apache.nemo.compiler.optimizer.pass.compiletime.Requires;
+
+import java.io.File;
+import java.util.*;
+import java.util.stream.Collectors;
+import java.util.stream.IntStream;
+
+/**
+ * Pass for inserting intermediate aggregator for partial shuffle.
+ */
+@Requires(ParallelismProperty.class)
+public class IntermediateAccumulatorInsertionPass extends ReshapingPass {
Review comment:
Solved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@nemo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nemo] taegeonum commented on a change in pull request #318: [NEMO-472] Implement Intermediate Combine
Posted by GitBox <gi...@apache.org>.
taegeonum commented on a change in pull request #318:
URL: https://github.com/apache/incubator-nemo/pull/318#discussion_r697936287
##########
File path: common/src/main/java/org/apache/nemo/common/ir/IRDAGChecker.java
##########
@@ -486,6 +489,28 @@ void addEncodingCompressionCheckers() {
singleEdgeCheckerList.add(compressAndDecompress);
}
+ void addIntermediateAccumulatorVertexCheckers() {
+ final NeighborChecker shuffleExecutorSet = ((v, inEdges, outEdges) -> {
+ if (v.getPropertyValue(ShuffleExecutorSetProperty.class).isPresent()) {
+ if (inEdges.size() != 1 || outEdges.size() != 1 || inEdges.stream().anyMatch(e ->
+ !e.getPropertyValue(CommunicationPatternProperty.class).get()
+ .equals(CommunicationPatternProperty.Value.PARTIAL_SHUFFLE))) {
+ return failure("Only intermediate accumulator vertex can have shuffle executor set property", v);
Review comment:
Isn't `v` is intermediate accumulator vertex?
Or the comment should be `An intermediate accumulator vertex can only have shuffle executor set property`?
##########
File path: compiler/frontend/beam/src/main/java/org/apache/nemo/compiler/frontend/beam/transform/CombineTransform.java
##########
@@ -45,9 +45,9 @@
* @param <InputT> input type
* @param <OutputT> output type
*/
-public final class GBKTransform<K, InputT, OutputT>
+public final class CombineTransform<K, InputT, OutputT>
Review comment:
Could you explain why the class name is changed?
##########
File path: common/src/main/java/org/apache/nemo/common/ir/IRDAGChecker.java
##########
@@ -486,6 +489,28 @@ void addEncodingCompressionCheckers() {
singleEdgeCheckerList.add(compressAndDecompress);
}
+ void addIntermediateAccumulatorVertexCheckers() {
+ final NeighborChecker shuffleExecutorSet = ((v, inEdges, outEdges) -> {
+ if (v.getPropertyValue(ShuffleExecutorSetProperty.class).isPresent()) {
Review comment:
We can filter accumulator vertex by `v` instanceof `PartialAccumulatorVertex` if we create `PartialAccumulatorVertex`
##########
File path: common/src/main/java/org/apache/nemo/common/ir/vertex/executionproperty/ShuffleExecutorSetProperty.java
##########
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.nemo.common.ir.vertex.executionproperty;
+
+import org.apache.nemo.common.ir.executionproperty.VertexExecutionProperty;
+
+import java.util.ArrayList;
+import java.util.HashSet;
+
+/**
+ * List of set of node names to limit the scheduling of the tasks of the vertex to while shuffling.
+ */
+public final class ShuffleExecutorSetProperty extends VertexExecutionProperty<ArrayList<HashSet<String>>> {
Review comment:
Is this only for paritial accumulator vertex? then please add some comments.
`PartialShuffleDestinationExecutorSetProperty`?
##########
File path: common/src/main/java/org/apache/nemo/common/ir/IRDAG.java
##########
@@ -799,6 +800,39 @@ public void insert(final TaskSizeSplitterVertex toInsert) {
modifiedDAG = builder.build();
}
+ public void insert(final OperatorVertex accumulatorVertex, final IREdge targetEdge) {
Review comment:
How about creating a new class `PartialAccumulatorVertex` that inherits `OperatorVertex`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@nemo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nemo] wonook commented on a change in pull request #318: [NEMO-472] Implement Intermediate Combine
Posted by GitBox <gi...@apache.org>.
wonook commented on a change in pull request #318:
URL: https://github.com/apache/incubator-nemo/pull/318#discussion_r740001233
##########
File path: common/src/main/java/org/apache/nemo/common/ir/vertex/utility/IntermediateAccumulatorVertex.java
##########
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.nemo.common.ir.vertex.utility;
+
+import org.apache.nemo.common.ir.vertex.OperatorVertex;
+import org.apache.nemo.common.ir.vertex.transform.Transform;
+
+/**
+ * During combine transform, accumulates data among physically nearby containers prior to shuffling across WAN.
+ */
+public class IntermediateAccumulatorVertex extends OperatorVertex {
Review comment:
Solved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@nemo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nemo] wonook commented on a change in pull request #318: [NEMO-472] Implement Intermediate Combine
Posted by GitBox <gi...@apache.org>.
wonook commented on a change in pull request #318:
URL: https://github.com/apache/incubator-nemo/pull/318#discussion_r740047375
##########
File path: compiler/frontend/beam/src/main/java/org/apache/nemo/compiler/frontend/beam/transform/CombineTransform.java
##########
@@ -45,9 +45,9 @@
* @param <InputT> input type
* @param <OutputT> output type
*/
-public final class GBKTransform<K, InputT, OutputT>
+public final class CombineTransform<K, InputT, OutputT>
Review comment:
We actually have a separate GroupByKeyTransform. We have renamed the GBKTransform since it actually works as a CombineTransform. It was misnamed in the first place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@nemo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nemo] sonarcloud[bot] commented on pull request #318: [NEMO-472] Implement Intermediate Combine
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #318:
URL: https://github.com/apache/incubator-nemo/pull/318#issuecomment-908076917
Kudos, SonarCloud Quality Gate passed! 
[](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=org.apache.nemo%3Anemo-project&pullRequest=318) No Coverage information
[](https://sonarcloud.io/component_measures?id=org.apache.nemo%3Anemo-project&pullRequest=318&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=org.apache.nemo%3Anemo-project&pullRequest=318&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@nemo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nemo] sonarcloud[bot] removed a comment on pull request #318: [NEMO-472] Implement Intermediate Combine
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] removed a comment on pull request #318:
URL: https://github.com/apache/incubator-nemo/pull/318#issuecomment-899411303
Kudos, SonarCloud Quality Gate passed! 
[](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=org.apache.nemo%3Anemo-project&pullRequest=318) No Coverage information
[](https://sonarcloud.io/component_measures?id=org.apache.nemo%3Anemo-project&pullRequest=318&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=org.apache.nemo%3Anemo-project&pullRequest=318&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@nemo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nemo] sonarcloud[bot] removed a comment on pull request #318: [NEMO-472] Implement Intermediate Combine
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] removed a comment on pull request #318:
URL: https://github.com/apache/incubator-nemo/pull/318#issuecomment-956025202
Kudos, SonarCloud Quality Gate passed! 
[](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=org.apache.nemo%3Anemo-project&pullRequest=318) No Coverage information
[](https://sonarcloud.io/component_measures?id=org.apache.nemo%3Anemo-project&pullRequest=318&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=org.apache.nemo%3Anemo-project&pullRequest=318&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@nemo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nemo] sonarcloud[bot] commented on pull request #318: [NEMO-472] Implement Intermediate Combine
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #318:
URL: https://github.com/apache/incubator-nemo/pull/318#issuecomment-899004072
Kudos, SonarCloud Quality Gate passed! 
[](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=org.apache.nemo%3Anemo-project&pullRequest=318) No Coverage information
[](https://sonarcloud.io/component_measures?id=org.apache.nemo%3Anemo-project&pullRequest=318&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@nemo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nemo] sonarcloud[bot] removed a comment on pull request #318: [NEMO-472] Implement Intermediate Combine
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] removed a comment on pull request #318:
URL: https://github.com/apache/incubator-nemo/pull/318#issuecomment-899004072
Kudos, SonarCloud Quality Gate passed! 
[](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=org.apache.nemo%3Anemo-project&pullRequest=318&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=org.apache.nemo%3Anemo-project&pullRequest=318) No Coverage information
[](https://sonarcloud.io/component_measures?id=org.apache.nemo%3Anemo-project&pullRequest=318&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@nemo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org