You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2017/05/11 15:34:05 UTC

Review Request 59180: Cluster Repository State Is Not Calculated Correctly For Service/Patch Repos

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59180/
-----------------------------------------------------------

Review request for Ambari and Nate Cole.


Bugs: AMBARI-20991
    https://issues.apache.org/jira/browse/AMBARI-20991


Repository: ambari


Description
-------

The cluster version state is not taking into account the correct values for {{SERVICE}} and {{PATCH}} upgrades. When at least host is {{NOT_REQUIRED}}, the aggregate value is marked as {{INSTALLING}}. 

{code}
    {
      "href": "http://localhost:8080/api/v1/clusters/c1/stack_versions/2",
      "ClusterStackVersions": {
        "cluster_name": "c1",
        "id": 2,
        "repository_version": 2,
        "stack": "HDP",
        "state": "INSTALLING",
        "version": "2.5",
        "host_states": {
          "CURRENT": [],
          "INIT": [],
          "INSTALLED": [
            "c6401.ambari.apache.org"
          ],
          "INSTALLING": [],
          "INSTALL_FAILED": [],
          "NOT_REQUIRED": [
            "c6402.ambari.apache.org",
            "c6403.ambari.apache.org"
          ],
          "OUT_OF_SYNC": []
        }
      }
{code}


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java 1e49eb275f 


Diff: https://reviews.apache.org/r/59180/diff/1/


Testing
-------

Manual Testing to unblock front-end issues.


Thanks,

Jonathan Hurley


Re: Review Request 59180: Cluster Repository State Is Not Calculated Correctly For Service/Patch Repos

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59180/#review174659
-----------------------------------------------------------


Ship it!




Ship It!

- Nate Cole


On May 11, 2017, 11:34 a.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59180/
> -----------------------------------------------------------
> 
> (Updated May 11, 2017, 11:34 a.m.)
> 
> 
> Review request for Ambari and Nate Cole.
> 
> 
> Bugs: AMBARI-20991
>     https://issues.apache.org/jira/browse/AMBARI-20991
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The cluster version state is not taking into account the correct values for {{SERVICE}} and {{PATCH}} upgrades. When at least host is {{NOT_REQUIRED}}, the aggregate value is marked as {{INSTALLING}}. 
> 
> {code}
>     {
>       "href": "http://localhost:8080/api/v1/clusters/c1/stack_versions/2",
>       "ClusterStackVersions": {
>         "cluster_name": "c1",
>         "id": 2,
>         "repository_version": 2,
>         "stack": "HDP",
>         "state": "INSTALLING",
>         "version": "2.5",
>         "host_states": {
>           "CURRENT": [],
>           "INIT": [],
>           "INSTALLED": [
>             "c6401.ambari.apache.org"
>           ],
>           "INSTALLING": [],
>           "INSTALL_FAILED": [],
>           "NOT_REQUIRED": [
>             "c6402.ambari.apache.org",
>             "c6403.ambari.apache.org"
>           ],
>           "OUT_OF_SYNC": []
>         }
>       }
> {code}
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java 1e49eb275f 
> 
> 
> Diff: https://reviews.apache.org/r/59180/diff/1/
> 
> 
> Testing
> -------
> 
> Manual Testing to unblock front-end issues.
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>