You are viewing a plain text version of this content. The canonical link for it is here.
Posted to xindice-dev@xml.apache.org by "Vladimir R. Bossicard" <vl...@bossicard.com> on 2002/11/14 08:20:57 UTC
[PATCH] Question about the system.xml file
With the following patch, you can specify a configuration file where
Xindice embedded version will store the database.
Before committing the changes, I would like the opinion of other committers.
-Vladimir
--
Vladimir R. Bossicard
www.bossicard.com
Re: [PATCH] Question about the system.xml file
Posted by Kevin Ross <Ke...@iVerticalLeap.com>.
BTW: If we want to start getting more elaborate with the system
configuration, I'm pretty good with the commons-digester, so we can
easily make changes...
-Kevin
Murray Altheim wrote:
> Vladimir R. Bossicard wrote:
>
>>
>>> The only thing that strikes me from looking at the patch is the
>>> hardcoded database name.
>>
>>
>> Where? The goal of the patch is to correct that so if you're right,
>> I missed a spot :-)
>>
>> Can you be more precise?
>
>
>
> Gah. I read the patch backward. You're correct, sorry.
>
> Murray
>
> ......................................................................
> Murray Altheim <http://kmi.open.ac.uk/people/murray/>
> Knowledge Media Institute
> The Open University, Milton Keynes, Bucks, MK7 6AA, UK
>
> If you're the first person in a new territory,
> you're likely to get shot at.
> -- ma
>
Re: [PATCH] Question about the system.xml file
Posted by Murray Altheim <m....@open.ac.uk>.
Vladimir R. Bossicard wrote:
>
>> The only thing that strikes me from looking at the patch is the
>> hardcoded database name.
>
> Where? The goal of the patch is to correct that so if you're right, I
> missed a spot :-)
>
> Can you be more precise?
Gah. I read the patch backward. You're correct, sorry.
Murray
......................................................................
Murray Altheim <http://kmi.open.ac.uk/people/murray/>
Knowledge Media Institute
The Open University, Milton Keynes, Bucks, MK7 6AA, UK
If you're the first person in a new territory,
you're likely to get shot at.
-- ma
Re: [PATCH] Question about the system.xml file
Posted by "Vladimir R. Bossicard" <vl...@bossicard.com>.
> The only thing that strikes me from looking at the patch is the
> hardcoded database name.
Where? The goal of the patch is to correct that so if you're right, I
missed a spot :-)
Can you be more precise?
Thanks
-Vladimir
--
Vladimir R. Bossicard
www.bossicard.com
Re: [PATCH] Question about the system.xml file
Posted by Murray Altheim <m....@open.ac.uk>.
Vladimir R. Bossicard wrote:
> With the following patch, you can specify a configuration file where
> Xindice embedded version will store the database.
>
> Before committing the changes, I would like the opinion of other committers.
>
> -Vladimir
The only thing that strikes me from looking at the patch is the
hardcoded database name. At very least couldn't this be a static
String? I think there should be some way to easily change this.
Murray
......................................................................
Murray Altheim <http://kmi.open.ac.uk/people/murray/>
Knowledge Media Institute
The Open University, Milton Keynes, Bucks, MK7 6AA, UK
If you're the first person in a new territory,
you're likely to get shot at.
-- ma