You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "dpogue (via GitHub)" <gi...@apache.org> on 2024/11/11 07:27:39 UTC
[PR] feat(spm): Add method to determine if a plugin is a Swift package [cordova-common]
dpogue opened a new pull request, #216:
URL: https://github.com/apache/cordova-common/pull/216
### Platforms affected
iOS
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
We want a declarative way for a plugin to opt-in to using Package.swift for managing its code and resources as opposed to file copying with `source-file`/`header-file`/`resource-file`/etc.
### Description
<!-- Describe your changes in detail -->
Adds a helper method to detect if there is a `<platform name="ios" package="swift">` tag.
Caveats:
* This currently only looks at the first iOS platform declaration
* This doesn't currently check the value of the `package` attribute. If it exists, we assume it is a Swift package. Ideally I'd love for this to be a boolean attribute like in HTML, but XML doesn't support those 😒
### Testing
<!-- Please describe in detail how you tested your changes. -->
Added unit test case.
### Checklist
- [x] I've run the tests to see all new and existing tests pass
- [x] I added automated test coverage as appropriate for this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] feat(spm): Add method to determine if a plugin is a Swift package [cordova-common]
Posted by "dpogue (via GitHub)" <gi...@apache.org>.
dpogue closed pull request #216: feat(spm): Add method to determine if a plugin is a Swift package
URL: https://github.com/apache/cordova-common/pull/216
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] feat(spm): Add method to determine if a plugin is a Swift package [cordova-common]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #216:
URL: https://github.com/apache/cordova-common/pull/216#issuecomment-2467422690
## [Codecov](https://app.codecov.io/gh/apache/cordova-common/pull/216?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 88.42%. Comparing base [(`24f7fa2`)](https://app.codecov.io/gh/apache/cordova-common/commit/24f7fa2f1a61d58f48ec8ad6b10942378ff12146?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`5005e3f`)](https://app.codecov.io/gh/apache/cordova-common/commit/5005e3fd85e1d819750f4000bd1aab07f4c35e28?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #216 +/- ##
==========================================
+ Coverage 88.40% 88.42% +0.02%
==========================================
Files 20 20
Lines 1147 1149 +2
==========================================
+ Hits 1014 1016 +2
Misses 133 133
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cordova-common/pull/216?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] feat(spm): Add method to determine if a plugin is a Swift package [cordova-common]
Posted by "dpogue (via GitHub)" <gi...@apache.org>.
dpogue commented on PR #216:
URL: https://github.com/apache/cordova-common/pull/216#issuecomment-2495418612
I found a way to handle this in the platform that doesn't involve modifying cordova-common, so I'm going to close this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org