[jira] Commented: (MAPREDUCE-1953) [Rumen] Fail early if -input-cycle in not specified in Folder

["Amar Kamat (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-1953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12890571#action_12890571 ] 

Amar Kamat commented on MAPREDUCE-1953:
---------------------------------------

One improvement would be to assume a default value of {{-input-cycle}}. Is this doable?

> [Rumen] Fail early if -input-cycle in not specified in Folder
> -------------------------------------------------------------
>
>                 Key: MAPREDUCE-1953
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1953
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: tools/rumen
>            Reporter: Amar Kamat
>             Fix For: 0.22.0
>
>
> The Folder code does the following
> {code}
> inputCycle = // extract the value of -input-cycle from args
> ..
> // other inits and FileSystem operations
> ..
> if (inputCycle <= 0) {
>   LOG.error("You must have an input cycle length.");
>   return NO_INPUT_CYCLE_LENGTH;
> }
> if (outputDuration <= 0) {
>   outputDuration = 60L * 60L * TICKS_PER_SECOND;
> }
> if (inputCycle <= 0) {
>   inputCycle = outputDuration;
> }
> {code}
> There is no point in doing other initializations if _-input-cycle_ is not provided

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.