[jira] [Commented] (BEAM-903) Flatten Timer Deliveries in WatermarkManager

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15634413#comment-15634413 ] 

ASF GitHub Bot commented on BEAM-903:
-------------------------------------

GitHub user tgroh opened a pull request:

    https://github.com/apache/incubator-beam/pull/1276

    [BEAM-903] Flatten FiredTimers and ExtractFiredTimers

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    Pass a single collection of fired timers, and have those objects contain
    the associated transform and key that they fired for. Timers already
    contain the domain they are in.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/incubator-beam flatten_timers

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1276.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1276
    
----
commit 2370d3d836467c04e8dc82bb7bf6d12c1dc8ea82
Author: Thomas Groh <tg...@google.com>
Date:   2016-11-03T21:10:37Z

    Flatten FiredTimers and ExtractFiredTimers
    
    Pass a single collection of fired timers, and have those objects contain
    the associated transform and key that they fired for. Timers already
    contain the domain they are in.

----


> Flatten Timer Deliveries in WatermarkManager
> --------------------------------------------
>
>                 Key: BEAM-903
>                 URL: https://issues.apache.org/jira/browse/BEAM-903
>             Project: Beam
>          Issue Type: Improvement
>          Components: runner-direct
>            Reporter: Thomas Groh
>            Assignee: Thomas Groh
>
> Most of the data associated with timers is already a property of the Timer, or functions regardless of segregation into time domains. Reduce the complexity of the {{fireTimers}} method in the monitor runnable by returning a flat list of (Transform, Key, Timers) instead of a triply nested map.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)