You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Laszlo Gaal (Code Review)" <ge...@cloudera.org> on 2025/03/05 22:43:58 UTC
[Impala-ASF-CR] IMPALA-13826: Replace imp with importlib in the config generator
Laszlo Gaal has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22582
Change subject: IMPALA-13826: Replace imp with importlib in the config generator
......................................................................
IMPALA-13826: Replace imp with importlib in the config generator
because the imp package is deprecated in Python 3.
The template generator uses a single call to imp.load_source, which was
replaced with an example published in Python's official documentation.
Change-Id: I472d093eeaac97a380d444a1756b54f825b2d031
---
M bin/generate_xml_config.py
1 file changed, 26 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/82/22582/1
--
To view, visit http://gerrit.cloudera.org:8080/22582
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I472d093eeaac97a380d444a1756b54f825b2d031
Gerrit-Change-Number: 22582
Gerrit-PatchSet: 1
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
[Impala-ASF-CR] IMPALA-13826: Replace imp with importlib in the config generator
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22582 )
Change subject: IMPALA-13826: Replace imp with importlib in the config generator
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/18480/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/22582
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I472d093eeaac97a380d444a1756b54f825b2d031
Gerrit-Change-Number: 22582
Gerrit-PatchSet: 1
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 05 Mar 2025 23:12:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13826: Migrate from imp to importlib in the config generator
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22582 )
Change subject: IMPALA-13826: Migrate from imp to importlib in the config generator
......................................................................
IMPALA-13826: Migrate from imp to importlib in the config generator
Python has deprecated the 'imp' package in Python 3.4, and removed it in
Python 3.12. The deprecation has also started throwing warnings in
versions before 3.12.
The template generator used a single call to imp.load_source to load the
template Python file. This is now replaced with code snippet published
in Python's official documentation.
Change-Id: I472d093eeaac97a380d444a1756b54f825b2d031
Reviewed-on: http://gerrit.cloudera.org:8080/22582
Reviewed-by: Zoltan Borok-Nagy <bo...@cloudera.com>
Tested-by: Laszlo Gaal <la...@cloudera.com>
---
M bin/generate_xml_config.py
1 file changed, 28 insertions(+), 2 deletions(-)
Approvals:
Zoltan Borok-Nagy: Looks good to me, approved
Laszlo Gaal: Verified
--
To view, visit http://gerrit.cloudera.org:8080/22582
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I472d093eeaac97a380d444a1756b54f825b2d031
Gerrit-Change-Number: 22582
Gerrit-PatchSet: 5
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-13826: Replace imp with importlib in the config generator
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22582
to look at the new patch set (#2).
Change subject: IMPALA-13826: Replace imp with importlib in the config generator
......................................................................
IMPALA-13826: Replace imp with importlib in the config generator
because the imp package is deprecated in Python 3.
The template generator uses a single call to imp.load_source, which was
replaced with an example published in Python's official documentation.
Change-Id: I472d093eeaac97a380d444a1756b54f825b2d031
---
M bin/generate_xml_config.py
1 file changed, 28 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/82/22582/2
--
To view, visit http://gerrit.cloudera.org:8080/22582
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I472d093eeaac97a380d444a1756b54f825b2d031
Gerrit-Change-Number: 22582
Gerrit-PatchSet: 2
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-13826: Migrate from imp to importlib in the config generator
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/22582 )
Change subject: IMPALA-13826: Migrate from imp to importlib in the config generator
......................................................................
Patch Set 4: Verified+1
Verified with a GVO stacked run
--
To view, visit http://gerrit.cloudera.org:8080/22582
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I472d093eeaac97a380d444a1756b54f825b2d031
Gerrit-Change-Number: 22582
Gerrit-PatchSet: 4
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 28 Mar 2025 13:38:17 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13826: Migrate from imp to importlib in the config generator
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22582
to look at the new patch set (#3).
Change subject: IMPALA-13826: Migrate from imp to importlib in the config generator
......................................................................
IMPALA-13826: Migrate from imp to importlib in the config generator
Python has deprecated the 'imp' package in Python 3.4, and removed it in
Python 3.12. The deprecation has also started throwing warnings in
versions before 3.12.
The template generator used a single call to imp.load_source to load the
template Python file. This is now replaced with code snippet published
in Python's official documentation.
Change-Id: I472d093eeaac97a380d444a1756b54f825b2d031
---
M bin/generate_xml_config.py
1 file changed, 28 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/82/22582/3
--
To view, visit http://gerrit.cloudera.org:8080/22582
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I472d093eeaac97a380d444a1756b54f825b2d031
Gerrit-Change-Number: 22582
Gerrit-PatchSet: 3
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-13826: Migrate from imp to importlib in the config generator
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/22582 )
Change subject: IMPALA-13826: Migrate from imp to importlib in the config generator
......................................................................
Patch Set 4: Code-Review+2
LGTM!
--
To view, visit http://gerrit.cloudera.org:8080/22582
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I472d093eeaac97a380d444a1756b54f825b2d031
Gerrit-Change-Number: 22582
Gerrit-PatchSet: 4
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 21 Mar 2025 13:28:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13826: Replace imp with importlib in the config generator
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22582 )
Change subject: IMPALA-13826: Replace imp with importlib in the config generator
......................................................................
Patch Set 1:
(2 comments)
gerrit-auto-critic failed. You can reproduce it locally using command:
python3 bin/jenkins/critique-gerrit-review.py --dryrun
To run it, you might need a virtual env with Python3's venv installed.
http://gerrit.cloudera.org:8080/#/c/22582/1/bin/generate_xml_config.py
File bin/generate_xml_config.py:
http://gerrit.cloudera.org:8080/#/c/22582/1/bin/generate_xml_config.py@96
PS1, Line 96: def load_source_with_importlib(modname, filename):
flake8: E302 expected 2 blank lines, found 1
http://gerrit.cloudera.org:8080/#/c/22582/1/bin/generate_xml_config.py@112
PS1, Line 112: def import_template(name, module_path):
flake8: E302 expected 2 blank lines, found 1
--
To view, visit http://gerrit.cloudera.org:8080/22582
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I472d093eeaac97a380d444a1756b54f825b2d031
Gerrit-Change-Number: 22582
Gerrit-PatchSet: 1
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 05 Mar 2025 22:45:58 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13826: Replace imp with importlib in the config generator
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22582 )
Change subject: IMPALA-13826: Replace imp with importlib in the config generator
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/18500/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/22582
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I472d093eeaac97a380d444a1756b54f825b2d031
Gerrit-Change-Number: 22582
Gerrit-PatchSet: 2
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 07 Mar 2025 00:33:05 +0000
Gerrit-HasComments: No