[jira] Closed: (TAPESTRY-519) NestedMarkupWriterImpl doesn't close the current open tag when getBuffer() is called

["Howard M. Lewis Ship (JIRA)" <ta...@jakarta.apache.org>]

     [ http://issues.apache.org/jira/browse/TAPESTRY-519?page=all ]
     
Howard M. Lewis Ship closed TAPESTRY-519:
-----------------------------------------

    Fix Version: 4.0
     Resolution: Fixed

> NestedMarkupWriterImpl doesn't close the current open tag when getBuffer() is called
> ------------------------------------------------------------------------------------
>
>          Key: TAPESTRY-519
>          URL: http://issues.apache.org/jira/browse/TAPESTRY-519
>      Project: Tapestry
>         Type: Bug
>   Components: Framework
>     Versions: 4.0
>     Reporter: Raphael Jean
>     Assignee: Howard M. Lewis Ship
>      Fix For: 4.0

>
> NestedMarkupWriterImpl doesn't close the currently open tag when getBuffer() is called. This causes invalid HTML to be produced in FormSupport.preRenderField().
> For example, an Upload component will be rendered as <input type="file" name="upload" id="upload"
> This could be fixed by moving part of the close() method into getBuffer():
>     public String getBuffer()
>     {
>         if (_closed)
>             throw new IllegalStateException(MarkupMessages.closeOnce());
>         _closed = true;
>         super.close();
>         return _charArrayWriter.toString();
>     }
>     public void close()
>     {
>         String content = getBuffer();
>         _parent.printRaw(content);
>     }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-dev-help@jakarta.apache.org