You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/09/01 11:10:55 UTC
[GitHub] [hudi] pengzhiwei2018 opened a new pull request #3580: [HUDI-1869] Upgrading Spark3 To 3.1
pengzhiwei2018 opened a new pull request #3580:
URL: https://github.com/apache/hudi/pull/3580
## What is the purpose of the pull request
- Upgrading spark3 version from the spark3.0.x to spark 3.1
- After this upgrading, spark 3.0.x will not supported as spark 3.1 has many change to the class interface. We can only support spark 3.1.x for spark3 since spark 3.0.x is not a very statable version for spark3. The newest spark version is spark 3.1.2 now.
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar commented on pull request #3580: [HUDI-1869] Upgrading Spark3 To 3.1
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on pull request #3580:
URL: https://github.com/apache/hudi/pull/3580#issuecomment-910862211
>spark 3.0.x will not supported as spark 3.1 has many changes to the class interface.
this is just crazy how badly it breaks across minor versions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3580: [HUDI-1869] Upgrading Spark3 To 3.1
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3580:
URL: https://github.com/apache/hudi/pull/3580#issuecomment-910182373
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "030cffd68dfda49994096cf82a0090185ced2581",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1975",
"triggerID" : "030cffd68dfda49994096cf82a0090185ced2581",
"triggerType" : "PUSH"
}, {
"hash" : "cb2e9d52f62a2e75f6330d44b89bac16d8b6a9c3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1980",
"triggerID" : "cb2e9d52f62a2e75f6330d44b89bac16d8b6a9c3",
"triggerType" : "PUSH"
}, {
"hash" : "cb5cfb39017db2f09ce5c5fc8d0af5e2a35b92eb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cb5cfb39017db2f09ce5c5fc8d0af5e2a35b92eb",
"triggerType" : "PUSH"
}, {
"hash" : "b418e2b13f4c4bbb9b9ba87059abc66d303cc1b0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b418e2b13f4c4bbb9b9ba87059abc66d303cc1b0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cb2e9d52f62a2e75f6330d44b89bac16d8b6a9c3 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1980)
* cb5cfb39017db2f09ce5c5fc8d0af5e2a35b92eb UNKNOWN
* b418e2b13f4c4bbb9b9ba87059abc66d303cc1b0 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan commented on a change in pull request #3580: [HUDI-1869] Upgrading Spark3 To 3.1
Posted by GitBox <gi...@apache.org>.
xushiyan commented on a change in pull request #3580:
URL: https://github.com/apache/hudi/pull/3580#discussion_r706777459
##########
File path: pom.xml
##########
@@ -1486,6 +1487,16 @@
</activation>
</profile>
+ <profile>
+ <id>isSpark3.0</id>
+<!-- for spark 3.0.x we need override the follow propeprties to package and run test-->
+ <properties>
+ <spark3.version>3.0.0</spark3.version>
+ <spark.version>${spark3.version}</spark.version>
+ <scalatest.version>3.0.1</scalatest.version>
+ </properties>
+ </profile>
Review comment:
instead of a boolean flag, better be explicit about spark version and have a maven profile match to it. we can call it `-Dspark3.0` and keep `-Dspark3` points to the latest Spark 3 release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #3580: [HUDI-1869] Upgrading Spark3 To 3.1
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3580:
URL: https://github.com/apache/hudi/pull/3580#issuecomment-910182373
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "030cffd68dfda49994096cf82a0090185ced2581",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "030cffd68dfda49994096cf82a0090185ced2581",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 030cffd68dfda49994096cf82a0090185ced2581 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3580: [HUDI-1869] Upgrading Spark3 To 3.1
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3580:
URL: https://github.com/apache/hudi/pull/3580#issuecomment-910182373
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "030cffd68dfda49994096cf82a0090185ced2581",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1975",
"triggerID" : "030cffd68dfda49994096cf82a0090185ced2581",
"triggerType" : "PUSH"
}, {
"hash" : "cb2e9d52f62a2e75f6330d44b89bac16d8b6a9c3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1980",
"triggerID" : "cb2e9d52f62a2e75f6330d44b89bac16d8b6a9c3",
"triggerType" : "PUSH"
}, {
"hash" : "cb5cfb39017db2f09ce5c5fc8d0af5e2a35b92eb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cb5cfb39017db2f09ce5c5fc8d0af5e2a35b92eb",
"triggerType" : "PUSH"
}, {
"hash" : "b418e2b13f4c4bbb9b9ba87059abc66d303cc1b0",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1989",
"triggerID" : "b418e2b13f4c4bbb9b9ba87059abc66d303cc1b0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cb5cfb39017db2f09ce5c5fc8d0af5e2a35b92eb UNKNOWN
* b418e2b13f4c4bbb9b9ba87059abc66d303cc1b0 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1989)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan commented on pull request #3580: [HUDI-1869] Upgrading Spark3 To 3.1
Posted by GitBox <gi...@apache.org>.
xushiyan commented on pull request #3580:
URL: https://github.com/apache/hudi/pull/3580#issuecomment-950277408
This change continues in https://github.com/apache/hudi/pull/3844
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3580: [HUDI-1869] Upgrading Spark3 To 3.1
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3580:
URL: https://github.com/apache/hudi/pull/3580#issuecomment-910182373
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "030cffd68dfda49994096cf82a0090185ced2581",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1975",
"triggerID" : "030cffd68dfda49994096cf82a0090185ced2581",
"triggerType" : "PUSH"
}, {
"hash" : "cb2e9d52f62a2e75f6330d44b89bac16d8b6a9c3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cb2e9d52f62a2e75f6330d44b89bac16d8b6a9c3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 030cffd68dfda49994096cf82a0090185ced2581 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1975)
* cb2e9d52f62a2e75f6330d44b89bac16d8b6a9c3 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan commented on a change in pull request #3580: [HUDI-1869] Upgrading Spark3 To 3.1
Posted by GitBox <gi...@apache.org>.
xushiyan commented on a change in pull request #3580:
URL: https://github.com/apache/hudi/pull/3580#discussion_r706777459
##########
File path: pom.xml
##########
@@ -1486,6 +1487,16 @@
</activation>
</profile>
+ <profile>
+ <id>isSpark3.0</id>
+<!-- for spark 3.0.x we need override the follow propeprties to package and run test-->
+ <properties>
+ <spark3.version>3.0.0</spark3.version>
+ <spark.version>${spark3.version}</spark.version>
+ <scalatest.version>3.0.1</scalatest.version>
+ </properties>
+ </profile>
Review comment:
instead of a boolean flag, better be explicit about spark version and have a maven profile match to it. we can name the profile `-Dspark3.0` just for 3.0.x and keep `-Dspark3` points to the latest supported Spark 3 release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] novakov-alexey commented on pull request #3580: [HUDI-1869] Upgrading Spark3 To 3.1
Posted by GitBox <gi...@apache.org>.
novakov-alexey commented on pull request #3580:
URL: https://github.com/apache/hudi/pull/3580#issuecomment-949802449
@pengzhiwei2018 do you want to upgrade us to Spark 3.2 with Scala 2.13 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan closed pull request #3580: [HUDI-1869] Upgrading Spark3 To 3.1
Posted by GitBox <gi...@apache.org>.
xushiyan closed pull request #3580:
URL: https://github.com/apache/hudi/pull/3580
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar commented on a change in pull request #3580: [HUDI-1869] Upgrading Spark3 To 3.1
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on a change in pull request #3580:
URL: https://github.com/apache/hudi/pull/3580#discussion_r703906934
##########
File path: pom.xml
##########
@@ -112,7 +112,7 @@
<sparkbundle.version>${spark2bundle.version}</sparkbundle.version>
<flink.version>1.13.1</flink.version>
<spark2.version>2.4.4</spark2.version>
- <spark3.version>3.0.0</spark3.version>
+ <spark3.version>3.1.0</spark3.version>
Review comment:
there is a 3.1.2 now as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] pan3793 commented on a change in pull request #3580: [HUDI-1869] Upgrading Spark3 To 3.1
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #3580:
URL: https://github.com/apache/hudi/pull/3580#discussion_r702537649
##########
File path: pom.xml
##########
@@ -112,7 +112,7 @@
<sparkbundle.version>${spark2bundle.version}</sparkbundle.version>
<flink.version>1.13.1</flink.version>
<spark2.version>2.4.4</spark2.version>
- <spark3.version>3.0.0</spark3.version>
+ <spark3.version>3.1.0</spark3.version>
Review comment:
Spark 3.1.0 is broken, the minimal 3.1.x version is 3.1.1 https://spark.apache.org/news/next-official-release-spark-3.1.1.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3580: [HUDI-1869] Upgrading Spark3 To 3.1
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3580:
URL: https://github.com/apache/hudi/pull/3580#issuecomment-910182373
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "030cffd68dfda49994096cf82a0090185ced2581",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1975",
"triggerID" : "030cffd68dfda49994096cf82a0090185ced2581",
"triggerType" : "PUSH"
}, {
"hash" : "cb2e9d52f62a2e75f6330d44b89bac16d8b6a9c3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1980",
"triggerID" : "cb2e9d52f62a2e75f6330d44b89bac16d8b6a9c3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cb2e9d52f62a2e75f6330d44b89bac16d8b6a9c3 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1980)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] pengzhiwei2018 commented on pull request #3580: [HUDI-1869] Upgrading Spark3 To 3.1
Posted by GitBox <gi...@apache.org>.
pengzhiwei2018 commented on pull request #3580:
URL: https://github.com/apache/hudi/pull/3580#issuecomment-911631533
> > > spark 3.0.x will not supported as spark 3.1 has many changes to the class interface.
> >
> >
> > this is just crazy how badly it breaks across minor versions
>
> If we want to both support spark 3.0 and spark 3.1, maybe way need another build config to specify the spark version.
Hi @vinothchandar , I have support both spark3.0 and spark3.1. Please take a review again~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3580: [HUDI-1869] Upgrading Spark3 To 3.1
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3580:
URL: https://github.com/apache/hudi/pull/3580#issuecomment-910182373
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "030cffd68dfda49994096cf82a0090185ced2581",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1975",
"triggerID" : "030cffd68dfda49994096cf82a0090185ced2581",
"triggerType" : "PUSH"
}, {
"hash" : "cb2e9d52f62a2e75f6330d44b89bac16d8b6a9c3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1980",
"triggerID" : "cb2e9d52f62a2e75f6330d44b89bac16d8b6a9c3",
"triggerType" : "PUSH"
}, {
"hash" : "cb5cfb39017db2f09ce5c5fc8d0af5e2a35b92eb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cb5cfb39017db2f09ce5c5fc8d0af5e2a35b92eb",
"triggerType" : "PUSH"
}, {
"hash" : "b418e2b13f4c4bbb9b9ba87059abc66d303cc1b0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1989",
"triggerID" : "b418e2b13f4c4bbb9b9ba87059abc66d303cc1b0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cb2e9d52f62a2e75f6330d44b89bac16d8b6a9c3 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1980)
* cb5cfb39017db2f09ce5c5fc8d0af5e2a35b92eb UNKNOWN
* b418e2b13f4c4bbb9b9ba87059abc66d303cc1b0 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1989)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] novakov-alexey commented on pull request #3580: [HUDI-1869] Upgrading Spark3 To 3.1
Posted by GitBox <gi...@apache.org>.
novakov-alexey commented on pull request #3580:
URL: https://github.com/apache/hudi/pull/3580#issuecomment-950330007
@xushiyan Does it make sense to upgrade Hudi straight to Spark 3.2 and extend #3844 for 3.2 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3580: [HUDI-1869] Upgrading Spark3 To 3.1
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3580:
URL: https://github.com/apache/hudi/pull/3580#issuecomment-910182373
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "030cffd68dfda49994096cf82a0090185ced2581",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1975",
"triggerID" : "030cffd68dfda49994096cf82a0090185ced2581",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 030cffd68dfda49994096cf82a0090185ced2581 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1975)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] melin commented on pull request #3580: [HUDI-1869] Upgrading Spark3 To 3.1
Posted by GitBox <gi...@apache.org>.
melin commented on pull request #3580:
URL: https://github.com/apache/hudi/pull/3580#issuecomment-911319873
spark 3.1.2
```
spark-sql> select * from test_hudi_table;
162943 [Executor task launch worker for task 0.0 in stage 32.0 (TID 1812)] ERROR org.apache.spark.executor.Executor - Exception in task 0.0 in stage 32.0 (TID 1812)
java.lang.ClassCastException: scala.Some cannot be cast to org.apache.spark.sql.catalyst.InternalRow
at org.apache.spark.sql.hudi.HoodieMergeOnReadRDD$$anon$3.hasNext(HoodieMergeOnReadRDD.scala:240)
at org.apache.spark.sql.catalyst.expressions.GeneratedClass$GeneratedIteratorForCodegenStage1.processNext(Unknown Source)
at org.apache.spark.sql.execution.BufferedRowIterator.hasNext(BufferedRowIterator.java:43)
at org.apache.spark.sql.execution.WholeStageCodegenExec$$anon$1.hasNext(WholeStageCodegenExec.scala:755)
at org.apache.spark.sql.execution.SparkPlan.$anonfun$getByteArrayRdd$1(SparkPlan.scala:345)
at org.apache.spark.rdd.RDD.$anonfun$mapPartitionsInternal$2(RDD.scala:898)
at org.apache.spark.rdd.RDD.$anonfun$mapPartitionsInternal$2$adapted(RDD.scala:898)
at org.apache.spark.rdd.MapPartitionsRDD.compute(MapPartitionsRDD.scala:52)
at org.apache.spark.rdd.RDD.computeOrReadCheckpoint(RDD.scala:373)
at org.apache.spark.rdd.RDD.iterator(RDD.scala:337)
at org.apache.spark.scheduler.ResultTask.runTask(ResultTask.scala:90)
at org.apache.spark.scheduler.Task.run(Task.scala:131)
at org.apache.spark.executor.Executor$TaskRunner.$anonfun$run$3(Executor.scala:498)
at org.apache.spark.util.Utils$.tryWithSafeFinally(Utils.scala:1439)
at org.apache.spark.executor.Executor$TaskRunner.run(Executor.scala:501)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar commented on pull request #3580: [HUDI-1869] Upgrading Spark3 To 3.1
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on pull request #3580:
URL: https://github.com/apache/hudi/pull/3580#issuecomment-914679152
Will review this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] pan3793 commented on a change in pull request #3580: [HUDI-1869] Upgrading Spark3 To 3.1
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #3580:
URL: https://github.com/apache/hudi/pull/3580#discussion_r703972302
##########
File path: pom.xml
##########
@@ -112,7 +112,7 @@
<sparkbundle.version>${spark2bundle.version}</sparkbundle.version>
<flink.version>1.13.1</flink.version>
<spark2.version>2.4.4</spark2.version>
- <spark3.version>3.0.0</spark3.version>
+ <spark3.version>3.1.0</spark3.version>
Review comment:
I would suggest always use the latest patched version, for this case, Spark 2.4.8, 3.0.3, 3.1.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3580: [HUDI-1869] Upgrading Spark3 To 3.1
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3580:
URL: https://github.com/apache/hudi/pull/3580#issuecomment-910182373
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "030cffd68dfda49994096cf82a0090185ced2581",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1975",
"triggerID" : "030cffd68dfda49994096cf82a0090185ced2581",
"triggerType" : "PUSH"
}, {
"hash" : "cb2e9d52f62a2e75f6330d44b89bac16d8b6a9c3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1980",
"triggerID" : "cb2e9d52f62a2e75f6330d44b89bac16d8b6a9c3",
"triggerType" : "PUSH"
}, {
"hash" : "cb5cfb39017db2f09ce5c5fc8d0af5e2a35b92eb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cb5cfb39017db2f09ce5c5fc8d0af5e2a35b92eb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cb2e9d52f62a2e75f6330d44b89bac16d8b6a9c3 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1980)
* cb5cfb39017db2f09ce5c5fc8d0af5e2a35b92eb UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] pan3793 commented on a change in pull request #3580: [HUDI-1869] Upgrading Spark3 To 3.1
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #3580:
URL: https://github.com/apache/hudi/pull/3580#discussion_r702537956
##########
File path: pom.xml
##########
@@ -112,7 +112,7 @@
<sparkbundle.version>${spark2bundle.version}</sparkbundle.version>
<flink.version>1.13.1</flink.version>
<spark2.version>2.4.4</spark2.version>
- <spark3.version>3.0.0</spark3.version>
+ <spark3.version>3.1.0</spark3.version>
Review comment:
BTW, any reason not to use the latest patch version?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3580: [HUDI-1869] Upgrading Spark3 To 3.1
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3580:
URL: https://github.com/apache/hudi/pull/3580#issuecomment-910182373
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "030cffd68dfda49994096cf82a0090185ced2581",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1975",
"triggerID" : "030cffd68dfda49994096cf82a0090185ced2581",
"triggerType" : "PUSH"
}, {
"hash" : "cb2e9d52f62a2e75f6330d44b89bac16d8b6a9c3",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1980",
"triggerID" : "cb2e9d52f62a2e75f6330d44b89bac16d8b6a9c3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 030cffd68dfda49994096cf82a0090185ced2581 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1975)
* cb2e9d52f62a2e75f6330d44b89bac16d8b6a9c3 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1980)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan commented on a change in pull request #3580: [HUDI-1869] Upgrading Spark3 To 3.1
Posted by GitBox <gi...@apache.org>.
xushiyan commented on a change in pull request #3580:
URL: https://github.com/apache/hudi/pull/3580#discussion_r706777459
##########
File path: pom.xml
##########
@@ -1486,6 +1487,16 @@
</activation>
</profile>
+ <profile>
+ <id>isSpark3.0</id>
+<!-- for spark 3.0.x we need override the follow propeprties to package and run test-->
+ <properties>
+ <spark3.version>3.0.0</spark3.version>
+ <spark.version>${spark3.version}</spark.version>
+ <scalatest.version>3.0.1</scalatest.version>
+ </properties>
+ </profile>
Review comment:
instead of a boolean flag, better be explicit about spark version and have a maven profile match to it. we can name the profile `-Dspark3.0.x` just for 3.0.x and keep `-Dspark3` points to the latest supported Spark 3 release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] melin edited a comment on pull request #3580: [HUDI-1869] Upgrading Spark3 To 3.1
Posted by GitBox <gi...@apache.org>.
melin edited a comment on pull request #3580:
URL: https://github.com/apache/hudi/pull/3580#issuecomment-911319873
spark 3.1.2
```
spark-sql> select * from test_hudi_table;
162943 [Executor task launch worker for task 0.0 in stage 32.0 (TID 1812)] ERROR org.apache.spark.executor.Executor - Exception in task 0.0 in stage 32.0 (TID 1812)
java.lang.ClassCastException: scala.Some cannot be cast to org.apache.spark.sql.catalyst.InternalRow
at org.apache.spark.sql.hudi.HoodieMergeOnReadRDD$$anon$3.hasNext(HoodieMergeOnReadRDD.scala:240)
at org.apache.spark.sql.catalyst.expressions.GeneratedClass$GeneratedIteratorForCodegenStage1.processNext(Unknown Source)
at org.apache.spark.sql.execution.BufferedRowIterator.hasNext(BufferedRowIterator.java:43)
at org.apache.spark.sql.execution.WholeStageCodegenExec$$anon$1.hasNext(WholeStageCodegenExec.scala:755)
at org.apache.spark.sql.execution.SparkPlan.$anonfun$getByteArrayRdd$1(SparkPlan.scala:345)
at org.apache.spark.rdd.RDD.$anonfun$mapPartitionsInternal$2(RDD.scala:898)
at org.apache.spark.rdd.RDD.$anonfun$mapPartitionsInternal$2$adapted(RDD.scala:898)
at org.apache.spark.rdd.MapPartitionsRDD.compute(MapPartitionsRDD.scala:52)
at org.apache.spark.rdd.RDD.computeOrReadCheckpoint(RDD.scala:373)
at org.apache.spark.rdd.RDD.iterator(RDD.scala:337)
at org.apache.spark.scheduler.ResultTask.runTask(ResultTask.scala:90)
at org.apache.spark.scheduler.Task.run(Task.scala:131)
at org.apache.spark.executor.Executor$TaskRunner.$anonfun$run$3(Executor.scala:498)
at org.apache.spark.util.Utils$.tryWithSafeFinally(Utils.scala:1439)
at org.apache.spark.executor.Executor$TaskRunner.run(Executor.scala:501)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
```
Do you test use this PR? I think this PR has solved this exception by introduce the `HooodieAvroDeserializer` to match the `Option` result return by spark 3.1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] pengzhiwei2018 commented on a change in pull request #3580: [HUDI-1869] Upgrading Spark3 To 3.1
Posted by GitBox <gi...@apache.org>.
pengzhiwei2018 commented on a change in pull request #3580:
URL: https://github.com/apache/hudi/pull/3580#discussion_r705434471
##########
File path: pom.xml
##########
@@ -112,7 +112,7 @@
<sparkbundle.version>${spark2bundle.version}</sparkbundle.version>
<flink.version>1.13.1</flink.version>
<spark2.version>2.4.4</spark2.version>
- <spark3.version>3.0.0</spark3.version>
+ <spark3.version>3.1.0</spark3.version>
Review comment:
Make sense to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3580: [HUDI-1869] Upgrading Spark3 To 3.1
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3580:
URL: https://github.com/apache/hudi/pull/3580#issuecomment-910182373
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "030cffd68dfda49994096cf82a0090185ced2581",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1975",
"triggerID" : "030cffd68dfda49994096cf82a0090185ced2581",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 030cffd68dfda49994096cf82a0090185ced2581 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1975)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] melin removed a comment on pull request #3580: [HUDI-1869] Upgrading Spark3 To 3.1
Posted by GitBox <gi...@apache.org>.
melin removed a comment on pull request #3580:
URL: https://github.com/apache/hudi/pull/3580#issuecomment-911319873
spark 3.1.2
```
spark-sql> select * from test_hudi_table;
162943 [Executor task launch worker for task 0.0 in stage 32.0 (TID 1812)] ERROR org.apache.spark.executor.Executor - Exception in task 0.0 in stage 32.0 (TID 1812)
java.lang.ClassCastException: scala.Some cannot be cast to org.apache.spark.sql.catalyst.InternalRow
at org.apache.spark.sql.hudi.HoodieMergeOnReadRDD$$anon$3.hasNext(HoodieMergeOnReadRDD.scala:240)
at org.apache.spark.sql.catalyst.expressions.GeneratedClass$GeneratedIteratorForCodegenStage1.processNext(Unknown Source)
at org.apache.spark.sql.execution.BufferedRowIterator.hasNext(BufferedRowIterator.java:43)
at org.apache.spark.sql.execution.WholeStageCodegenExec$$anon$1.hasNext(WholeStageCodegenExec.scala:755)
at org.apache.spark.sql.execution.SparkPlan.$anonfun$getByteArrayRdd$1(SparkPlan.scala:345)
at org.apache.spark.rdd.RDD.$anonfun$mapPartitionsInternal$2(RDD.scala:898)
at org.apache.spark.rdd.RDD.$anonfun$mapPartitionsInternal$2$adapted(RDD.scala:898)
at org.apache.spark.rdd.MapPartitionsRDD.compute(MapPartitionsRDD.scala:52)
at org.apache.spark.rdd.RDD.computeOrReadCheckpoint(RDD.scala:373)
at org.apache.spark.rdd.RDD.iterator(RDD.scala:337)
at org.apache.spark.scheduler.ResultTask.runTask(ResultTask.scala:90)
at org.apache.spark.scheduler.Task.run(Task.scala:131)
at org.apache.spark.executor.Executor$TaskRunner.$anonfun$run$3(Executor.scala:498)
at org.apache.spark.util.Utils$.tryWithSafeFinally(Utils.scala:1439)
at org.apache.spark.executor.Executor$TaskRunner.run(Executor.scala:501)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
```
Do you test use this PR? I think this PR has solved this exception by introduce the `HooodieAvroDeserializer` to match the `Option` result return by spark 3.1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] pengzhiwei2018 commented on pull request #3580: [HUDI-1869] Upgrading Spark3 To 3.1
Posted by GitBox <gi...@apache.org>.
pengzhiwei2018 commented on pull request #3580:
URL: https://github.com/apache/hudi/pull/3580#issuecomment-911052610
> > spark 3.0.x will not supported as spark 3.1 has many changes to the class interface.
>
> this is just crazy how badly it breaks across minor versions
If we want to both support spark 3.0 and spark 3.1, maybe way need another build config to specify the spark version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org