You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2023/04/18 23:21:49 UTC

[GitHub] [arrow] kou commented on a diff in pull request #35225: WIP: DO NOT MERGE: Test Windows verification failures

kou commented on code in PR #35225:
URL: https://github.com/apache/arrow/pull/35225#discussion_r1170658489


##########
dev/release/verify-release-candidate.bat:
##########
@@ -112,6 +112,8 @@ cmake -G "%GENERATOR%" ^
       -DARROW_WITH_ZSTD=ON ^
       -DCMAKE_BUILD_TYPE=%CONFIGURATION% ^
       -DCMAKE_INSTALL_PREFIX=%ARROW_HOME% ^
+      -DCMAKE_PREFIX_PATH=%CONDA_PREFIX%\Lib ^

Review Comment:
   I think that we don't need to append `\Lib` for `CMAKE_PREFIX_PATH`:
   
   ```suggestion
         -DCMAKE_PREFIX_PATH=%CONDA_PREFIX% ^
   ```
   
   https://cmake.org/cmake/help/latest/variable/CMAKE_PREFIX_PATH.html
   
   > Each command will add appropriate subdirectories (like `bin`, `lib`, or `include`) as specified in its own documentation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org