[GitHub] [incubator-apisix-dashboard] membphis commented on a change in pull request #65: enhance: can choose chash keys from drop down list

[GitBox <gi...@apache.org>]

membphis commented on a change in pull request #65: enhance: can choose chash keys from drop down list
URL: https://github.com/apache/incubator-apisix-dashboard/pull/65#discussion_r342350099
 
 

 ##########
 File path: src/views/schema/upstream/edit.vue
 ##########
 @@ -155,6 +167,49 @@ export default class extends Vue {
 
   private types = ['roundrobin', 'chash']
 
+  private defaultHashKeys = [
+    {
+      value: 'remote_addr',
+      label: 'remote_addr'
+    },
+    {
+      value: 'host',
+      label: 'host'
+    },
+    {
+      value: 'uri',
+      label: 'uri'
+    },
+    {
+      value: 'server_name',
+      label: 'server_name'
+    },
+    {
+      value: 'server_addr',
+      label: 'server_addr'
+    },
+    {
+      value: 'request_uri',
+      label: 'request_uri'
+    },
+    {
+      value: 'query_string',
+      label: 'query_string'
+    },
+    {
+      value: 'remote_port',
+      label: 'remote_port'
+    },
+    {
+      value: 'hostname',
+      label: 'hostname'
+    },
+    {
+      value: 'arg_id',
 
 Review comment:
   `arg_id` is wrong, here is the Nginx variable index: http://nginx.org/en/docs/http/ngx_http_core_module.html#var_arg_
   
   `arg_name`: argument name in the request line, the value of the name here is not fixed, eg: `arg_id`, `arg_name`, `arg_age`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services