You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Till Toenshoff <to...@me.com> on 2015/06/18 00:35:46 UTC

Review Request 35583: Updated slave to exit on authentication failures.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35583/
-----------------------------------------------------------

Review request for mesos and Vinod Kone.


Bugs: MESOS-2464
    https://issues.apache.org/jira/browse/MESOS-2464


Repository: mesos-incubating


Description
-------

see summary.


Diffs
-----

  src/slave/slave.cpp a5ad29f 

Diff: https://reviews.apache.org/r/35583/diff/


Testing
-------

make check


Thanks,

Till Toenshoff


Re: Review Request 35583: Updated slave to exit on authentication refusal.

Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35583/#review88641
-----------------------------------------------------------

Ship it!


Ship It!

- Alexander Rukletsov


On June 17, 2015, 10:42 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35583/
> -----------------------------------------------------------
> 
> (Updated June 17, 2015, 10:42 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-2464
>     https://issues.apache.org/jira/browse/MESOS-2464
> 
> 
> Repository: mesos-incubating
> 
> 
> Description
> -------
> 
> see summary.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp a5ad29f 
> 
> Diff: https://reviews.apache.org/r/35583/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Re: Review Request 35583: Updated slave to exit on authentication refusal.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35583/#review88322
-----------------------------------------------------------


Patch looks great!

Reviews applied: [35583]

All tests passed.

- Mesos ReviewBot


On June 17, 2015, 10:42 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35583/
> -----------------------------------------------------------
> 
> (Updated June 17, 2015, 10:42 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-2464
>     https://issues.apache.org/jira/browse/MESOS-2464
> 
> 
> Repository: mesos-incubating
> 
> 
> Description
> -------
> 
> see summary.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp a5ad29f 
> 
> Diff: https://reviews.apache.org/r/35583/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Re: Review Request 35583: Updated slave to exit on authentication refusal.

Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35583/#review88637
-----------------------------------------------------------

Ship it!


Ship It!

- Adam B


On June 17, 2015, 3:42 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35583/
> -----------------------------------------------------------
> 
> (Updated June 17, 2015, 3:42 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-2464
>     https://issues.apache.org/jira/browse/MESOS-2464
> 
> 
> Repository: mesos-incubating
> 
> 
> Description
> -------
> 
> see summary.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp a5ad29f 
> 
> Diff: https://reviews.apache.org/r/35583/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Re: Review Request 35583: Updated slave to exit on authentication refusal.

Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35583/
-----------------------------------------------------------

(Updated June 17, 2015, 10:42 p.m.)


Review request for mesos and Vinod Kone.


Summary (updated)
-----------------

Updated slave to exit on authentication refusal. 


Bugs: MESOS-2464
    https://issues.apache.org/jira/browse/MESOS-2464


Repository: mesos-incubating


Description
-------

see summary.


Diffs
-----

  src/slave/slave.cpp a5ad29f 

Diff: https://reviews.apache.org/r/35583/diff/


Testing
-------

make check


Thanks,

Till Toenshoff