You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Jayapal Reddy <ja...@citrix.com> on 2013/01/17 16:36:01 UTC
Review Request: CLOUDSTACK-299 Egress firewall rules feature for guest
network on VR
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9010/
-----------------------------------------------------------
Review request for cloudstack, Abhinandan Prateek and Animesh Chaturvedi.
Description
-------
Egress firewall rules feature for the guest networks.
The current changes includes for the VR only.
This addresses bug CLOUDSTACK-299.
Diffs
-----
api/src/com/cloud/agent/api/to/FirewallRuleTO.java 95ac57c
api/src/com/cloud/network/Network.java c91f6a9
api/src/com/cloud/network/NetworkProfile.java b5c463d
api/src/com/cloud/network/firewall/FirewallService.java 3858499
api/src/org/apache/cloudstack/api/command/user/firewall/CreateEgressFirewallRuleCmd.java PRE-CREATION
api/src/org/apache/cloudstack/api/command/user/firewall/CreateFirewallRuleCmd.java 0dcba5f
api/src/org/apache/cloudstack/api/command/user/firewall/CreatePortForwardingRuleCmd.java 7d8dbb0
api/src/org/apache/cloudstack/api/command/user/firewall/DeleteEgressFirewallRuleCmd.java PRE-CREATION
api/src/org/apache/cloudstack/api/command/user/firewall/ListEgressFirewallRulesCmd.java PRE-CREATION
api/src/org/apache/cloudstack/api/command/user/firewall/ListFirewallRulesCmd.java 80581fb
api/src/org/apache/cloudstack/api/command/user/loadbalancer/CreateLoadBalancerRuleCmd.java b42ff4c
api/src/org/apache/cloudstack/api/command/user/nat/CreateIpForwardingRuleCmd.java c3894c4
api/src/org/apache/cloudstack/api/response/FirewallResponse.java 2799256
client/tomcatconf/commands.properties.in 182cbd8
core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java 2dc7950
patches/systemvm/debian/config/etc/iptables/iptables-router 28469fb
patches/systemvm/debian/config/opt/cloud/bin/ipassoc.sh 5af5d92
patches/systemvm/debian/config/root/firewallRule_egress.sh PRE-CREATION
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java a444cfe
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 065d3be
plugins/network-elements/juniper-srx/src/com/cloud/network/element/JuniperSRXExternalFirewallElement.java ead2af9
scripts/network/domr/call_firewall.sh 08da341
server/src/com/cloud/api/ApiResponseHelper.java c346a6b
server/src/com/cloud/network/NetworkManagerImpl.java 0a1fcd7
server/src/com/cloud/network/dao/FirewallRulesDao.java cc184c8
server/src/com/cloud/network/dao/FirewallRulesDaoImpl.java 2fff15a
server/src/com/cloud/network/element/VirtualRouterElement.java 02a239e
server/src/com/cloud/network/firewall/FirewallManagerImpl.java 340e872
server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java 9b48f2c
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 717da05
server/src/com/cloud/network/rules/FirewallManager.java 8473c56
server/src/com/cloud/network/rules/FirewallRuleVO.java 63ace5b
server/src/com/cloud/network/rules/RulesManagerImpl.java a75aca3
server/src/com/cloud/network/vpn/RemoteAccessVpnManagerImpl.java 67d6b8c
server/src/com/cloud/upgrade/dao/Upgrade40to41.java cd9e20c
utils/conf/db.properties 18bf54c
Diff: https://reviews.apache.org/r/9010/diff/
Testing
-------
Unit testing:
1. Created egress rule for tcp port 22 from cloudstack UI.
2. After adding the rule it allows tcp port 22 traffic.
3. Remaining traffic got blocked.
Thanks,
Jayapal Reddy
Re: Review Request: CLOUDSTACK-299 Egress firewall rules feature for guest
network on VR
Posted by Jayapal Reddy <ja...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9010/
-----------------------------------------------------------
(Updated Jan. 31, 2013, 4:59 a.m.)
Review request for cloudstack, Abhinandan Prateek and Animesh Chaturvedi.
Changes
-------
In this patch resolved the errors on patch apply on master.
Description
-------
Egress firewall rules feature for the guest networks.
The current changes includes for the VR only.
This addresses bug CLOUDSTACK-299.
Diffs (updated)
-----
api/src/com/cloud/agent/api/to/FirewallRuleTO.java 95ac57c
api/src/com/cloud/network/Network.java c91f6a9
api/src/com/cloud/network/NetworkProfile.java b5c463d
api/src/com/cloud/network/firewall/FirewallService.java 3858499
api/src/org/apache/cloudstack/api/command/user/firewall/CreateEgressFirewallRuleCmd.java PRE-CREATION
api/src/org/apache/cloudstack/api/command/user/firewall/CreateFirewallRuleCmd.java 0dcba5f
api/src/org/apache/cloudstack/api/command/user/firewall/CreatePortForwardingRuleCmd.java 7d8dbb0
api/src/org/apache/cloudstack/api/command/user/firewall/DeleteEgressFirewallRuleCmd.java PRE-CREATION
api/src/org/apache/cloudstack/api/command/user/firewall/ListEgressFirewallRulesCmd.java PRE-CREATION
api/src/org/apache/cloudstack/api/command/user/firewall/ListFirewallRulesCmd.java 80581fb
api/src/org/apache/cloudstack/api/command/user/loadbalancer/CreateLoadBalancerRuleCmd.java b42ff4c
api/src/org/apache/cloudstack/api/command/user/nat/CreateIpForwardingRuleCmd.java c3894c4
api/src/org/apache/cloudstack/api/response/FirewallResponse.java 2799256
client/tomcatconf/commands.properties.in 3740fb0
core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java 18a0426
patches/systemvm/debian/config/etc/iptables/iptables-router 28469fb
patches/systemvm/debian/config/opt/cloud/bin/ipassoc.sh 5af5d92
patches/systemvm/debian/config/root/firewallRule_egress.sh PRE-CREATION
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java dd917f7
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 065d3be
plugins/network-elements/juniper-srx/src/com/cloud/network/element/JuniperSRXExternalFirewallElement.java 5038cc8
scripts/network/domr/call_firewall.sh 08da341
server/src/com/cloud/api/ApiResponseHelper.java 1c8849a
server/src/com/cloud/network/NetworkManagerImpl.java bb60dcf
server/src/com/cloud/network/dao/FirewallRulesDao.java cc184c8
server/src/com/cloud/network/dao/FirewallRulesDaoImpl.java 2fff15a
server/src/com/cloud/network/element/VirtualRouterElement.java 2b54ae0
server/src/com/cloud/network/firewall/FirewallManagerImpl.java 7bab1ba
server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java dfd5232
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java e1c78e1
server/src/com/cloud/network/rules/FirewallManager.java 8473c56
server/src/com/cloud/network/rules/FirewallRuleVO.java 63ace5b
server/src/com/cloud/network/rules/RulesManagerImpl.java fc12660
server/src/com/cloud/network/vpn/RemoteAccessVpnManagerImpl.java 81721ea
server/src/com/cloud/upgrade/dao/Upgrade40to41.java cd9e20c
server/test/com/cloud/network/MockFirewallManagerImpl.java 1a79acf
Diff: https://reviews.apache.org/r/9010/diff/
Testing
-------
Unit testing:
1. Created egress rule for tcp port 22 from cloudstack UI.
2. After adding the rule it allows tcp port 22 traffic.
3. Remaining traffic got blocked.
Thanks,
Jayapal Reddy
Re: Review Request: CLOUDSTACK-299 Egress firewall rules feature for guest
network on VR
Posted by Abhinandan Prateek <ap...@apache.org>.
> On Jan. 30, 2013, 8:04 a.m., Abhinandan Prateek wrote:
> > Ship It!
Unit tests are missing.
- Abhinandan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9010/#review15829
-----------------------------------------------------------
On Jan. 17, 2013, 3:35 p.m., Jayapal Reddy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9010/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2013, 3:35 p.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Animesh Chaturvedi.
>
>
> Description
> -------
>
> Egress firewall rules feature for the guest networks.
> The current changes includes for the VR only.
>
>
> This addresses bug CLOUDSTACK-299.
>
>
> Diffs
> -----
>
> api/src/com/cloud/agent/api/to/FirewallRuleTO.java 95ac57c
> api/src/com/cloud/network/Network.java c91f6a9
> api/src/com/cloud/network/NetworkProfile.java b5c463d
> api/src/com/cloud/network/firewall/FirewallService.java 3858499
> api/src/org/apache/cloudstack/api/command/user/firewall/CreateEgressFirewallRuleCmd.java PRE-CREATION
> api/src/org/apache/cloudstack/api/command/user/firewall/CreateFirewallRuleCmd.java 0dcba5f
> api/src/org/apache/cloudstack/api/command/user/firewall/CreatePortForwardingRuleCmd.java 7d8dbb0
> api/src/org/apache/cloudstack/api/command/user/firewall/DeleteEgressFirewallRuleCmd.java PRE-CREATION
> api/src/org/apache/cloudstack/api/command/user/firewall/ListEgressFirewallRulesCmd.java PRE-CREATION
> api/src/org/apache/cloudstack/api/command/user/firewall/ListFirewallRulesCmd.java 80581fb
> api/src/org/apache/cloudstack/api/command/user/loadbalancer/CreateLoadBalancerRuleCmd.java b42ff4c
> api/src/org/apache/cloudstack/api/command/user/nat/CreateIpForwardingRuleCmd.java c3894c4
> api/src/org/apache/cloudstack/api/response/FirewallResponse.java 2799256
> client/tomcatconf/commands.properties.in 182cbd8
> core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java 2dc7950
> patches/systemvm/debian/config/etc/iptables/iptables-router 28469fb
> patches/systemvm/debian/config/opt/cloud/bin/ipassoc.sh 5af5d92
> patches/systemvm/debian/config/root/firewallRule_egress.sh PRE-CREATION
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java a444cfe
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 065d3be
> plugins/network-elements/juniper-srx/src/com/cloud/network/element/JuniperSRXExternalFirewallElement.java ead2af9
> scripts/network/domr/call_firewall.sh 08da341
> server/src/com/cloud/api/ApiResponseHelper.java c346a6b
> server/src/com/cloud/network/NetworkManagerImpl.java 0a1fcd7
> server/src/com/cloud/network/dao/FirewallRulesDao.java cc184c8
> server/src/com/cloud/network/dao/FirewallRulesDaoImpl.java 2fff15a
> server/src/com/cloud/network/element/VirtualRouterElement.java 02a239e
> server/src/com/cloud/network/firewall/FirewallManagerImpl.java 340e872
> server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java 9b48f2c
> server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 717da05
> server/src/com/cloud/network/rules/FirewallManager.java 8473c56
> server/src/com/cloud/network/rules/FirewallRuleVO.java 63ace5b
> server/src/com/cloud/network/rules/RulesManagerImpl.java a75aca3
> server/src/com/cloud/network/vpn/RemoteAccessVpnManagerImpl.java 67d6b8c
> server/src/com/cloud/upgrade/dao/Upgrade40to41.java cd9e20c
> utils/conf/db.properties 18bf54c
>
> Diff: https://reviews.apache.org/r/9010/diff/
>
>
> Testing
> -------
>
> Unit testing:
> 1. Created egress rule for tcp port 22 from cloudstack UI.
> 2. After adding the rule it allows tcp port 22 traffic.
> 3. Remaining traffic got blocked.
>
>
> Thanks,
>
> Jayapal Reddy
>
>
Re: Review Request: CLOUDSTACK-299 Egress firewall rules feature for guest
network on VR
Posted by Abhinandan Prateek <ap...@apache.org>.
> On Jan. 30, 2013, 8:04 a.m., Abhinandan Prateek wrote:
> > Ship It!
>
> Abhinandan Prateek wrote:
> Unit tests are missing.
>
Merge conflicts, please, merge and send a new patch.
- Abhinandan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9010/#review15829
-----------------------------------------------------------
On Jan. 17, 2013, 3:35 p.m., Jayapal Reddy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9010/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2013, 3:35 p.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Animesh Chaturvedi.
>
>
> Description
> -------
>
> Egress firewall rules feature for the guest networks.
> The current changes includes for the VR only.
>
>
> This addresses bug CLOUDSTACK-299.
>
>
> Diffs
> -----
>
> api/src/com/cloud/agent/api/to/FirewallRuleTO.java 95ac57c
> api/src/com/cloud/network/Network.java c91f6a9
> api/src/com/cloud/network/NetworkProfile.java b5c463d
> api/src/com/cloud/network/firewall/FirewallService.java 3858499
> api/src/org/apache/cloudstack/api/command/user/firewall/CreateEgressFirewallRuleCmd.java PRE-CREATION
> api/src/org/apache/cloudstack/api/command/user/firewall/CreateFirewallRuleCmd.java 0dcba5f
> api/src/org/apache/cloudstack/api/command/user/firewall/CreatePortForwardingRuleCmd.java 7d8dbb0
> api/src/org/apache/cloudstack/api/command/user/firewall/DeleteEgressFirewallRuleCmd.java PRE-CREATION
> api/src/org/apache/cloudstack/api/command/user/firewall/ListEgressFirewallRulesCmd.java PRE-CREATION
> api/src/org/apache/cloudstack/api/command/user/firewall/ListFirewallRulesCmd.java 80581fb
> api/src/org/apache/cloudstack/api/command/user/loadbalancer/CreateLoadBalancerRuleCmd.java b42ff4c
> api/src/org/apache/cloudstack/api/command/user/nat/CreateIpForwardingRuleCmd.java c3894c4
> api/src/org/apache/cloudstack/api/response/FirewallResponse.java 2799256
> client/tomcatconf/commands.properties.in 182cbd8
> core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java 2dc7950
> patches/systemvm/debian/config/etc/iptables/iptables-router 28469fb
> patches/systemvm/debian/config/opt/cloud/bin/ipassoc.sh 5af5d92
> patches/systemvm/debian/config/root/firewallRule_egress.sh PRE-CREATION
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java a444cfe
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 065d3be
> plugins/network-elements/juniper-srx/src/com/cloud/network/element/JuniperSRXExternalFirewallElement.java ead2af9
> scripts/network/domr/call_firewall.sh 08da341
> server/src/com/cloud/api/ApiResponseHelper.java c346a6b
> server/src/com/cloud/network/NetworkManagerImpl.java 0a1fcd7
> server/src/com/cloud/network/dao/FirewallRulesDao.java cc184c8
> server/src/com/cloud/network/dao/FirewallRulesDaoImpl.java 2fff15a
> server/src/com/cloud/network/element/VirtualRouterElement.java 02a239e
> server/src/com/cloud/network/firewall/FirewallManagerImpl.java 340e872
> server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java 9b48f2c
> server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 717da05
> server/src/com/cloud/network/rules/FirewallManager.java 8473c56
> server/src/com/cloud/network/rules/FirewallRuleVO.java 63ace5b
> server/src/com/cloud/network/rules/RulesManagerImpl.java a75aca3
> server/src/com/cloud/network/vpn/RemoteAccessVpnManagerImpl.java 67d6b8c
> server/src/com/cloud/upgrade/dao/Upgrade40to41.java cd9e20c
> utils/conf/db.properties 18bf54c
>
> Diff: https://reviews.apache.org/r/9010/diff/
>
>
> Testing
> -------
>
> Unit testing:
> 1. Created egress rule for tcp port 22 from cloudstack UI.
> 2. After adding the rule it allows tcp port 22 traffic.
> 3. Remaining traffic got blocked.
>
>
> Thanks,
>
> Jayapal Reddy
>
>
Re: Review Request: CLOUDSTACK-299 Egress firewall rules feature for guest
network on VR
Posted by Abhinandan Prateek <ap...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9010/#review15829
-----------------------------------------------------------
Ship it!
Ship It!
- Abhinandan Prateek
On Jan. 17, 2013, 3:35 p.m., Jayapal Reddy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9010/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2013, 3:35 p.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Animesh Chaturvedi.
>
>
> Description
> -------
>
> Egress firewall rules feature for the guest networks.
> The current changes includes for the VR only.
>
>
> This addresses bug CLOUDSTACK-299.
>
>
> Diffs
> -----
>
> api/src/com/cloud/agent/api/to/FirewallRuleTO.java 95ac57c
> api/src/com/cloud/network/Network.java c91f6a9
> api/src/com/cloud/network/NetworkProfile.java b5c463d
> api/src/com/cloud/network/firewall/FirewallService.java 3858499
> api/src/org/apache/cloudstack/api/command/user/firewall/CreateEgressFirewallRuleCmd.java PRE-CREATION
> api/src/org/apache/cloudstack/api/command/user/firewall/CreateFirewallRuleCmd.java 0dcba5f
> api/src/org/apache/cloudstack/api/command/user/firewall/CreatePortForwardingRuleCmd.java 7d8dbb0
> api/src/org/apache/cloudstack/api/command/user/firewall/DeleteEgressFirewallRuleCmd.java PRE-CREATION
> api/src/org/apache/cloudstack/api/command/user/firewall/ListEgressFirewallRulesCmd.java PRE-CREATION
> api/src/org/apache/cloudstack/api/command/user/firewall/ListFirewallRulesCmd.java 80581fb
> api/src/org/apache/cloudstack/api/command/user/loadbalancer/CreateLoadBalancerRuleCmd.java b42ff4c
> api/src/org/apache/cloudstack/api/command/user/nat/CreateIpForwardingRuleCmd.java c3894c4
> api/src/org/apache/cloudstack/api/response/FirewallResponse.java 2799256
> client/tomcatconf/commands.properties.in 182cbd8
> core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java 2dc7950
> patches/systemvm/debian/config/etc/iptables/iptables-router 28469fb
> patches/systemvm/debian/config/opt/cloud/bin/ipassoc.sh 5af5d92
> patches/systemvm/debian/config/root/firewallRule_egress.sh PRE-CREATION
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java a444cfe
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 065d3be
> plugins/network-elements/juniper-srx/src/com/cloud/network/element/JuniperSRXExternalFirewallElement.java ead2af9
> scripts/network/domr/call_firewall.sh 08da341
> server/src/com/cloud/api/ApiResponseHelper.java c346a6b
> server/src/com/cloud/network/NetworkManagerImpl.java 0a1fcd7
> server/src/com/cloud/network/dao/FirewallRulesDao.java cc184c8
> server/src/com/cloud/network/dao/FirewallRulesDaoImpl.java 2fff15a
> server/src/com/cloud/network/element/VirtualRouterElement.java 02a239e
> server/src/com/cloud/network/firewall/FirewallManagerImpl.java 340e872
> server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java 9b48f2c
> server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 717da05
> server/src/com/cloud/network/rules/FirewallManager.java 8473c56
> server/src/com/cloud/network/rules/FirewallRuleVO.java 63ace5b
> server/src/com/cloud/network/rules/RulesManagerImpl.java a75aca3
> server/src/com/cloud/network/vpn/RemoteAccessVpnManagerImpl.java 67d6b8c
> server/src/com/cloud/upgrade/dao/Upgrade40to41.java cd9e20c
> utils/conf/db.properties 18bf54c
>
> Diff: https://reviews.apache.org/r/9010/diff/
>
>
> Testing
> -------
>
> Unit testing:
> 1. Created egress rule for tcp port 22 from cloudstack UI.
> 2. After adding the rule it allows tcp port 22 traffic.
> 3. Remaining traffic got blocked.
>
>
> Thanks,
>
> Jayapal Reddy
>
>