[GitHub] moltzaum edited a comment on issue #2886: TO Golang: Small CRUDer change to allow interface use for a single method type

[GitBox <gi...@apache.org>]

moltzaum edited a comment on issue #2886: TO Golang: Small CRUDer change to allow interface use for a single method type
URL: https://github.com/apache/trafficcontrol/pull/2886#issuecomment-425269669
 
 
   I was trying to get something similar to that originally. I'm glad it doesn't use an interface, but I also wish it wasn't so long: `api.ReadHandler(api.ToReadFactory(example.GetTypeSingleton()))`
   Seems a little repetitive in my opinion.
   
   I was thinking about how it was a runtime error and thought it would be fine since it seems like a pretty hard thing to miss. It would be especially difficult to miss if api tests were associated with the endpoint, which is standard practice. Would you still reject the PR for this?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services