You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jeff Hodges (JIRA)" <ji...@apache.org> on 2010/01/15 21:52:54 UTC
[jira] Created: (CASSANDRA-706) final classes are so lame
final classes are so lame
-------------------------
Key: CASSANDRA-706
URL: https://issues.apache.org/jira/browse/CASSANDRA-706
Project: Cassandra
Issue Type: Improvement
Components: Core
Reporter: Jeff Hodges
Classes that are marked final are lame. We shouldn't have them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-706) final classes are so lame
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801155#action_12801155 ]
Hudson commented on CASSANDRA-706:
----------------------------------
Integrated in Cassandra #325 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/325/])
Remove 'final' from all class declarations. Patch by Jeff Hodges, reviewed by Gary Dusbabek.
> final classes are so lame
> -------------------------
>
> Key: CASSANDRA-706
> URL: https://issues.apache.org/jira/browse/CASSANDRA-706
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.9
> Reporter: Jeff Hodges
> Fix For: 0.9
>
> Attachments: 0001-removing-all-final-classes-for-nice-normal-classes.patch
>
>
> Classes that are marked final are lame. We shouldn't have them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CASSANDRA-706) final classes are so lame
Posted by "Gary Dusbabek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gary Dusbabek resolved CASSANDRA-706.
-------------------------------------
Resolution: Fixed
r899850
> final classes are so lame
> -------------------------
>
> Key: CASSANDRA-706
> URL: https://issues.apache.org/jira/browse/CASSANDRA-706
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.9
> Reporter: Jeff Hodges
> Fix For: 0.9
>
> Attachments: 0001-removing-all-final-classes-for-nice-normal-classes.patch
>
>
> Classes that are marked final are lame. We shouldn't have them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-706) final classes are so lame
Posted by "Gary Dusbabek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gary Dusbabek updated CASSANDRA-706:
------------------------------------
Fix Version/s: 0.9
Affects Version/s: 0.9
> final classes are so lame
> -------------------------
>
> Key: CASSANDRA-706
> URL: https://issues.apache.org/jira/browse/CASSANDRA-706
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.9
> Reporter: Jeff Hodges
> Fix For: 0.9
>
> Attachments: 0001-removing-all-final-classes-for-nice-normal-classes.patch
>
>
> Classes that are marked final are lame. We shouldn't have them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-706) final classes are so lame
Posted by "Gary Dusbabek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801002#action_12801002 ]
Gary Dusbabek commented on CASSANDRA-706:
-----------------------------------------
My review is that this patch is, indeed, awesome. That is my review. I've got a fever, and the only prescription is more of this patch.
> final classes are so lame
> -------------------------
>
> Key: CASSANDRA-706
> URL: https://issues.apache.org/jira/browse/CASSANDRA-706
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.9
> Reporter: Jeff Hodges
> Fix For: 0.9
>
> Attachments: 0001-removing-all-final-classes-for-nice-normal-classes.patch
>
>
> Classes that are marked final are lame. We shouldn't have them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-706) final classes are so lame
Posted by "Jeff Hodges (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeff Hodges updated CASSANDRA-706:
----------------------------------
Attachment: 0001-removing-all-final-classes-for-nice-normal-classes.patch
Removing the 'final' in 'final class'. Made with ack -l 'final class' src/ | xargs sed -i '' 's/final class/class/'. (Substituting grep for ack in there should work.)
> final classes are so lame
> -------------------------
>
> Key: CASSANDRA-706
> URL: https://issues.apache.org/jira/browse/CASSANDRA-706
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jeff Hodges
> Attachments: 0001-removing-all-final-classes-for-nice-normal-classes.patch
>
>
> Classes that are marked final are lame. We shouldn't have them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.