You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Sachchidanand Vaidya <va...@juniper.net> on 2013/12/13 22:54:14 UTC
Review Request 16258: Add new physical network isolationMethod (L3VPN) for
Juniper Contrail plugin.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16258/
-----------------------------------------------------------
Review request for cloudstack.
Repository: cloudstack-git
Description
-------
Add new physical network isolationMethod (L3VPN) for Juniper Contrail network Plugin. ContrailGuru checks for IsolationMethod before designing a VN.
Diffs
-----
api/src/com/cloud/network/PhysicalNetwork.java cfa236d
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java ea52be9
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ManagementServerMock.java c449b8a
ui/scripts/ui-custom/zoneWizard.js 28df193
Diff: https://reviews.apache.org/r/16258/diff/
Testing
-------
Changes pass unit tests and complete centos63 package build.
Thanks,
Sachchidanand Vaidya
Re: Review Request 16258: Add new physical network isolationMethod
(L3VPN) for Juniper Contrail plugin.
Posted by Sachchidanand Vaidya <va...@juniper.net>.
Thanks Sheng.
Best Regards,
Sachin
On 1/14/14 1:56 PM, "Sheng Yang" <sh...@yasker.org> wrote:
>
>-----------------------------------------------------------
>This is an automatically generated e-mail. To reply, visit:
>https://reviews.apache.org/r/16258/#review31812
>-----------------------------------------------------------
>
>Ship it!
>
>
>Applied to MASTER.
>
>Thanks.
>
>- Sheng Yang
>
>
>On Jan. 14, 2014, 9:44 p.m., Sachchidanand Vaidya wrote:
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/16258/
>> -----------------------------------------------------------
>>
>> (Updated Jan. 14, 2014, 9:44 p.m.)
>>
>>
>> Review request for cloudstack.
>>
>>
>> Repository: cloudstack-git
>>
>>
>> Description
>> -------
>>
>> Add new physical network isolationMethod (L3VPN) for Juniper Contrail
>>network Plugin. ContrailGuru checks for IsolationMethod before designing
>>a VN.
>>
>>
>> Diffs
>> -----
>>
>> api/src/com/cloud/network/PhysicalNetwork.java 5c348c2
>>
>>plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/netwo
>>rk/contrail/management/ContrailGuru.java 079035b
>>
>>plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/netw
>>ork/contrail/management/ManagementServerMock.java 806dd21
>> ui/scripts/ui-custom/zoneWizard.js 99aa3b9
>>
>> Diff: https://reviews.apache.org/r/16258/diff/
>>
>>
>> Testing
>> -------
>>
>> Changes pass unit tests and complete centos63 package build.
>>
>>
>> Thanks,
>>
>> Sachchidanand Vaidya
>>
>>
>
Re: Review Request 16258: Add new physical network isolationMethod (L3VPN)
for Juniper Contrail plugin.
Posted by Sheng Yang <sh...@yasker.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16258/#review31812
-----------------------------------------------------------
Ship it!
Applied to MASTER.
Thanks.
- Sheng Yang
On Jan. 14, 2014, 9:44 p.m., Sachchidanand Vaidya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16258/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2014, 9:44 p.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Add new physical network isolationMethod (L3VPN) for Juniper Contrail network Plugin. ContrailGuru checks for IsolationMethod before designing a VN.
>
>
> Diffs
> -----
>
> api/src/com/cloud/network/PhysicalNetwork.java 5c348c2
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java 079035b
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ManagementServerMock.java 806dd21
> ui/scripts/ui-custom/zoneWizard.js 99aa3b9
>
> Diff: https://reviews.apache.org/r/16258/diff/
>
>
> Testing
> -------
>
> Changes pass unit tests and complete centos63 package build.
>
>
> Thanks,
>
> Sachchidanand Vaidya
>
>
Re: Review Request 16258: Add new physical network isolationMethod (L3VPN)
for Juniper Contrail plugin.
Posted by Sachchidanand Vaidya <va...@juniper.net>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16258/
-----------------------------------------------------------
(Updated Jan. 14, 2014, 9:44 p.m.)
Review request for cloudstack.
Changes
-------
Updating the review diff based on the latest on ACS4.4.
Repository: cloudstack-git
Description
-------
Add new physical network isolationMethod (L3VPN) for Juniper Contrail network Plugin. ContrailGuru checks for IsolationMethod before designing a VN.
Diffs (updated)
-----
api/src/com/cloud/network/PhysicalNetwork.java 5c348c2
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java 079035b
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ManagementServerMock.java 806dd21
ui/scripts/ui-custom/zoneWizard.js 99aa3b9
Diff: https://reviews.apache.org/r/16258/diff/
Testing
-------
Changes pass unit tests and complete centos63 package build.
Thanks,
Sachchidanand Vaidya
Re: Review Request 16258: Add new physical network isolationMethod
(L3VPN) for Juniper Contrail plugin.
Posted by Sachchidanand Vaidya <va...@juniper.net>.
Hi Sheng,
I have updated the review with changes based off latest on ACS master.
Thanks & Best Regards,
Sachin
On 1/14/14 1:25 PM, "Sheng Yang" <sh...@yasker.org> wrote:
>
>-----------------------------------------------------------
>This is an automatically generated e-mail. To reply, visit:
>https://reviews.apache.org/r/16258/#review31802
>-----------------------------------------------------------
>
>
>Looks good to me, but cannot applied to the latest MASTER branch(I
>suppose that's the target).
>
>- Sheng Yang
>
>
>On Jan. 13, 2014, 5:46 a.m., Sachchidanand Vaidya wrote:
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/16258/
>> -----------------------------------------------------------
>>
>> (Updated Jan. 13, 2014, 5:46 a.m.)
>>
>>
>> Review request for cloudstack.
>>
>>
>> Repository: cloudstack-git
>>
>>
>> Description
>> -------
>>
>> Add new physical network isolationMethod (L3VPN) for Juniper Contrail
>>network Plugin. ContrailGuru checks for IsolationMethod before designing
>>a VN.
>>
>>
>> Diffs
>> -----
>>
>> api/src/com/cloud/network/PhysicalNetwork.java cfa236d
>>
>>plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/netwo
>>rk/contrail/management/ContrailGuru.java ea52be9
>>
>>plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/netw
>>ork/contrail/management/ManagementServerMock.java c449b8a
>> ui/scripts/ui-custom/zoneWizard.js 28df193
>>
>> Diff: https://reviews.apache.org/r/16258/diff/
>>
>>
>> Testing
>> -------
>>
>> Changes pass unit tests and complete centos63 package build.
>>
>>
>> Thanks,
>>
>> Sachchidanand Vaidya
>>
>>
>
Re: Review Request 16258: Add new physical network isolationMethod (L3VPN)
for Juniper Contrail plugin.
Posted by Sheng Yang <sh...@yasker.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16258/#review31802
-----------------------------------------------------------
Looks good to me, but cannot applied to the latest MASTER branch(I suppose that's the target).
- Sheng Yang
On Jan. 13, 2014, 5:46 a.m., Sachchidanand Vaidya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16258/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2014, 5:46 a.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Add new physical network isolationMethod (L3VPN) for Juniper Contrail network Plugin. ContrailGuru checks for IsolationMethod before designing a VN.
>
>
> Diffs
> -----
>
> api/src/com/cloud/network/PhysicalNetwork.java cfa236d
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java ea52be9
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ManagementServerMock.java c449b8a
> ui/scripts/ui-custom/zoneWizard.js 28df193
>
> Diff: https://reviews.apache.org/r/16258/diff/
>
>
> Testing
> -------
>
> Changes pass unit tests and complete centos63 package build.
>
>
> Thanks,
>
> Sachchidanand Vaidya
>
>
Re: Review Request 16258: Add new physical network isolationMethod (L3VPN)
for Juniper Contrail plugin.
Posted by Sachchidanand Vaidya <va...@juniper.net>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16258/
-----------------------------------------------------------
(Updated Jan. 13, 2014, 5:46 a.m.)
Review request for cloudstack.
Changes
-------
Minor correction to previous submission.
Repository: cloudstack-git
Description
-------
Add new physical network isolationMethod (L3VPN) for Juniper Contrail network Plugin. ContrailGuru checks for IsolationMethod before designing a VN.
Diffs (updated)
-----
api/src/com/cloud/network/PhysicalNetwork.java cfa236d
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java ea52be9
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ManagementServerMock.java c449b8a
ui/scripts/ui-custom/zoneWizard.js 28df193
Diff: https://reviews.apache.org/r/16258/diff/
Testing
-------
Changes pass unit tests and complete centos63 package build.
Thanks,
Sachchidanand Vaidya