You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/06/23 17:59:32 UTC

[GitHub] [incubator-tvm] mbrookhart opened a new pull request #5900: Add Binary Intrinsic ops to TIR Ops in C++

mbrookhart opened a new pull request #5900:
URL: https://github.com/apache/incubator-tvm/pull/5900


   @tqchen 
   
   These ops are already registered and tested through python, this simply adds them to the C++ API. I don't see tests for the existing instrinsic unary ops outside of python, do we test this C++ API?
   
   https://github.com/apache/incubator-tvm/blob/90b08f5e4ef5a40e1efb9a9ba2882df87b0a9391/tests/python/unittest/test_tir_intrin.py#L92-L134
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] tqchen merged pull request #5900: Add Binary Intrinsic ops to TIR Ops in C++

Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #5900:
URL: https://github.com/apache/incubator-tvm/pull/5900


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] tqchen commented on pull request #5900: Add Binary Intrinsic ops to TIR Ops in C++

Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #5900:
URL: https://github.com/apache/incubator-tvm/pull/5900#issuecomment-648476992


   Thanks @mbrookhart @junrushao1994 !


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org