[GitHub] [accumulo] keith-turner commented on a change in pull request #1596: Create public API for loading iterators. Closes #1388

[GitBox <gi...@apache.org>]

keith-turner commented on a change in pull request #1596:
URL: https://github.com/apache/accumulo/pull/1596#discussion_r416057960



##########
File path: core/src/main/java/org/apache/accumulo/core/client/admin/TableOperations.java
##########
@@ -957,6 +960,23 @@ IteratorSetting getIteratorSetting(String tableName, String name, IteratorScope
   Map<String,EnumSet<IteratorScope>> listIterators(String tableName)
       throws AccumuloSecurityException, AccumuloException, TableNotFoundException;
 
+  /**
+   * Create a stack of iterators from what is in the provided table properties and with the scope.
+   * The specified source will be the bottom of the stack and the top SortedKeyValueIterator on the
+   * stack will be returned.
+   *
+   * @param tableProps
+   *          the properties of the table where the iterators are configured
+   * @param scope
+   *          the scope of the iterators
+   * @param source
+   *          the iterator at the start of the stack
+   * @return the SortedKeyValueIterator at the top of the stack
+   * @since 2.1
+   */
+  SortedKeyValueIterator<Key,Value> loadIterators(Iterable<Entry<String,String>> tableProps,

Review comment:
       Since this a client side operation only and does nothing to a table, seems like it should be placed somwhere else.  Maybe a static method in the iterators package.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org