[Impala-ASF-CR] datasketches: improved merge and memory allocation - avoid overhead of constructing union and getting result from it every time - call destructors of sketch and union objects

["Fucun Chu (Code Review)" <ge...@cloudera.org>]

Fucun Chu has posted comments on this change. ( http://gerrit.cloudera.org:8080/17869 )

Change subject: datasketches: improved merge and memory allocation - avoid overhead of constructing union and getting result from it every time - call destructors of sketch and union objects
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/17869/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/17869/1//COMMIT_MSG@7
PS1, Line 7: datasketches: improved merge and memory allocation
First, you need to create a jira ticket for this patch at https://issues.apache.org/jira/browse/IMPALA
Second, please write a good, clear commit message, with a short, descriptive title and a message that is exactly long enough to explain what the problem was, and how it was fixed. Each should have 72 or fewer characters if possible.
The first line should have an empty line after it, and the first line should begin with the ticket(s) addressed, followed by a colon and a space, eg: "IMPALA-1234: ".



-- 
To view, visit http://gerrit.cloudera.org:8080/17869
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8dd0e6736f4266f74f5f265f58d40a4e4707287f
Gerrit-Change-Number: 17869
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Saydakov <al...@apache.org>
Gerrit-Reviewer: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Oct 2021 10:19:25 +0000
Gerrit-HasComments: Yes