You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "michael-o (via GitHub)" <gi...@apache.org> on 2023/04/25 15:37:04 UTC
[GitHub] [maven-site-plugin] michael-o opened a new pull request, #148: [MSITE-960] CI is broken
michael-o opened a new pull request, #148:
URL: https://github.com/apache/maven-site-plugin/pull/148
We need to separate the Fluido Skin version used for the ITs and dev profile from the site generation which depends on the parent POM config. Both can be incompatible.
This closes #148
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MSITE) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[MSITE-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `MSITE-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its clean verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-site-plugin] michael-o commented on pull request #148: [MSITE-960] +[MSITE-961]
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #148:
URL: https://github.com/apache/maven-site-plugin/pull/148#issuecomment-1525543988
> There's a test failure on JDK 17 that might or might not be related:
>
> Sourced file: inline evaluation of: `/* * Licensed to the Apache Software Foundation (ASF) under one * or more con . . . '' unknown error: Unable to make public boolean java.util.zip.ZipFile$ZipEntryIterator.hasMoreElements() accessible: module java.base does not "opens java.util.zip" to unnamed module @3c963678 : at Line: 28 : in file: inline evaluation of:` /* * Licensed to the Apache Software Foundation (ASF) under one * or more con . . . '' : try {
>
> ```
> at bsh.Interpreter.eval(Interpreter.java:706)
> at bsh.Interpreter.eval(Interpreter.java:750)
> ```
>
> I'm not sure why this might come from this PR, but I haven't seen this error message before so it's worth checking.
This is a different issue, not related to the site descriptor. I took a peek at it, but don't understand because all methods are public and I am not familiar with JPMS, but I was able to reproduce it reliably. I'd like to address this in a different PR when I understand the cause.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-site-plugin] michael-o commented on pull request #148: [MSITE-960] +[MSITE-961]
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #148:
URL: https://github.com/apache/maven-site-plugin/pull/148#issuecomment-1525298871
@elharo Please have a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-site-plugin] asfgit merged pull request #148: [MSITE-960] +[MSITE-961]
Posted by "asfgit (via GitHub)" <gi...@apache.org>.
asfgit merged PR #148:
URL: https://github.com/apache/maven-site-plugin/pull/148
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-site-plugin] michael-o commented on pull request #148: [MSITE-960] +[MSITE-961]
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #148:
URL: https://github.com/apache/maven-site-plugin/pull/148#issuecomment-1525905338
@elharo Is this acceptable for you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-site-plugin] elharo commented on pull request #148: [MSITE-960] +[MSITE-961]
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on PR #148:
URL: https://github.com/apache/maven-site-plugin/pull/148#issuecomment-1525468715
There's a test failure on JDK 17 that might or might not be related:
Sourced file: inline evaluation of: `` /* * Licensed to the Apache Software Foundation (ASF) under one * or more con . . . '' unknown error: Unable to make public boolean java.util.zip.ZipFile$ZipEntryIterator.hasMoreElements() accessible: module java.base does not "opens java.util.zip" to unnamed module @3c963678 : at Line: 28 : in file: inline evaluation of: `` /* * Licensed to the Apache Software Foundation (ASF) under one * or more con . . . '' : try {
at bsh.Interpreter.eval(Interpreter.java:706)
at bsh.Interpreter.eval(Interpreter.java:750)
I'm not sure why this might come from this PR, but I haven't seen this error message before so it's worth checking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org