You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/02/27 06:21:28 UTC

[GitHub] [hive] dengzhhu653 commented on a change in pull request #1992: HIVE-24792: Potential thread leak in Operation

dengzhhu653 commented on a change in pull request #1992:
URL: https://github.com/apache/hive/pull/1992#discussion_r584048277



##########
File path: service/src/java/org/apache/hive/service/cli/operation/Operation.java
##########
@@ -326,6 +326,7 @@ protected synchronized void cleanupOperationLog(final long operationLogCleanupDe
         if (operationLogCleanupDelayMs > 0) {
           scheduledExecutorService.schedule(new OperationLogCleaner(operationLog), operationLogCleanupDelayMs,
             TimeUnit.MILLISECONDS);
+          scheduledExecutorService.shutdown();

Review comment:
       Yes, thanks very much for the advice.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org