You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "SANDEEPNEGI07 (via GitHub)" <gi...@apache.org> on 2025/10/25 16:25:32 UTC
[PR] Replace deprecated min parameter with validate=Range() to support mar… [superset]
SANDEEPNEGI07 opened a new pull request, #35844:
URL: https://github.com/apache/superset/pull/35844
…shmallow>=4.0.0
fix(charts): update Prophet schema for Marshmallow>=4.0.0 compatibility
### SUMMARY
Fixes Marshmallow 4.0 compatibility issue in `ChartDataProphetOptionsSchema`.
periods field was using `min` which was deprecated in the marshmallow>=4.0.0. This caused a `TypeError: __init__() got an unexpected keyword argument 'min'`
Used `validate=Range()` instead of `min`, which is compatible with both Marshmallow>=4.0.0.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A - Backend schema validation fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: Replace deprecated min parameter with validate=Range() to support marshmallow>=4.0.0 [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #35844:
URL: https://github.com/apache/superset/pull/35844#issuecomment-3544211338
Superset uses Git pre-commit hooks courtesy of [pre-commit](https://pre-commit.com/). To install run the following:
```
pip3 install -r requirements/development.txt
pre-commit install
```
A series of checks will now run when you make a git commit.
Alternatively it is possible to run pre-commit by running pre-commit manually:
```
pre-commit run --all-files
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: Replace deprecated min parameter with validate=Range() to support marshmallow>=4.0.0 [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #35844:
URL: https://github.com/apache/superset/pull/35844#issuecomment-4318473714
@SANDEEPNEGI07 — gentle ping on this one. The fix itself looks reasonable, but the branch has drifted: it now has merge conflicts with master and CI is red. Could you rebase on the latest master, run `pre-commit run --all-files`, and push so we can get CI green? If you're no longer able to pick this back up, just let us know and we can close it (or someone can adopt the change). Thanks for the contribution either way!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: Replace deprecated min parameter with validate=Range() to support marshmallow>=4.0.0 [superset]
Posted by "SANDEEPNEGI07 (via GitHub)" <gi...@apache.org>.
SANDEEPNEGI07 commented on PR #35844:
URL: https://github.com/apache/superset/pull/35844#issuecomment-4318524977
[rusackas](https://github.com/rusackas) I'll check and push to make the CI Green.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] Replace deprecated min parameter with validate=Range() to support mar… [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #35844:
URL: https://github.com/apache/superset/pull/35844#issuecomment-3446883172
<details open>
<summary><strong>Interaction Diagram by <a href="https://bito.ai#sequence_diagram">Bito</a></strong></summary>
```mermaid
sequenceDiagram
participant API as REST API Layer
participant QC as ChartDataQueryContextSchema
participant PO as ChartDataProphetOptionsSchema<br/>🔄 Updated | ●●○ Medium
participant Validator as Range Validator<br/>🟩 Added | ●●○ Medium
participant Prophet as prophet() Function
Note over PO: Marshmallow 4.0+ compatibility<br/>Replace min param with validate=Range()
API->>QC: POST /api/v1/chart/data
QC->>PO: Load post_processing options
PO->>Validator: Validate periods field
Validator-->>PO: periods >= 0 check
PO-->>Prophet: Pass validated options
Prophet-->>API: Return forecast results
```
Critical path: REST API Layer->ChartDataQueryContextSchema->ChartDataProphetOptionsSchema->Range Validator->prophet() Function
> **Note:** The periods field in ChartDataProphetOptionsSchema is updated to use Marshmallow 4.0+ compatible Range validator instead of deprecated min parameter. This ensures compatibility with newer Marshmallow versions while maintaining the same validation logic (periods must be >= 0).
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: Replace deprecated min parameter with validate=Range() to support marshmallow>=4.0.0 [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #35844:
URL: https://github.com/apache/superset/pull/35844#issuecomment-4747872119
@SANDEEPNEGI07 this still has conflicts with master and CI is red, so we can't merge as-is. Heads up that master already changed the `periods` field to `validate=validate_prophet_periods` (no more `min=0`), so after a rebase the original diff may be a no-op — can you check whether anything's actually left to fix here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: Replace deprecated min parameter with validate=Range() to support marshmallow>=4.0.0 [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #35844:
URL: https://github.com/apache/superset/pull/35844#issuecomment-3457655744
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/35844?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 50.32%. Comparing base ([`76d897e`](https://app.codecov.io/gh/apache/superset/commit/76d897eaa2f9e137102bc194c2e3109c29d0348f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`5bdf534`](https://app.codecov.io/gh/apache/superset/commit/5bdf534def21446c5656baf80877714a529d6d74?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2799 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #35844 +/- ##
===========================================
- Coverage 60.48% 50.32% -10.17%
===========================================
Files 1931 600 -1331
Lines 76236 44009 -32227
Branches 8568 4767 -3801
===========================================
- Hits 46114 22147 -23967
+ Misses 28017 21238 -6779
+ Partials 2105 624 -1481
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/35844/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hive](https://app.codecov.io/gh/apache/superset/pull/35844/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.90% <ø> (-3.25%)` | :arrow_down: |
| [javascript](https://app.codecov.io/gh/apache/superset/pull/35844/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [presto](https://app.codecov.io/gh/apache/superset/pull/35844/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.57% <ø> (-4.23%)` | :arrow_down: |
| [python](https://app.codecov.io/gh/apache/superset/pull/35844/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `50.31% <ø> (-13.19%)` | :arrow_down: |
| [unit](https://app.codecov.io/gh/apache/superset/pull/35844/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `100.00% <ø> (+42.36%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/35844?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: Replace deprecated min parameter with validate=Range() to support marshmallow>=4.0.0 [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #35844:
URL: https://github.com/apache/superset/pull/35844#issuecomment-4318812805
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers a full AI review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: Replace deprecated min parameter with validate=Range() to support marshmallow>=4.0.0 [superset]
Posted by "SANDEEPNEGI07 (via GitHub)" <gi...@apache.org>.
SANDEEPNEGI07 commented on PR #35844:
URL: https://github.com/apache/superset/pull/35844#issuecomment-4318521772
> @SANDEEPNEGI07 — gentle ping on this one. The fix itself looks reasonable, but the branch has drifted: it now has merge conflicts with master and CI is red. Could you rebase on the latest master, run `pre-commit run --all-files`, and push so we can get CI green? If you're no longer able to pick this back up, just let us know and we can close it (or someone can adopt the change). Thanks for the contribution either way!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: Replace deprecated min parameter with validate=Range() to support marshmallow>=4.0.0 [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed pull request #35844: fix: Replace deprecated min parameter with validate=Range() to support marshmallow>=4.0.0
URL: https://github.com/apache/superset/pull/35844
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: Replace deprecated min parameter with validate=Range() to support marshmallow>=4.0.0 [superset]
Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #35844:
URL: https://github.com/apache/superset/pull/35844#issuecomment-4318607785
### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | 0ced71cdd10bffc682003a1de593584ba4858884 |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/69ec839ccab7ea0008fce3ac |
|<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-35844--superset-docs-preview.netlify.app](https://deploy-preview-35844--superset-docs-preview.netlify.app) |
|<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br /><br /><br />_Use your smartphone camera to open QR code link._</details> |
---
<!-- [superset-docs-preview Preview](https://deploy-preview-35844--superset-docs-preview.netlify.app) -->
_To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] Replace deprecated min parameter with validate=Range() to support mar… [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #35844:
URL: https://github.com/apache/superset/pull/35844#issuecomment-3446880405
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers a full AI review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Default Agent` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: Replace deprecated min parameter with validate=Range() to support marshmallow>=4.0.0 [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #35844:
URL: https://github.com/apache/superset/pull/35844#issuecomment-4785516607
Confirmed master now validates `periods` via `validate_prophet_periods` (Range min=1/max), which already handles the Marshmallow 4 issue and is stricter than this. Nothing left to fix here, so I'll close it as superseded. Thanks for the original catch, Sandeep!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org