You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/03/17 10:39:29 UTC

[GitHub] [incubator-yunikorn-core] manirajv06 commented on pull request #387: [YUNIKORN-1124] Avoid passing empty nodeAttributes in UpdateNode request

manirajv06 commented on pull request #387:
URL: https://github.com/apache/incubator-yunikorn-core/pull/387#issuecomment-1070773205


   Notes:
   
   1. Leaving "yunikorn.apache.org/nodeType" change as is for now. @craigcondit can comment on this.
   2. I think we should handle "Ready" attribute also as any other node attributes. Managing each attribute in a separate place doesn't seem to be clean and organised, may didn't get our attention at times. Yes, it may change during UpdateNode as well but still we should handle it in `initializeAttribute`, `GetAttribute` methods using appropriate locks like how listeners are being handled.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org