You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/01/18 11:06:00 UTC
[GitHub] [kafka] Kvicii opened a new pull request #11687: Fix flaky test ControllerIntegrationTest.testTopicIdUpgradeAfterReassigningPartitions
Kvicii opened a new pull request #11687:
URL: https://github.com/apache/kafka/pull/11687
this issue similar to https://github.com/apache/kafka/pull/11666.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] Kvicii commented on pull request #11687: KAFKA-13592:Fix flaky test ControllerIntegrationTest.testTopicIdUpgradeAfterReassigningPartitions
Posted by GitBox <gi...@apache.org>.
Kvicii commented on pull request #11687:
URL: https://github.com/apache/kafka/pull/11687#issuecomment-1017010507
@dajac I used `computeUntilTrue`, but it is also very difficult to reproduce using a script☹️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] Kvicii edited a comment on pull request #11687: KAFKA-13592:Fix flaky test ControllerIntegrationTest.testTopicIdUpgradeAfterReassigningPartitions
Posted by GitBox <gi...@apache.org>.
Kvicii edited a comment on pull request #11687:
URL: https://github.com/apache/kafka/pull/11687#issuecomment-1017010507
@dajac I used `computeUntilTrue`, but it is also very difficult to reproduce using a script.I tried a few other ways, but none seem to work😔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dajac commented on pull request #11687: KAFKA-13592:Fix flaky test ControllerIntegrationTest.testTopicIdUpgradeAfterReassigningPartitions
Posted by GitBox <gi...@apache.org>.
dajac commented on pull request #11687:
URL: https://github.com/apache/kafka/pull/11687#issuecomment-1016614978
@Kvicii `ControllerIntegrationTest.testTopicIdUpgradeAfterReassigningPartitions` does not fail all the time but only occasionally. It seems that there is a race condition in the test which causes it. I suggest to first try to reproduce the failure by running the test in a while loop. You can do the following:
```
while ./gradlew cleanTest :core:test --tests ControllerIntegrationTest.testTopicIdUpgradeAfterReassigningPartitions; do :; done;
```
Once we understand the issue, we can improve the test to fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] Kvicii commented on pull request #11687: KAFKA-13592:Fix flaky test ControllerIntegrationTest.testTopicIdUpgradeAfterReassigningPartitions
Posted by GitBox <gi...@apache.org>.
Kvicii commented on pull request #11687:
URL: https://github.com/apache/kafka/pull/11687#issuecomment-1016606448
@dajac The first build failed didn't seem to be because of this test, so I rebuilt it.Can you tell me what the expectations should be, thanks a lot
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dajac commented on pull request #11687: KAFKA-13592:Fix flaky test ControllerIntegrationTest.testTopicIdUpgradeAfterReassigningPartitions
Posted by GitBox <gi...@apache.org>.
dajac commented on pull request #11687:
URL: https://github.com/apache/kafka/pull/11687#issuecomment-1016569873
@Kvicii Thanks for the PR. I am a bit confused because the PR refactors the code but it does not seem to fix any issues. Did I miss something? Have you been able to make the test fail?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] Kvicii removed a comment on pull request #11687: KAFKA-13592:Fix flaky test ControllerIntegrationTest.testTopicIdUpgradeAfterReassigningPartitions
Posted by GitBox <gi...@apache.org>.
Kvicii removed a comment on pull request #11687:
URL: https://github.com/apache/kafka/pull/11687#issuecomment-1016586326
>
The first time it failed due to other tests, so I rebuilt it. During the build I see that testTopicIdCreatedOnUpgrade has passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] Kvicii commented on pull request #11687: KAFKA-13592:Fix flaky test ControllerIntegrationTest.testTopicIdUpgradeAfterReassigningPartitions
Posted by GitBox <gi...@apache.org>.
Kvicii commented on pull request #11687:
URL: https://github.com/apache/kafka/pull/11687#issuecomment-1016586326
>
The first time it failed due to other tests, so I rebuilt it. During the build I see that testTopicIdCreatedOnUpgrade has passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org