[GitHub] [helix] lei-xia commented on a change in pull request #863: Make ZkCacheBaseDataAccessor and ZkHelixPropertyStore realm-aware

[GitBox <gi...@apache.org>]

lei-xia commented on a change in pull request #863: Make ZkCacheBaseDataAccessor and ZkHelixPropertyStore realm-aware
URL: https://github.com/apache/helix/pull/863#discussion_r389469451
 
 

 ##########
 File path: helix-core/src/main/java/org/apache/helix/manager/zk/ZkCacheBaseDataAccessor.java
 ##########
 @@ -842,4 +894,116 @@ public void close() {
       _zkClient.close();
     }
   }
+
+  public static class Builder {
 
 Review comment:
   1) This Builder code is very similar across all Helix APIs, I do recommend us to find some way to consolidate them. 
   2) For existing use case (who do not care about realm, or who is not  going to shard to multiple ZK), do they need to change anything in their code?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org